Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 23 Jul 2022 21:45:00 -0100
From:   Melissa Wen <mwen@igalia.com>
To:     Danilo Krummrich <dakr@redhat.com>
Cc:     airlied@linux.ie, daniel@ffwll.ch, mripard@kernel.org,
        christian.koenig@amd.com, emma@anholt.net,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND 08/10] drm/v3d: use idr_init_base() to initialize
 v3d_priv->perfmon.idr
Message-ID: <20220723224500.w6pezv3ojgu2d6qi@mail.igalia.com>
References: <20220720132830.193747-1-dakr@redhat.com>
 <20220720132830.193747-9-dakr@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7efy5bucdwv7jzri"
Content-Disposition: inline
In-Reply-To: <20220720132830.193747-9-dakr@redhat.com>
Precedence: bulk


--7efy5bucdwv7jzri
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07/20, Danilo Krummrich wrote:
> idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based
> IDRs more efficient"), let us set an arbitrary base other than
> idr_init(), which uses base 0.
>=20
> Since, for this IDR, no ID < 1 is ever requested/allocated, using
> idr_init_base(&idr, 1) avoids unnecessary tree walks.
>=20
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> Acked-by: Christian K=F6nig <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/v3d/v3d_perfmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_=
perfmon.c
> index f6a88abccc7d..48aaaa972c49 100644
> --- a/drivers/gpu/drm/v3d/v3d_perfmon.c
> +++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
> @@ -95,7 +95,7 @@ struct v3d_perfmon *v3d_perfmon_find(struct v3d_file_pr=
iv *v3d_priv, int id)
>  void v3d_perfmon_open_file(struct v3d_file_priv *v3d_priv)
>  {
>  	mutex_init(&v3d_priv->perfmon.lock);
> -	idr_init(&v3d_priv->perfmon.idr);
> +	idr_init_base(&v3d_priv->perfmon.idr, 1);

Reviewed-by: Melissa Wen <mwen@igalia.com>

Thanks

>  }
> =20
>  static int v3d_perfmon_idr_del(int id, void *elem, void *data)
> --=20
> 2.36.1
>=20

--7efy5bucdwv7jzri
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEd8WOo/JViG+Tu+XIwqF3j0dLehwFAmLced8ACgkQwqF3j0dL
ehwGIw/+LUNPvk78JTm0C8+zpXW9CrRPyarEFWTgL6cZSa0dyd/ssidCxMUx7pjs
G9YBT60Aq7k/TP0wYcebKKXY2UkPrrPrrIRMqpSarTFqMa9d9XBT3KFlgiYrtGI9
gCAwEPOi/o5oKphAXvRP9KWC6qcZyCPhUPmHsCMRBOsvY3HYvyj+EYb90d0jrwY0
ZdbNzVsHTDikQfKMttZo2kWYwNhSfcCO0qKMx7ccj7FssJmTeB2Rf8vRIOiChfIe
B0614Rp7UmUkXlTrK57YzWMWNRegVWbE6EVGm7E5ojRZjio87RJVcYGJG0YelQ9Y
E778NCZffqfoQiQzf7PLq0qef6LvbOBUZGqbYcLA1qMu0R1AGtBHrvhUXuVUNlsD
eMCHYmAUBK6byXJCOx9zW44iFSFaSJIyw0eiNu3oCXdxkKXCUitn+EvymPyVKEDQ
ilJprF8nuM4nGkDszQn/UiZychB4C2VpDveVFdNo6G8PONjaq6dx7QQasAuNAbYZ
n3n0Co8+T72vfnbMm5DNTks0JaFrCoSevpTVCQSE9iEqVSFE5i3uVDpcbzyb/0CJ
CvgiWMqBS7Yl+bXtRKD4HllJ+YsIhEl9N0dwbdGxJ7OSZ7jcHYb6TTKl9b1y/qf3
qbuPBlL9zQ+7WjZfh7WDGrxpdwnr/X8+xXduHHTcOX4UbnC7AyM=
=GlXz
-----END PGP SIGNATURE-----

--7efy5bucdwv7jzri--