Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <quic_cang@quicinc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Topic: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Index: AQHYmz2OvInxSH8TlUq8qOHvad4nHq2M7bBw
Date:   Sun, 24 Jul 2022 04:07:44 +0000
Message-ID: <DM6PR04MB65757CEC7F66AB732EF5FC48FC929@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com>
 <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
In-Reply-To: <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ratuYfsLPbMR4X6+TeRBDBFZgVtTQska6mQlH+ohom0aOlds4wD00kNVI5vQ?=
 =?us-ascii?Q?5SHFqaTApMguw8KVr2x6qnNMxwli1sy/pmJC4AA+XcJVWTrxRmIhsIP8WNDJ?=
 =?us-ascii?Q?NbxCEVNRjRVk2mbCWO3C/7gOJoygB/avsIC5eOIAW7okiui5iwLpT+QUPSTs?=
 =?us-ascii?Q?UpBV9wD9/osJBxGsYRpDTBR0NHoDY/zxaNkAydXiba5HJ1Hc1y1KbCiIxAOq?=
 =?us-ascii?Q?4BM1EPnZYqHMPQTylluw7IStCiD8rmDLJ1gbKvcB5pHdi+46FTx80msnHsgU?=
 =?us-ascii?Q?5vVsD+hXLA8Df1czmCnQSBXxNqq6uhZ43Oox+1fOeWMOwzGZ3NaalWQ/odlV?=
 =?us-ascii?Q?a2llZBP02gKaeHHcdh8q3Op8EC9LUEfrPEaUa4S3S+ZBmjBA8cvq6nuvZEkO?=
 =?us-ascii?Q?PMrLLTbx6wgErXDZSb0ZGgbxkw2ob30UpSYC3cjBEJro191t1NRYtINHq4EH?=
 =?us-ascii?Q?PNToBjLQ/JDt5qPXHlnthi3v2SZs0T7AbHe5hJ0ggIPn5zkS5ZKKrkAtJPjp?=
 =?us-ascii?Q?ZdzPp7VU4DeErMXpYJmpgBu5rMhx+WRtGd+YMIaVWvdAiopXZydLJ7pIYszf?=
 =?us-ascii?Q?mSKsq0wkbWYWxqJdK1jaWQcltw1o4KWQC7CoyuakSuVGyTY6pOrLPGkjsBZe?=
 =?us-ascii?Q?A1ijko10IbaC5NJyZROzYeW7QHCqgD/NWqT8hQRCK2HfZLntnk7+vnqzRVh6?=
 =?us-ascii?Q?DiZvq8cNvpx/0mvvDmbqBZJ63U41WGDqC6wTdn7jlXaIteNEC6Y+iTbdn7cv?=
 =?us-ascii?Q?80uHjN5+fVfK4Q8hLSQ9KLqihw9QykpqICKG0Z7ZFYQQvRnY8OVfp/+mVmN8?=
 =?us-ascii?Q?UV6svOjxLly+VQaNaYZZiz/Ia3VkqA3TLmCHl/9r5jofOJFLUlsyBV292Coc?=
 =?us-ascii?Q?52A/sw3QCYeVYIKhmpms09O0WXdxvRzhCVnSH+B8NXoMoYrpn8OqOwI67Wcy?=
 =?us-ascii?Q?gNpsI8IimnvzjolnCU+IWCik9hknxyVvOpmLnV7Cbd78n/aVHBwxGqwbEHLK?=
 =?us-ascii?Q?bYbDVfc8jwaSdPI6dyGwLo2I8hn0KRDA3M4N8K4sc74CxyxQYSfhJKaFgW/E?=
 =?us-ascii?Q?yZV/5f39XhmwvW/bpcWiyTitsby1uf4YAEjULacNgqi4+tdOw0Mvr9v1mH4C?=
 =?us-ascii?Q?jH/JjudZvjN4q66kmf/Twtd7q4c6npvtEHGCPD7QFKcY79xDyEeIi3QBkk+Z?=
 =?us-ascii?Q?E8rTonLqUhAxbEE3UdQdM52oZG2RpTiu/YDT3taFT1QYQDfQhF9srWz/QPcB?=
 =?us-ascii?Q?ZL6ydHZud4v3K70eBqR8t53oBHlzKhbkNXKqaE3LwCEWJ/ST09yEY1xY7TH8?=
 =?us-ascii?Q?z5NsWmWIQqLRJqyF9OSJvLydVfHg3WVaCodxN9KlyFnPY3kfLBuucDE3x2iZ?=
 =?us-ascii?Q?HOEVbxiGrfbzLAttJADmWpEBoJw8vYJck4feuLTi7a2Xe9/l/ahTVc/wmALd?=
 =?us-ascii?Q?L5Yd/ulb8Sr0Yfp6mbCuUG5elHj8So0CjGnyLwwK6pbktn9tAeDER2dx7yyS?=
 =?us-ascii?Q?AwqMIKYFTgTHzzUgI3IR71xjSSDcZM6mFK3plM2As02dh7u/0WaSFnZ7bZpQ?=
 =?us-ascii?Q?EL4o8YtDGuJgW8Ml4lYP7lzdmF1isz+mePTyZ3y/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a772bee-703f-4378-4c0f-08da6d2a0fdc
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2022 04:07:44.8027
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NhIv3PVMOHJMFGnK3AA/AX+CVnRBzAmQz2ylnil4hoxFni8U10lfJtdRfYWYIoIIlX+5dp4jfKfnG8O6xsQfdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4410
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -2558,7 +2587,8 @@ void ufshcd_prepare_utp_scsi_cmd_upiu(struct
> ufshcd_lrb *lrbp, u8 upiu_flags)
>                                 UPIU_TRANSACTION_COMMAND, upiu_flags,
>                                 lrbp->lun, lrbp->task_tag);
>         ucd_req_ptr->header.dword_1 =3D UPIU_HEADER_DWORD(
> -                               UPIU_COMMAND_SET_TYPE_SCSI, 0, 0, 0);
> +                               UPIU_COMMAND_SET_TYPE_SCSI |
> +                               (lrbp->hw_queue_id << 4), 0, 0, 0);
This is fine, as long as we have 16 queues or less.
Otherwise, we need to fill the EXT_IID as well (only if bEXTIIDEn =3D 1).

Also, don't we need to do this for query commands as well?
Or at least add a comment that the queue id for query command is 0.

Thanks,
Avri