Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <quic_cang@quicinc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Topic: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Thread-Index: AQHYmz2OvInxSH8TlUq8qOHvad4nHq2M9MHg
Date:   Sun, 24 Jul 2022 04:32:11 +0000
Message-ID: <DM6PR04MB657540D8D6584C15C8701767FC929@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com>
 <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
In-Reply-To: <1658214120-22772-2-git-send-email-quic_cang@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6sFfi4f/EmJ0iaeA0DFTGSO8cDEHfoet7nsGuA2BJmPPrRJDupnZgk/h1gr7?=
 =?us-ascii?Q?DOuq14J1FKhabGzC6XNheTP0Ixp1E8cu0AgBO+qqGIrQta5JYf3Vc7QlfCRh?=
 =?us-ascii?Q?Yn6dPMWrrAMz+OtIgwz+xOv6rFSifrpYEEEYePtdmwsetf6qK9lb7uRtCpMC?=
 =?us-ascii?Q?dCCbH2PS5sx0Bh6kJff4fI2hgsUCtfiFyf9Hs5yGYX/NZYFpIT3mEx5aH+Vi?=
 =?us-ascii?Q?qpB/sOBSJ+wRvWFMe6+btr+L2PP+885LKPsVgRc9zKTAbANx+DhtVfejIYB5?=
 =?us-ascii?Q?eLNQf94p+W5lnz9hLW2rs7qtGPhLUcLPEYStF+8CdO8Kte6xbpO8olavF6FW?=
 =?us-ascii?Q?DayFx6LDx/SDxCnfzQlcbM1+nhsyh6iGWsGsXw/mJYjjRO1ya5JVdSpIohvy?=
 =?us-ascii?Q?Ivl6svkairy8F7Zn86q+bsBa6PsZPl8x+fedHdueVy8/ef04fRae8u7n3xZC?=
 =?us-ascii?Q?t1JkiAC/7Gt4HT+wzg09nW/UkAA7de9Epz661wB/0MOIeogS7tWuPfadrO++?=
 =?us-ascii?Q?krtrtYRaqfPCYNFUUBIhGw+912ZcoKXs5rm0jO12ZqiMMzaruJtE75rjLhzP?=
 =?us-ascii?Q?MVZkqaIC/YQkw9+l91UJodroz+IYXVReywcfxzPybz9rix0IRW3BuULF4dcl?=
 =?us-ascii?Q?/jczNBmqbuFfoFE5ouIhmdeHWZ7XAc4RCiYQ6J6vTGUb9BCDDUrKy6qOb0im?=
 =?us-ascii?Q?w9nMR9ClkdcGsGHQ0Aqtgr3YIA3gtdXkW4ZMupAA1hKxYfyqwVY1HOZ57nYb?=
 =?us-ascii?Q?Dad5Q+SUmdLbuoIXDuyQXgRMUQIE19+bHd6Kh+SrMbNQQyfYuX4jaC3sW7kN?=
 =?us-ascii?Q?ZdkCxPuJoYSHSkTUyYn72O8ISitOla+OTKqQDzWtujo4PB6WpgVLKIXHZ1GT?=
 =?us-ascii?Q?gbpLo81g4XRdI7bk2GHIjUsXGl7SwR2iWYDydmvJ1bGVDiKwofsHkfql0VOh?=
 =?us-ascii?Q?CsskFUFZiGuBcYCk89O6yCEgtb2nNOzt3gh9PVfoHUXrdNLnejH/a/GWdfJP?=
 =?us-ascii?Q?Gu0+ZkoaDvTyk9hQCIaaJcKqLz0IclC3RjZVIKS1zhj4IlMPuo/3WV/DKUWz?=
 =?us-ascii?Q?yW5ULU2vSvazLpUdq3tVlbQquFYZYaFlxhnAbdl620HoLFLMscOPy6zv8iSV?=
 =?us-ascii?Q?8dIyQWNFFbbK770GfgFy0gNne1OoaaaskpN2hC7UXtYjUyA19mEMycm0Rs9w?=
 =?us-ascii?Q?0NuFkc2RWNuSW8VpIjFps2qyQI/XbGdkBmUOXEdZIpc/EjGN92fVm3/gzP18?=
 =?us-ascii?Q?xYMZEgQhHne8ANCKZOXjI9onbxXAYWxRIxJk/YuD4CEXitwt8d+3ubww2fjA?=
 =?us-ascii?Q?y1DRLUqNcPG3R+kNNwSZt3BaUia9xJP5vC3s+JLSonExvcMDz6665nNGYu/s?=
 =?us-ascii?Q?g0pvWuZdW3sJ+qXaBpiLLqZxT1T7azwYhLWYIVtRoYEIywjbkjP3L4DN+N6T?=
 =?us-ascii?Q?MNKxT2nD4B1dgFfVT+ZnTVI4UBzeMd4vt5scjc5hpz+H0LoHc4hbSe9J4C4P?=
 =?us-ascii?Q?sy4Vjoa34SOPkZU5xFx5oSis5cYYZ3evey4TobGS2wfCjejH0zaJsXo4TnHf?=
 =?us-ascii?Q?p/6beVp/VLdcvZNOGRbfSETezE77+wFLeDhinnGD?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d49e08a-3d4d-479f-63da-08da6d2d79eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2022 04:32:11.2302
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Hp2jOnnEC2M8lBZZmATCBGMu/vDpYarD7qnjTZ65nCdk6kiZkEApGA+kWM1x5NHcAGhvQTbPicHRdNQKaRGG9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR04MB8121
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +
> +/**
> + * @ucdl_base_addr: UFS Command Descriptor base address
> + * @sqe_base_addr: submission queue entry base address
> + * @sqe_shadow_addr: submission queue entry shadow address
When you are editing your commit log, could you please also say something a=
bout the shadow queues concept?
And why it is a good idea to maintain 2 sets of addresses, which basically =
points to the same place?

Thanks,
Avri