Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 24 Jul 2022 13:18:22 +0530
From:   Siddh Raman Pant <code@siddh.me>
To:     "Hillf Danton" <hdanton@sina.com>
Cc:     "David Howells" <dhowells@redhat.com>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        "syzbot+c70d87ac1d001f29a058" 
        <syzbot+c70d87ac1d001f29a058@syzkaller.appspotmail.com>,
        "linux-security-modules" <linux-security-module@vger.kernel.org>,
        "linux-kernel-mentees" 
        <linux-kernel-mentees@lists.linuxfoundation.org>
Message-ID: <1822f2dbbef.8458d4be628891.5196957454517111607@siddh.me>
In-Reply-To: <20220724071958.2557-1-hdanton@sina.com>
References: <20220724052426.2504-1-hdanton@sina.com> <20220724071958.2557-1-hdanton@sina.com>
Subject: Re: [PATCH v2] kernel/watch_queue: Make pipe NULL while clearing
 watch_queue
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

On Sun, 24 Jul 2022 12:49:58 +0530  Hillf Danton <hdanton@sina.com> wrote:
> Given defunct serialized, still need to clear wqueue->pipe in the clear
> path as proposed?

I am not sure what you mean by this...

If you mean freeing the pipe, it is done by free_pipe_info(), which is
the caller of watch_queue_clear().

If you mean making wqueue->pipe NULL, it is being done so in the patch.

Thanks,
Siddh