Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp1977189imi; Sun, 24 Jul 2022 03:07:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uGMTv/oUpAxJsIWbEqZhUBqFaVBlr8s43nW92GWeV13h9jX0ymyAaxWN0K5E9c5yyb+5hn X-Received: by 2002:a17:903:41c5:b0:16d:59ef:eb00 with SMTP id u5-20020a17090341c500b0016d59efeb00mr4993999ple.161.1658657268071; Sun, 24 Jul 2022 03:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658657268; cv=none; d=google.com; s=arc-20160816; b=bMSi1rIWcTD/sNYBCNHv7/+nma/jb4Q884Q+C6rYz+hYbjzDpj9GVI/yE1i1LzdFbH lAynJ5tUED1DwY+Snehzt8WKVxwBdEQsB7z5fyQYDaexe2zPKBF7scfvOUFL0SYDhaAL 2zZAig/nLuZpoN8aiDEG28tpoXap3nG7zZ2nS35/eSnCJkJOY2uhnUPnEHU5eVWYoLiN i9BE69SvJsWzQpWu+/GBQ9whVO0yEaNZxQWGfvXne5C44JQvL3F0L/p1dGNYkza/9g+C YjnGZdPk59LMrV9d2ie8OkasHdq+FxEvwhisKBnTAhcRnFfWUn+/lbtv/vvuuHTOy9+A Rw0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ADvPD0I29Jhmj4LK8NZk3MT3Dfj0tmGy9tggGOZWVh8=; b=o6K74sgxKNA6Ow1I52RX7tPa/Y4Rw14UpivvnJ8izSGxx4V1w3aPxVqNq/5gpCkTFc /gxQvsz+fdCo/WlicXmDQU0++mYi4Hw066AkipcLDdko4K/KI0r4fioLU4rJtKEhmVGQ Q8Ti15nSDsmOx6L53OAJhRQ48fsTPOAmGeMQJ+p1NYT/UY03cv67d4we4RzFrGTs48YG 0v+Ex4Ktr33vfRSoXDYxMGFpOGqBL8+fh00/DPHCxiODFeagEpBA8JOqU7gHjVVUNVTZ mCZmJuUFttZ1zsn4MrgCAwMyQWbwAl1h+DYT1xQlGWJk2f2BXLmQfD6kTyuDes6JPPze F+7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mGqwt1Oz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r3-20020a632b03000000b0041aed10e11dsi925658pgr.351.2022.07.24.03.07.32; Sun, 24 Jul 2022 03:07:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mGqwt1Oz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230516AbiGXKAr (ORCPT + 99 others); Sun, 24 Jul 2022 06:00:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbiGXKAo (ORCPT ); Sun, 24 Jul 2022 06:00:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4834111834 for ; Sun, 24 Jul 2022 03:00:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01E3FB80D5B for ; Sun, 24 Jul 2022 10:00:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5F93C3411E; Sun, 24 Jul 2022 10:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658656839; bh=A4FHc+P9y/UxGoatQYWWeSdTQMu+VX8oS36oBmrynAo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mGqwt1OzRK2G0vTIgC026+s1UGmIMTpZtc++EhtzGRx5FUPu9VvBJ4xDxeiRiiSJN j+umsZvRUBYCHTIqaGqnkgVuYT2p/hLDhTIP3FQIwewSDXC+mZzfH9k2w5CFkpcIhh 1xOyqBpOF14wtB4hGlcfWGJKWXZquHYWE9KsKzzNGv375W5p+d9C/CtO48YmGA34+y 0AHA2HzBX9TLGOFKqoiWrBTs1QstMJBnihEx1rFoDojOzfVOjExZEJ0nQ+6Pe94XFu q/7/RPBARxrhD64DrLdv2gwpAcXxOzBMHEhPnGavegGndXLl6r/VB4EfZFpat6U3lm w1B/BPPKW/vJg== Message-ID: Date: Sun, 24 Jul 2022 18:00:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] f2fs: don't bother wait_ms by foreground gc Content-Language: en-US To: Jaegeuk Kim , qixiaoyu1 Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qixiaoyu1 References: <20220718032840.9653-1-qixiaoyu1@xiaomi.com> From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/22 10:40, Jaegeuk Kim wrote: > On 07/18, qixiaoyu1 wrote: >> f2fs_gc returns -EINVAL via f2fs_balance_fs when there is enough free >> secs after write checkpoint, but with gc_merge enabled, it will cause >> the sleep time of gc thread to be set to no_gc_sleep_time even if there >> are many dirty segments can be selected. >> >> Signed-off-by: qixiaoyu1 > > I applied without {} to match the coding style. Reviewed-by: Chao Yu Thanks,