Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp1999176imi; Sun, 24 Jul 2022 04:04:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t/VBDsAYEGaEg3BFYm8HvOeJMk5MgKVooW0Lj4VZUD8V7jFHS4joN3hlZRhW7lFq1WDcuo X-Received: by 2002:a17:907:2e01:b0:72b:740c:154a with SMTP id ig1-20020a1709072e0100b0072b740c154amr5857159ejc.576.1658660669257; Sun, 24 Jul 2022 04:04:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658660669; cv=none; d=google.com; s=arc-20160816; b=wQ+366OSIuJlEF0ufPwP8Y1Er1dyix8v0F4+qIZSZ8EeLW9b7BVz7McAFQr2goQAvZ QKjOM6ygpl9WjcNudO5f+6byX8Uc4FYoRmCXJIOkl7JSYg2rd9B4G5QlJC7Akcy+8lAA ckfWYQwknlDptzJ6DN0gSdPn3I3nNi3VEg6yXJ1YOdp60tJvUuONRmxwIHa4TPATEaBT CQ0ScKOEsS9Zm/tPc0AEzPiFxiokxmtGkZc3i8YEKkY7XPcFF/R6iuCXxMlj2uzOvana uVd0fXQTDtl6GAk2iMKS2Tyl3jtcwJLXBd+s27ImvKkQeBiXXiz90e2eBzStPT8sTPNH WFIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=jRTxHY+3oumoRJBcTtxrjwhVP8T6AjbX7SwAwTUS/fA=; b=UZaKtYn6VR31u1IIPq5M6Ri/9Km1e6zojqTgZc8rR2cnwqzO7vZRZtmscvxQfF1Mef F377W3VvIewA6ObeNOcvgPdRWTLqTU52PfrS+BUi1lo0DukQaU/6UtnhoqPSyQtmsENi YA7d2vD9T8Y3ZexL5crvj5lig9EcBdDKlNuVqWZnYtGfaUvKlnFDkEPSJ4DYhRdWW8Z3 5LCePGglOqzXwORWPXBdGoiwhH6OXHd/MO/wax8fpyxEX+ncw+eMBAV3wx6n6aaZ+6Pd POCY1TxOMJuphyFkBcA6FnQk6FofDlEfHunxC7ROI/UCCzgHPhEjcAR2kWzcDzivT09X SWhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@skogtun.org header.s=ds202112 header.b=RAeVT921; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=skogtun.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js16-20020a17090797d000b0072afb8071d1si12312339ejc.633.2022.07.24.04.03.56; Sun, 24 Jul 2022 04:04:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@skogtun.org header.s=ds202112 header.b=RAeVT921; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=skogtun.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229903AbiGXKwb (ORCPT + 99 others); Sun, 24 Jul 2022 06:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbiGXKwa (ORCPT ); Sun, 24 Jul 2022 06:52:30 -0400 X-Greylist: delayed 239 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 24 Jul 2022 03:52:25 PDT Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2F771277B; Sun, 24 Jul 2022 03:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=skogtun.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jRTxHY+3oumoRJBcTtxrjwhVP8T6AjbX7SwAwTUS/fA=; b=RAeVT921F6Z7MgUnX8ri9bFlen nKKKEw+ELvqJNehseL1TPLtgYGnmhsUW9hiOs13UShey1bh4j+OpCBN4aWUn0GjIpwdDyw99DMOaI gft7KaCHxIVs1jCLIhGyt4e7yOR2IGukayenZ2tYatJc2OrbeZwih32dchcw5uKTmr0PaNxQgzPBM gYAMsFrz6PGR2Swhxdf9Y6YpBnVKfKitH8w+RW/xszLjlNf0ddPbozWqS0JkvukyGIMrzIATf6Xgc N3WEguyl/dkv0rVAt5CjRZI6QdS2RKP1kWFN+vmmjlhAqkLJ8pSn8+w3XKXjct4m1JeFAd7GcbuYT jCdYrnGQ==; Received: from 236.51-175-223.customer.lyse.net ([51.175.223.236]:60626 helo=[192.168.1.162]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFZ9r-0001wF-Jr; Sun, 24 Jul 2022 12:48:23 +0200 Message-ID: Date: Sun, 24 Jul 2022 12:48:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] hfsplus: Fix code typo Content-Language: en-US To: Matthew Wilcox , Xin Gao Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220722195133.18730-1-gaoxin@cdjrlc.com> From: Harald Arnesen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox [22/07/2022 23.32]: > On Sat, Jul 23, 2022 at 03:51:33AM +0800, Xin Gao wrote: >> The double `free' is duplicated in line 498, remove one. > > This is wrong. The intended meaning here is "trying to free bnode > which is already free". Please don't send patches for code you don't > understand. Perhaps inserting an "a" in the message would make it clearer? (pr_crit("trying to free a free bnode ") -- Hilsen Harald