Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 24 Jul 2022 20:39:15 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Vinod Koul <vkoul@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] i2c: qcom-geni: Use the correct return value
Message-ID: <Yt2R00PlnBfFAnCw@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Vinod Koul <vkoul@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220717035027.2135106-1-bjorn.andersson@linaro.org>
 <20220717035027.2135106-2-bjorn.andersson@linaro.org>
 <YtzSzKmakEWe1usg@shikoro>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="I4L52DYYukU+Xfe+"
Content-Disposition: inline
In-Reply-To: <YtzSzKmakEWe1usg@shikoro>
Precedence: bulk


--I4L52DYYukU+Xfe+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 24, 2022 at 07:04:12AM +0200, Wolfram Sang wrote:
>=20
> > -	return num;
> > +	return ret;
>=20
> Not quite. Kdoc describes the retval in i2c_transfer.

Reconsidered and applied to for-next, thanks!

> I agree this needs better documentation in i2c.h, I will fix it.

I'll still do this :)


--I4L52DYYukU+Xfe+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmLdkdMACgkQFA3kzBSg
KbYh/Q//T/TttTio2xMVq5C3Bnkcm81bwP+rXmfR+VgIEzC3fwiPwxn1nh+lbVdA
Yxd3ffaOuK11TCZtqHczsYp4tcJgGtJAuDfeBwrWqRc5spN6WxIZFnId/CQkl6j3
x2S2Ii2L24uTQl+0Uy3GYlPTt1Zrmnl3GlfPHzHRme29xoCZchxnUgp9DaEcNq73
rtWFPEkFQ0c3lr0bsV+JZs5Qya24U79Pxc2du7/u+qWZUhZKkogEaHtncAVQ8n++
KPoQ2UO9pmLKrcSzFHvtx+GbQMxlp1s4ljTPAYN3X5hVRFHmbV7MzRn4M+LLE8+B
Rn/Bon/QgoQkre2/AGb3SKmwRyCAZiyWr5ZiJvBPT6hHjNk1Dathdmj1DGb/67AY
Zvy7Qj5UPME8jByrHcYGk4qK9fbqSQPyj7097u2wchbbQe8bX8HJOGCA6scCTaX3
PDWUlwcz1B+qwYQJVc0FWb9opew40R1xDBRSQ7MWD4eglskmDJUgCKa96jkvRKdv
rw+OklxYFJEk0Y9Pq/4ukb8L05aZf/0h7hfX3mCQUZO7O04k15jgojAat2GNehl0
jwnF0lnQ6fjb8A182swFr6kO5T6KoFj8Nt2i+RKJJfQonivQ9MBkLcWH3SEbR4pJ
pZ1QqhR39dqzpuQn1MfdM63PLHjfl4jmWvmqh0uAoVN4SejMlck=
=Vudh
-----END PGP SIGNATURE-----

--I4L52DYYukU+Xfe+--