Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e2a56ac3-057c-2b17-7bde-7e860a86807d@linexp.org>
Date:   Sun, 24 Jul 2022 23:11:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v1 17/33] thermal/drivers/rcar: Switch to new of API
Content-Language: en-US
To:     =?UTF-8?Q?Niklas_S=c3=b6derlund?= <niklas.soderlund@ragnatech.se>
Cc:     daniel.lezcano@linaro.org, rafael@kernel.org, rui.zhang@intel.com,
        khilman@baylibre.com, abailon@baylibre.com, amitk@kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        "open list:RENESAS R-CAR THERMAL DRIVERS" 
        <linux-renesas-soc@vger.kernel.org>
References: <20220710212423.681301-1-daniel.lezcano@linexp.org>
 <20220710212423.681301-18-daniel.lezcano@linexp.org>
 <YtZ1IExNlsYaJkC9@oden.dyn.berto.se>
 <18ade2d0-ebda-0526-71f3-65a0b2685068@linexp.org>
 <Yt2W5UCXaB3Memzg@oden.dyn.berto.se>
From:   Daniel Lezcano <daniel.lezcano@linexp.org>
In-Reply-To: <Yt2W5UCXaB3Memzg@oden.dyn.berto.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi Niklas,

I give another try but failed to reproduce the issue. Perhaps my board 
has a path different from yours.

Thanks for proposing to test the series. I've uploaded the branch here:

https://github.com/dlezcano/linux-thermal


On 24/07/2022 21:00, Niklas Söderlund wrote:
> Hi Daniel,
>
> On 2022-07-24 20:27:54 +0200, Daniel Lezcano wrote:
>> Hi Niklas,
>>
>> I tried to reproduce the issue but without success.
>>
>> What sensor are you using ?
> I was using rcar_gen3_thermal.
>
> I did my tests starting on v5.19-rc7 and then picked '[PATCH v5 00/12]
> thermal OF rework' from [1] and finally applied this full series on-top
> of that. If you have a branch or some specific test you wish me to try
> I'm happy to so.
>
> 1. https://lore.kernel.org/lkml/20220710123512.1714714-1-daniel.lezcano@linexp.org/
>
>>
>> On 19/07/2022 11:10, Niklas Söderlund wrote:
>>> Hi Daniel,
>>>
>>> Thanks for your work.
>>>
>>> On 2022-07-10 23:24:07 +0200, Daniel Lezcano wrote:
>>>> The thermal OF code has a new API allowing to migrate the OF
>>>> initialization to a simpler approach.
>>>>
>>>> Use this new API.
>>> I tested this together with the series it depends on and while
>>> temperature monitoring seems to work fine it breaks the emul_temp
>>> interface (/sys/class/thermal/thermal_zone2/emul_temp).
>>>
>>> Before this change I can write a temperature to this file and have it
>>> trigger actions, in my test-case changing the cooling state, which I
>>> observe in /sys/class/thermal/cooling_device0/cur_state.
>>>
>>> Likewise before this change I could trip the critical trip-point that
>>> would power off the board using the emul_temp interface, this too no
>>> longer works,
>>>
>>>       echo 120000 > /sys/class/thermal/thermal_zone2/emul_temp
>>>
>>> Is this an intention change of the new API?
>>
>>
>>