Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 00:54:02 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Arun Ramadoss <arun.ramadoss@microchip.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Russell King <linux@armlinux.org.uk>
Subject: Re: [Patch net-next v2 0/9] net: dsa: microchip: add support for
 phylink mac config and link up
Message-ID: <20220724215402.24426hipwgxlctly@skbuf>
References: <20220724092823.24567-1-arun.ramadoss@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220724092823.24567-1-arun.ramadoss@microchip.com>
Precedence: bulk

On Sun, Jul 24, 2022 at 02:58:14PM +0530, Arun Ramadoss wrote:
> This patch series add support common phylink mac config and link up for the ksz
> series switches. At present, ksz8795 and ksz9477 doesn't implement the phylink
> mac config and link up. It configures the mac interface in the port setup hook.
> ksz8830 series switch does not mac link configuration. For lan937x switches, in
> the part support patch series has support only for MII and RMII configuration.
> Some group of switches have some register address and bit fields common and
> others are different. So, this patch aims to have common phylink implementation
> which configures the register based on the chip id.

I don't see something problematic with this patch set.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

> 
> Changes in v2
> - combined the modification of duplex, tx_pause and rx_pause into single
>   function.
> 
> Changes in v1
> - Squash the reading rgmii value from dt to patch which apply the rgmii value
> - Created the new function ksz_port_set_xmii_speed
> - Seperated the namespace values for xmii_ctrl_0 and xmii_ctrl_1 register
> - Applied the rgmii delay value based on the rx/tx-internal-delay-ps
> 
> Arun Ramadoss (9):
>   net: dsa: microchip: add common gigabit set and get function
>   net: dsa: microchip: add common ksz port xmii speed selection function
>   net: dsa: microchip: add common duplex and flow control function
>   net: dsa: microchip: add support for common phylink mac link up
>   net: dsa: microchip: lan937x: add support for configuing xMII register
>   net: dsa: microchip: apply rgmii tx and rx delay in phylink mac config
>   net: dsa: microchip: ksz9477: use common xmii function
>   net: dsa: microchip: ksz8795: use common xmii function
>   net: dsa: microchip: add support for phylink mac config
> 
>  drivers/net/dsa/microchip/ksz8795.c      |  40 ---
>  drivers/net/dsa/microchip/ksz8795_reg.h  |   8 -
>  drivers/net/dsa/microchip/ksz9477.c      | 183 +------------
>  drivers/net/dsa/microchip/ksz9477_reg.h  |  24 --
>  drivers/net/dsa/microchip/ksz_common.c   | 312 ++++++++++++++++++++++-
>  drivers/net/dsa/microchip/ksz_common.h   |  54 ++++
>  drivers/net/dsa/microchip/lan937x.h      |   8 +-
>  drivers/net/dsa/microchip/lan937x_main.c | 125 +++------
>  drivers/net/dsa/microchip/lan937x_reg.h  |  32 ++-
>  9 files changed, 431 insertions(+), 355 deletions(-)
> 
> 
> base-commit: 502c6f8cedcce7889ccdefeb88ce36b39acd522f
> -- 
> 2.36.1
>