Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 24 Jul 2022 19:19:31 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Jianlin Lv <iecedge@gmail.com>
Cc:     mingo@redhat.com, jianlv@ebay.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/kprobe: Add tracefs to show private kprobe
Message-ID: <20220724191931.60c671e2@rorschach.local.home>
In-Reply-To: <20220724091050.12711-1-iecedge@gmail.com>
References: <20220724091050.12711-1-iecedge@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 24 Jul 2022 09:10:50 +0000
Jianlin Lv <iecedge@gmail.com> wrote:

> List private kprobe event to new created local_event_list;
> Add tracefs file kprobe_local_profile to show events which
> in local_event_list.

This states what you are doing, but not why you are doing it.

The subject of a commit should be the what, and the body should explain
the why.

And the subject is confusing because you are not "adding tracefs", it
should state:

   tracing/kprobes: Add method to display private kprobes in tracefs

Or something like that.

-- Steve