Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220625224037.836581-1-masahiroy@kernel.org> <20220725014100.GQ25951@gate.crashing.org>
In-Reply-To: <20220725014100.GQ25951@gate.crashing.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Mon, 25 Jul 2022 10:58:10 +0900
Message-ID: <CAK7LNATFT3YFz-VUu1PQWNNfCL6k4EFokxcMGq3guJo9MhmydQ@mail.gmail.com>
Subject: Re: [PATCH] powerpc/purgatory: Omit use of bin2c
To:     Segher Boessenkool <segher@kernel.crashing.org>
Cc:     Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 25, 2022 at 10:42 AM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> On Sun, Jun 26, 2022 at 07:40:37AM +0900, Masahiro Yamada wrote:
> > The .incbin assembler directive is much faster than bin2c + $(CC).
>
> And perhaps more importantly it is simpler and less clumsy.
>
> > --- /dev/null
> > +++ b/arch/powerpc/purgatory/kexec-purgatory.S
> > @@ -0,0 +1,14 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +
> > +     .section .rodata, "a"
> > +
> > +     .align  8
> > +kexec_purgatory:
> > +     .globl  kexec_purgatory
> > +     .incbin "arch/powerpc/purgatory/purgatory.ro"
> > +.Lkexec_purgatroy_end:
>
> Typo here (s/ro/or/)


Nice catch. Thanks.

I've sent v2.


>
> > +
> > +     .align  8
> > +kexec_purgatory_size:
> > +     .globl  kexec_purgatory_size
> > +     .quad   .Lkexec_purgatroy_end - kexec_purgatory
>
> And here again ofc.
>
> Looks good to me otherwise, nice cleanup :-)
>
> Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
>
>
> Segher


-- 
Best Regards
Masahiro Yamada