Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 09:51:20 +0200
From:   Alain Volmat <alain.volmat@foss.st.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     <alexandre.torgue@foss.st.com>, <robh+dt@kernel.org>,
        <mcoquelin.stm32@gmail.com>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <amelie.delaunay@foss.st.com>
Subject: Re: [PATCH 1/2] ARM: dts: stm32: add spi nodes into stm32mp131.dtsi
Message-ID: <20220725075120.GA429410@gnbcxd0016.gnb.st.com>
Mail-Followup-To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        alexandre.torgue@foss.st.com, robh+dt@kernel.org,
        mcoquelin.stm32@gmail.com, krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        amelie.delaunay@foss.st.com
References: <20220721153455.3805586-1-alain.volmat@foss.st.com>
 <20220721153455.3805586-2-alain.volmat@foss.st.com>
 <c7e13adb-8584-6e24-11f3-9a27c7122da4@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c7e13adb-8584-6e24-11f3-9a27c7122da4@linaro.org>
Precedence: bulk

Hi Krzysztof,

thanks for the review. Will push a v2 fixing those points.

Alain

On Thu, Jul 21, 2022 at 06:32:18PM +0200, Krzysztof Kozlowski wrote:
> On 21/07/2022 17:34, Alain Volmat wrote:
> > Add the 5 instances of spi busses supported by the stm32mp131.
> > 
> > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> > ---
> >  arch/arm/boot/dts/stm32mp131.dtsi | 70 +++++++++++++++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
> > index da9e8a6ca663..db3d1b900d5c 100644
> > --- a/arch/arm/boot/dts/stm32mp131.dtsi
> > +++ b/arch/arm/boot/dts/stm32mp131.dtsi
> > @@ -97,6 +97,34 @@ scmi_shm: scmi-sram@0 {
> >  			};
> >  		};
> >  
> > +		spi2: spi@4000b000 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			compatible = "st,stm32h7-spi";
> > +			reg = <0x4000b000 0x400>;
> 
> Unusual order... rather first compatible then reg.
> 
> Best regards,
> Krzysztof