Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Baolu Lu <baolu.lu@linux.intel.com>
CC:     Jason Gunthorpe <jgg@nvidia.com>, Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        "Zhu, Tony" <tony.zhu@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v10 08/12] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Thread-Topic: [PATCH v10 08/12] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Thread-Index: AQHYkC3RawHjE5fI4kOPQdVz+DQ3s62MICIAgAGHjYCAAStGgIAAA18A
Date:   Mon, 25 Jul 2022 08:02:05 +0000
Message-ID: <BN9PR11MB52769B02DE62A229CCB4F2E38C959@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-9-baolu.lu@linux.intel.com>
 <20220723142650.GH79279@nvidia.com>
 <bffb6e2d-d310-49b9-0725-37ab4263c22d@linux.intel.com>
 <Yt5IqyZw/Sa6Ck5t@myrica>
In-Reply-To: <Yt5IqyZw/Sa6Ck5t@myrica>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JAKwgVzxLnJ8QpQUglfIdldn/RkFteYGcS+ttMrhcH/oEEZitEa2QiExz+Tr?=
 =?us-ascii?Q?yUKzmKD4hTTyo83SrOp9eyalQKK3/3mCv7GHnHGlpRp8A1/HlLbwy8Q/eXAN?=
 =?us-ascii?Q?XZF3K1QrQgK8Sd+aX2ySNqQaIqk8aQSsLSHsHxc9UQhjabwuCKt8Yi2ml902?=
 =?us-ascii?Q?YFi/UZ6NG8paKNLgZI6brubJhkpCpyojuLfWNq6YLSCOsnOM89S8oY6Ap3yL?=
 =?us-ascii?Q?ziu7TEGXuB6UQiGOoGAOCb9F9LmCyLfAhvQCUhopjyb+8YD09bW1SSLuml/H?=
 =?us-ascii?Q?WbG5b41rjmADJavYadvR3tpsqZ6TNdmlwN6RyHRb1avpV+2OK2l+GH3eM7cz?=
 =?us-ascii?Q?Cg9h1+3bY8jxKrQ+86yP1Ow5o55sS6WBU+bwCp7RaCzprhSR1epEi/B1j22J?=
 =?us-ascii?Q?7GP7vnjS1H+jYL7C457sBXnW9cTebhnxS79tLeFYXzkRMzwSretBzdMe2xsQ?=
 =?us-ascii?Q?aC4eH7Gy7Cx2zKdiD2yue8SzirTtuDuGHP5NfoICppOKSiuokpnNYe8mGhLS?=
 =?us-ascii?Q?rsPqB7cYoChMq4qO30Apq/J2Q3f4WUnkJaF4c+Pjvcah8CZFtxS/fye3c1pE?=
 =?us-ascii?Q?F+YFnMFk20DyKwHsufCXo/DZm9BSf7Dn5lsxLzLgsOzjcsKKeYX8WOk2woIk?=
 =?us-ascii?Q?hWFESRkQ7BzOgzueCHGVslAq6kOTi1pGNl9feQyLAwqT4Zl3R2mub2uWnrdo?=
 =?us-ascii?Q?Lg2F5Si8qT4Au4bsgHaQPhGfGNOOYWyKqxXGKuOBh7W3XWM/wxRBChWTVcEB?=
 =?us-ascii?Q?OZLZ1Iq5ajqRmjwYT9JiSGzmPGZTEQNsgrU46DEK30YQpG51h9ObFwgFHGf3?=
 =?us-ascii?Q?D7ZHRblZoZb6Vw6uhuVJPFUE5phH4PVAAtEGXiEO6v/gOEvR9OERBFOvAKSn?=
 =?us-ascii?Q?scidDJc60e8h83rnYNkH6rrNu2O1oTeWlLTEinAyYqpaJ24GUVjWQiS/JEIX?=
 =?us-ascii?Q?uwOTIRYQAIp0UMXXFRDQaoKeH3XcAp5U9xl5ej/YiB0xq6aLD0iJ4/e9Y+ME?=
 =?us-ascii?Q?ERvQqiLxFCy1CrGTS8n6gfuD+K+dXy7pn3JYnMt0r5pvfPuGi1EIFi8eCTvu?=
 =?us-ascii?Q?R/uwJVnFY4SWJJhzcCCpClXKvPVx+8+kkTr29+wk/QK49LE7SYEitJt2VEbY?=
 =?us-ascii?Q?bJ0MX5S9BURdrSzEMW2WwgmufK7fG19o0HFoiUGUbB3cUB7NXVpjybbzbEFW?=
 =?us-ascii?Q?kJKogmEbzcyH8tzUOXlTQs9bPhgZmcDSeP6E6mM6RWnj419GQCTVPx8tM3iY?=
 =?us-ascii?Q?WQVSekN5nw0AKKVBA7PfISgCzTnc1GTaSbCfr/agzdNZs4Qnf6+CbZ6WWH3l?=
 =?us-ascii?Q?ntsc33khEFt9vs5fkcjck5XSu8RMDd6TJqtsbB4PMVLZTVnXctFhtdwZpaOL?=
 =?us-ascii?Q?ClFnjA6ilb8as8jIU+9wxk0brvJha/YX8F8INlfWEe+MJOu4vSLCFyftwAX7?=
 =?us-ascii?Q?ncbLhZDrRsjdWQI8r7OTM4MC77LmC3trXIdKLw4e9c/IbND2tutm9WB3Wbzk?=
 =?us-ascii?Q?xZKNVCdLrfQJQ7Cnqm8Fq1zXf48UZwnSQk2wb+bDmTvFex49usGB8qnINtXS?=
 =?us-ascii?Q?szUOEf4+/8uS9XtSN4FNtSCydolnA7tveVa7a+Tn?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e49ff08f-1bad-4771-334b-08da6e13f719
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 08:02:05.4779
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: V0I6FGpjsnGBG9/NoCWEPMtJ3GZjmTEIaQGa+fmVqdQL1zLr8dI6QFX9wmbgo4M1RpeSPw9g9/ZqsRC64qzfsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3194
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Sent: Monday, July 25, 2022 3:39 PM
>=20
> On Sun, Jul 24, 2022 at 09:48:15PM +0800, Baolu Lu wrote:
> > /*
> >  * iommu_detach_device_pasid() - Detach the domain from pasid of device
> >  * @domain: the iommu domain.
> >  * @dev: the attached device.
> >  * @pasid: the pasid of the device.
> >  *
> >  * The @domain must have been attached to @pasid of the @dev with
> >  * iommu_detach_device_pasid().
> >  */
> > void iommu_detach_device_pasid(struct iommu_domain *domain, struct
> device
> > *dev,
> > 			       ioasid_t pasid)
> > {
> > 	struct iommu_group *group =3D iommu_group_get(dev);
> > 	struct group_pasid *param;
> >
> > 	mutex_lock(&group->mutex);
> > 	domain->ops->set_dev_pasid(group->blocking_domain, dev, pasid);
>=20
> Please also pass the old domain to this detach() function, so that the
> IOMMU driver doesn't have to keep track of them internally.

The old domain is already tracked in group->pasid_xarray and can
be retrieved using [dev, pasid].

>=20
> In addition to clearing contexts, detach() also needs to invalidate TLBs,
> and for that the SMMU driver needs to know the old ASID (!=3D PASID) that
> was used by the context descriptor.
>=20

Presumably both ASID and context descriptor are SMMU internal
knowledge. What exact information is required from the core API
and how is it done today?