Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 11:42:26 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Aashish Sharma <shraash@google.com>,
        "Daniel J. Ogorchock" <djogorchock@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the hid tree
In-Reply-To: <20220725104035.15c2e506@canb.auug.org.au>
Message-ID: <nycvar.YFH.7.76.2207251142040.19850@cbobk.fhfr.pm>
References: <20220725104035.15c2e506@canb.auug.org.au>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 25 Jul 2022, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/hid/hid-nintendo.c:1514:29: error: redefinition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT'
>  1514 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/hid-nintendo.c:295:29: note: previous definition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT' with type 'short unsigned int'
>   295 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   669abca7b767 ("HID: nintendo: Fix unused-const-variable compiler warning")
> 
> interacting with commit
> 
>   92cdfba40155 ("HID: nintendo: fix unused const warning")
> 
> I have used the hid tree from next-20220722 for today.

My fault, I forgot that this was actually already fixed before by Daniel.

Dropped for now from for-next. Thanks,

-- 
Jiri Kosina
SUSE Labs