Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Xu, Terrence" <terrence.xu@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "hca@linux.ibm.com" <hca@linux.ibm.com>,
        "gor@linux.ibm.com" <gor@linux.ibm.com>,
        "agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
        "borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
        "svens@linux.ibm.com" <svens@linux.ibm.com>,
        "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
        "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        "tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "farman@linux.ibm.com" <farman@linux.ibm.com>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "pasic@linux.ibm.com" <pasic@linux.ibm.com>,
        "vneethv@linux.ibm.com" <vneethv@linux.ibm.com>,
        "oberpar@linux.ibm.com" <oberpar@linux.ibm.com>,
        "freude@linux.ibm.com" <freude@linux.ibm.com>,
        "akrowiak@linux.ibm.com" <akrowiak@linux.ibm.com>,
        "jjherne@linux.ibm.com" <jjherne@linux.ibm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "hch@infradead.org" <hch@infradead.org>
CC:     "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "jchrist@linux.ibm.com" <jchrist@linux.ibm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>
Subject: RE: [PATCH v4 00/10] cover-letter: Update vfio_pin/unpin_pages API
Thread-Topic: [PATCH v4 00/10] cover-letter: Update vfio_pin/unpin_pages API
Thread-Index: AQHYnjiH4GVWQdYkokqjavOdPoRut62O4eUA
Date:   Mon, 25 Jul 2022 10:20:42 +0000
Message-ID: <SA1PR11MB5873AA479883576C9B591D3BF0959@SA1PR11MB5873.namprd11.prod.outlook.com>
References: <20220723020256.30081-1-nicolinc@nvidia.com>
In-Reply-To: <20220723020256.30081-1-nicolinc@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J1eENoZkDTrIdHgsSHSq89pOxZVfrzW7mgCnHIMPEjeAh/lXbHye6tvOq538?=
 =?us-ascii?Q?h7WKeQIYtfGwY+vlE/L9QBmCE8zhvRT9btXzLQPoB1S+1oVxWy6iuRz6hKH3?=
 =?us-ascii?Q?wVBWy3YzAYZXiZb5myYCLz57VABp3Wawj9eaO17Sqq51R+UqAHup4fseXE28?=
 =?us-ascii?Q?/fU1iHGBbFK2lPn4GS9vuztO7mzR+WRT2TMRvV7lU7gJ5oYcDATVzxbkwWbH?=
 =?us-ascii?Q?FIHfDSXddcXZnQV5omxkV5+oL7XkAgInSQBWXxrJZelcpH9GfEL0bV3C+aSD?=
 =?us-ascii?Q?/PRbiRrhmodxD/kT+AfK0H9Et3h6l/podLspwQF0zX1IL8wf3RdLejZ1qa92?=
 =?us-ascii?Q?61gY+zPqtr6D4WUYpxliLsTZ0c7G7VPH+fZPrq7fZSDFJFf4aFbhjerXqwK6?=
 =?us-ascii?Q?MNj9r1PbVsm/Tydmo9kmRQCqtOwLpKlnB8jHqImPHI0zSNN01JlZBKcHGRs+?=
 =?us-ascii?Q?kVP31sR+ARp7/U+fvmeXnsCFTe4QlqwnRQrTJ7vhfWplLm10MeH8ysSITd2T?=
 =?us-ascii?Q?8VhV55ApummrsRfIc/Xo8tikKtBPeDi/jtdGRVvWWiDEfZab9iJaGmLktkH1?=
 =?us-ascii?Q?IVO/p72GOO2q8x2uVpTHbPRLOe44CgnHlCGPBQMHq0+9/WW3BxEfJDthsfH+?=
 =?us-ascii?Q?54nrzYnbV9afml1Vx/2AaLbIPv+w5mH+r69WsyZCzZMsy7u3CbFQPuV0tCWB?=
 =?us-ascii?Q?RX1zKzn4Pb/+csjcxMd3puKUX0eDZQh0dYIv8BqxDLMNV+XGn+85nMKOupav?=
 =?us-ascii?Q?SsyYS6JxB1+wuuPnJ0Pv/olH+6+IIW9ejFJR/YG7ShlqENPYQ4zUM4RErlwz?=
 =?us-ascii?Q?c4r0ob/3PRGYTfF9AvjAHodTTcwZR/c15YcoIuWToYy4GCs8MbJmLhoCFIE5?=
 =?us-ascii?Q?erGxcZhhGjIB6TavfBpFgPD4ewjY5ItXVWVAvJd3f8qfR+Q5OXrHejjzSdhM?=
 =?us-ascii?Q?Ebo0HEaMIw1W7tv2nh8gbffXYSzbjpEHP69ninv/tS+1v3Ju/wP0WRxeM3yW?=
 =?us-ascii?Q?l5t61fHIjnFCCPm4NebXCoC1UaVXN/tWeAD6kKyhYW0V2hZ+LAkxu2ClsVkF?=
 =?us-ascii?Q?Zp+EdaERKduFyZEpv+4qv+qS3a9buJpBnSV3ik6Bb+HJ6cJoRVHHmnwnYnBS?=
 =?us-ascii?Q?mPjnKJ66NWPE0xUhMYjfDB16xptOvh/c9sd1/4uk58vQMQjjITlTRbmN2XG4?=
 =?us-ascii?Q?gntAD/SPFMOeDGC+cXc2UeHnxPs42+vkmnB2AjcOPNyWtXP37B6RTc12krf6?=
 =?us-ascii?Q?bjlv8sT7Lug2qu6neaea1liFL3t2APOV/10GjiYaUAS4cVEuZjIK0Ch+cJWE?=
 =?us-ascii?Q?QQULkDKyr6M+XSO6AXg++vai0zr/eeXGwMV86v247wY5hTFzNnvoUKfLe0fL?=
 =?us-ascii?Q?8mnz/HDd6wQLgd99tq5pGvzBvveBM09ZmfIoLtowWsZtAiaDlvOiKp6BM+G7?=
 =?us-ascii?Q?BK0osd8jPC1uJwGsIh3PXCa+KO4kXcWlHQ6ySAgGWw3dRT3SI1HypXTQG/3U?=
 =?us-ascii?Q?BBmCnyaON7lkSNCV7UmOVPEYkbefv+lEJ+eCnYE+GGiDJDe6erEEo81EMWdW?=
 =?us-ascii?Q?YRlJ0NjuOounqw+z4Ebsq86p/cIXakFY9PF+UrcK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5873.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0e87462-6edf-48da-538c-08da6e27545f
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 10:20:42.4503
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IOM92nn9ZDgQnvgaB7qf8rc+XZmmuzr2slRkkiLSlROjK5V7cf3zC2KgbS4JoeCaq6I224LDk8TbiR/dfbbTrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3465
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: intel-gvt-dev <intel-gvt-dev-bounces@lists.freedesktop.org> On
> Behalf Of Nicolin Chen
>=20
> This is a preparatory series for IOMMUFD v2 patches. It prepares for
> replacing vfio_iommu_type1 implementations of vfio_pin/unpin_pages()
> with IOMMUFD version.
>=20
> There's a gap between these two versions: the vfio_iommu_type1 version
> inputs a non-contiguous PFN list and outputs another PFN list for the
> pinned physical page list, while the IOMMUFD version only supports a
> contiguous address input by accepting the starting IO virtual address of =
a
> set of pages to pin and by outputting to a physical page list.
>=20
> The nature of existing callers mostly aligns with the IOMMUFD version,
> except s390's vfio_ccw_cp code where some additional change is needed
> along with this series. Overall, updating to "iova" and "phys_page"
> does improve the caller side to some extent.
>=20
> Also fix a misuse of physical address and virtual address in the s390's c=
rypto
> code. And update the input naming at the adjacent vfio_dma_rw().
>=20
> This is on github:
> https://github.com/nicolinc/iommufd/commits/vfio_pin_pages-v4
>=20
> Terrence has tested this series on i915; Eric has tested on s390.
>=20
> Thanks!
>=20
> Changelog
> v4:
>  * Dropped double-shifting at two gvt_unpin_guest_page calls, fixing
>    a bug that's discovered by Alex
>  * Added Reviewed-by from Anthony Krowiak
>  * Rebased on top of linux-vfio's next
> v3: https://lore.kernel.org/kvm/20220708224427.1245-1-
> nicolinc@nvidia.com/
>  * Added a patch to replace roundup with DIV_ROUND_UP in i915 gvt
>  * Dropped the "driver->ops->unpin_pages" and NULL checks in PATCH-1
>  * Changed to use WARN_ON and separate into lines in PATCH-1
>  * Replaced "guest" words with "user" and fix typo in PATCH-5
>  * Updated commit log of PATCH-1, PATCH-6, and PATCH-10
>  * Added Reviewed/Acked-by from Christoph, Jason, Kirti, Kevin and Eric
>  * Added Tested-by from Terrence (i915) and Eric (s390)
> v2: https://lore.kernel.org/kvm/20220706062759.24946-1-
> nicolinc@nvidia.com/
>  * Added a patch to make vfio_unpin_pages return void
>  * Added two patches to remove PFN list from two s390 callers
>  * Renamed "phys_page" parameter to "pages" for vfio_pin_pages
>  * Updated commit log of kmap_local_page() patch
>  * Added Harald's "Reviewed-by" to pa_ind patch
>  * Rebased on top of Alex's extern removal path
> v1: https://lore.kernel.org/kvm/20220616235212.15185-1-
> nicolinc@nvidia.com/
>=20
> Nicolin Chen (10):
>   vfio: Make vfio_unpin_pages() return void
>   drm/i915/gvt: Replace roundup with DIV_ROUND_UP
>   vfio/ap: Pass in physical address of ind to ap_aqic()
>   vfio/ccw: Only pass in contiguous pages
>   vfio: Pass in starting IOVA to vfio_pin/unpin_pages API
>   vfio/ap: Change saved_pfn to saved_iova
>   vfio/ccw: Change pa_pfn list to pa_iova list
>   vfio: Rename user_iova of vfio_dma_rw()
>   vfio/ccw: Add kmap_local_page() for memcpy
>   vfio: Replace phys_pfn with pages for vfio_pin_pages()
>=20
>  .../driver-api/vfio-mediated-device.rst       |   6 +-
>  arch/s390/include/asm/ap.h                    |   6 +-
>  drivers/gpu/drm/i915/gvt/kvmgt.c              |  45 ++--
>  drivers/s390/cio/vfio_ccw_cp.c                | 195 +++++++++++-------
>  drivers/s390/crypto/ap_queue.c                |   2 +-
>  drivers/s390/crypto/vfio_ap_ops.c             |  54 +++--
>  drivers/s390/crypto/vfio_ap_private.h         |   4 +-
>  drivers/vfio/vfio.c                           |  54 ++---
>  drivers/vfio/vfio.h                           |   8 +-
>  drivers/vfio/vfio_iommu_type1.c               |  45 ++--
>  include/linux/vfio.h                          |   9 +-
>  11 files changed, 213 insertions(+), 215 deletions(-)

Verified the Intel KVMGT feature, no regression be introduced by v4 patch s=
eries, the previous Call Trace issue already gone.
Tested-by: Terrence Xu <terrence.xu@intel.com>
> --
> 2.17.1