Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f914f5c5-dd61-8495-b362-3043406582da@linaro.org>
Date:   Mon, 25 Jul 2022 14:55:06 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: WARNING: CPU: 4 PID: 326 at drivers/opp/core.c:2471
 dev_pm_opp_set_config+0x344/0x620
Content-Language: en-US
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mansur Alisha Shaik <mansur@codeaurora.org>
Cc:     open list <linux-kernel@vger.kernel.org>,
        Linux-Next Mailing List <linux-next@vger.kernel.org>,
        regressions@lists.linux.dev, Linux PM <linux-pm@vger.kernel.org>,
        lkft-triage@lists.linaro.org, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>
References: <CA+G9fYuGFReF0Z9qj7-80eY0gz-J2C5MVpno_8NjrGSH5_RB0Q@mail.gmail.com>
 <20220725102711.p6eerjjzgeqi4blu@vireshk-i7>
From:   Stanimir Varbanov <stanimir.varbanov@linaro.org>
In-Reply-To: <20220725102711.p6eerjjzgeqi4blu@vireshk-i7>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Viresh,

I can take a look and provide a patch to fix that.

But, is this a new warn or it is a consequence of new changes in
opp/core.c ?

On 7/25/22 13:27, Viresh Kumar wrote:
> On 22-07-22, 11:01, Naresh Kamboju wrote:
>> I have found this warning on db845c while booting Linux next-20220720.
>> Please find more details in the below link,
>>
>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>
>> [    9.769688] WARNING: CPU: 4 PID: 326 at drivers/opp/core.c:2471
>> dev_pm_opp_set_config+0x344/0x620
>> [    9.769698] i2c 16-0010: Fixing up cyclic dependency with acb3000.camss
>> [    9.810991] msm-mdss ae00000.mdss: Adding to iommu group 15
>> [    9.811082] Modules linked in: hci_uart qcom_camss msm(+) videobuf2_dma_sg
>> [    9.823435] ath10k_snoc 18800000.wifi: supply vdd-3.3-ch1 not
>> found, using dummy regulator
>> [    9.827664]  ath10k_snoc(+) btqca v4l2_fwnode btbcm ath10k_core
>> venus_core(+) gpu_sched camcc_sdm845 reset_qcom_pdc v4l2_async
>> v4l2_mem2mem i2c_qcom_geni videobuf2_memops ath drm_dp_aux_bus
>> drm_display_helper videobuf2_v4l2 bluetooth mac80211 i2c_qcom_cci
>> videobuf2_common qcom_rng spi_geni_qcom gpi(+) qcom_q6v5_mss xhci_pci
>> qrtr xhci_pci_renesas cfg80211 rfkill slim_qcom_ngd_ctrl lmh
>> icc_osm_l3 pdr_interface slimbus qcom_wdt display_connector icc_bwmon
>> qcom_q6v5_pas qcom_pil_info qcom_q6v5 qcom_sysmon drm_kms_helper
>> qcom_common qcom_glink_smem qmi_helpers mdt_loader drm socinfo
>> rmtfs_mem fuse
>> [    9.885445] qcom-camss acb3000.camss: Adding to iommu group 16
>> [    9.911179] platform ae94000.dsi: Fixing up cyclic dependency with
>> ae01000.display-controller
>> [[0;32m  OK  [0m] Started D-Bus System Message Bus.[    9.911593]
>> Bluetooth: hci0: setting up wcn399x
>> [    9.928261] CPU: 4 PID: 326 Comm: systemd-udevd Not tainted
>> 5.19.0-rc7-next-20220720 #1
>>
>> [    9.928265] Hardware name: Thundercomm Dragonboard 845c (DT)
>> [    9.928267] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
>> [    9.928269] pc : dev_pm_opp_set_config+0x344/0x620
>> [    9.977763] lr : dev_pm_opp_set_config+0x68/0x620
>> [    9.982508] sp : ffff8000089337b0
>> [    9.985846] x29: ffff8000089337b0 x28: ffff800008933c90 x27: ffff3e2780f9bc10
>> [    9.993030] x26: ffffb9048f76dd40 x25: ffffb904d98c8de8 x24: ffff3e278da60080
>> [   10.000226] x23: ffff3e2780f9bc10 x22: ffff8000089338b0 x21: ffff3e278eda0d80
>> [   10.007416] x20: ffff3e2780f9bc10 x19: ffff3e2786ffe000 x18: ffffffffffffffff
>> [   10.014602] x17: 0000000000000000 x16: ffffb904d7d90f50 x15: 6f63713d305f454c
>> [   10.021795] x14: ffffb904d9df6a20 x13: 0000000000000040 x12: 0000000000000228
>> [   10.028981] x11: 0000000000000000 x10: 0000000000000bd0 x9 : ffffb904d7d905e0
>> [   10.036166] x8 : ffff3e27833a8c30 x7 : 0000000000000018 x6 : 0000000000000001
>> [   10.043361] x5 : ffffb904d982f000 x4 : ffff3e27833a8000 x3 : ffffb904d9bf2c20
>> [   10.043365] x2 : 0000000000000000 x1 : ffff3e2786f70d00 x0 : ffff3e2786ffe060
>> [   10.043368] Call trace:
>> [   10.043369]  dev_pm_opp_set_config+0x344/0x620
>> [   10.043373]  devm_pm_opp_set_config+0x24/0x80
>> [   10.043376]  core_get_v4+0x244/0x360 [venus_core]
>> [   10.043393]  venus_probe+0x100/0x470 [venus_core]
>> [   10.043404]  platform_probe+0x74/0xf0
> 
> Stanimir / Bjorn,
> 
> The OPP core expects all configuration options to be provided before the OPP
> table is added. i.e. (for your case here), we need to call
> devm_pm_opp_set_clkname() and devm_pm_opp_attach_genpd(), before calling
> devm_pm_opp_of_add_table(). This is a hard requirement, it was a hard
> requirement earlier (before the new changes in OPP core came in) too, just that
> devm_pm_opp_attach_genpd() was missing the necessary WARN(), which was there in
> every other helper.
> 
> Can someone from Qcom team reorder things a bit provide a patch to fix this
> WARN() ? I will carry that in my tree then.
> 
> It may look like this, I don't want to touch code that I don't understand at
> all:
> 
> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
> index cb48c5ff3dee..c93d2906e4c7 100644
> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> @@ -875,7 +875,7 @@ static int vcodec_domains_get(struct venus_core *core)
>         }
> 
>  skip_pmdomains:
> -       if (!core->has_opp_table)
> +       if (!core->res->opp_pmdomain)
>                 return 0;
> 
>         /* Attach the power domain for setting performance state */
> @@ -1007,6 +1007,10 @@ static int core_get_v4(struct venus_core *core)
>         if (ret)
>                 return ret;
> 
> +       ret = vcodec_domains_get(core);
> +       if (ret)
> +               return ret;
> +
>         if (core->res->opp_pmdomain) {
>                 ret = devm_pm_opp_of_add_table(dev);
>                 if (!ret) {
> @@ -1017,10 +1021,6 @@ static int core_get_v4(struct venus_core *core)
>                 }
>         }
> 
> -       ret = vcodec_domains_get(core);
> -       if (ret)
> -               return ret;
> -
>         return 0;
>  }
> 

-- 
regards,
Stan