Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 13:02:35 +0100
From:   Mark Brown <broonie@kernel.org>
To:     "Prasad, Prasad" <venkataprasad.potturu@amd.com>
Cc:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "Reddy, V sujith kumar" <Vsujithkumar.Reddy@amd.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
        "Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@amd.com>,
        "Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
        "Saba Kareem, Syed" <Syed.SabaKareem@amd.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
Message-ID: <Yt6GW/29wJ9081rh@sirena.org.uk>
References: <20220722141705.3340440-1-venkataprasad.potturu@amd.com>
 <Ytq5rlr/er0wDTae@sirena.org.uk>
 <PH7PR12MB595106BC93458F31B2D8C5A9E9959@PH7PR12MB5951.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="PIF0Y6NPkJF5WZtF"
Content-Disposition: inline
In-Reply-To: <PH7PR12MB595106BC93458F31B2D8C5A9E9959@PH7PR12MB5951.namprd12.prod.outlook.com>
Precedence: bulk


--PIF0Y6NPkJF5WZtF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote:

> This looks like it's just an indentation/formatting change which isn't
>=20
> what the changelog said?

> We are changing dai_id macro numbers, as renoir platform has 2 I2S instan=
ces and Rembrandt platform has 3 I2S instances.
>=20
> To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INST=
ANCE to 0x01 and I2S_BT_INSTANCE to 0x02.
> I2S_HS_INSTANCE is already 0x03.

Please write a better changelog which makes this clear.

Please fix your e-mail client to clearly distinguish between quoted and
non-quoted text, it's very hard to find your new text in your mail.

--PIF0Y6NPkJF5WZtF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLehlsACgkQJNaLcl1U
h9CgKwf/fMKV9x3binr3akdQUf2tCBjy5NssqkTHNgnFmlRZR16apmsVym3vFcBm
alf/DJPe6ulDvdyWpaE0pFRby0SMno2QcMAtVBFGqQND6RJj6DIpgCZNkn1ArAH0
oAK9+7qnpyDEvtBjW5DP1T64t1ODNThOtPqtvRGmNDXZsJzhFq+/Xf/YMd4bsQCK
Dah7YpjggjmlNcYMV6aFJcrUIOArSRtEtkUb1aeoFPGSFV2FhHiNp7/KXLSCha6F
kOfTQgoGKrsJ8y0DSMY2j6y49GMK6k8A9H5i7f4lvYIxGpbRspvxjiC+Ch0YF17L
wA3NhWAIDUvz/EwTQLJUeqbnY2X9Uw==
=Q0Fq
-----END PGP SIGNATURE-----

--PIF0Y6NPkJF5WZtF--