Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 15:15:19 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc:     michael.chan@broadcom.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jgg@ziepe.ca,
        selvin.xavier@broadcom.com, linux-rdma@vger.kernel.org,
        andrew.gospodarek@broadcom.com
Subject: Re: [PATCH 2/2] RDMA/bnxt_re: Use auxiliary driver interface
Message-ID: <Yt6JV0Vs7nSnI8KB@unreal>
References: <20220724231458.93830-1-ajit.khaparde@broadcom.com>
 <20220724231458.93830-3-ajit.khaparde@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220724231458.93830-3-ajit.khaparde@broadcom.com>
Precedence: bulk

On Sun, Jul 24, 2022 at 04:14:58PM -0700, Ajit Khaparde wrote:
> Use auxiliary driver interface for driver load, unload ROCE driver.
> The driver does not need to register the interface using the netdev
> notifier anymore. Removed the bnxt_re_dev_list which is not needed.
> Currently probe, remove and shutdown ops have been implemented for
> the auxiliary device.
> 
> BUG: DCSG01157556
> Change-Id: Ice54f076c1c4fc26d4ee7e77a5dcd1ca21cf4cd0

Please remove the lines above.

> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/bnxt_re.h       |   9 +-
>  drivers/infiniband/hw/bnxt_re/main.c          | 405 +++++++-----------
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  64 ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |  65 +++
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h |   3 +
>  5 files changed, 232 insertions(+), 314 deletions(-)

<...>

> +static DEFINE_IDA(bnxt_aux_dev_ids);
> +
>  static int bnxt_register_dev(struct bnxt_en_dev *edev, unsigned int ulp_id,
>  			     struct bnxt_ulp_ops *ulp_ops, void *handle)

I would expect that almost all code in bnxt_ulp.c will go after this change.

Thanks