Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp2708565imi; Mon, 25 Jul 2022 06:20:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vHoclEkX7KVif+12sV3Pbs8O9mIjyyUtH1aQenecnzazRktTMzh+UM+cKQaFrBgVJuHxMy X-Received: by 2002:a05:6870:d58f:b0:10c:68ff:ad87 with SMTP id u15-20020a056870d58f00b0010c68ffad87mr6284789oao.146.1658755231039; Mon, 25 Jul 2022 06:20:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658755231; cv=none; d=google.com; s=arc-20160816; b=XeD6T3fKugHUuEYBY/W9H6FEXesuDaceMW/eDixS049fzKnYKBaQ9rQHWv791g9jGj ejpmgSRH/J/mbxKWFvrH7/ZtmogAnyhoeyAxVi3rlyWrSPgYwgwKdTgYHApw25xMFzzl +5IOltUCrvsAnAvX9tlN1LbXNeyV9cM01KS+Su0jwz5feVbMdnHGvY6bk4vBE1TvIoj+ CqMjGZnjCuzT7L0J0iRboE54sHULI6jLsR//4LOf8KYt+18W2CMu7uCoPXDYax8PR8mZ 8sZAkmm97Efr0S5mcSWPSYUHMYtPpN5dIXayALg7PCHQjLEZ/L3WS9aigsM+hQO4iw0L 2G0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:date:cc :subject:to:from:dkim-signature:dkim-signature; bh=KX1pX+qxhjtmIbz/mv+FEb+97nfiqNjUtPVXNgyC9+k=; b=Z1JupfLyL2B4Y+hIkRk9p2J+xqDxOweb3zgFwPB0v/uCpH5NgZZn+prxtsmUNrNGT1 ybA30GlaMxwDPvlDCC4BqKzUUcYNV9tPcb+nIjdXfbmvtaWI+SV0QS93AbGvJCIstt7l TOou6c9JJBeFRtQM14BlKhLYd4gna864db7RTrROtwFIsLQl1ey3Iefh1izBl+1HOksV g75eJ3Ud7uyY5tgc8yGUmLUAQIfJwz4MZdwFnDa5dDk0mPasiUcI+0y810ptf4osvqjF K3Uq74vP6lyku8wB5O2WihO6ZXbadFsjr2i4MYpQzngIZhptgq2EFxSw843GPx3go8w9 TiGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rUKxaZX0; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p41-20020a05687056a900b0010cb19696dbsi10090347oao.308.2022.07.25.06.20.15; Mon, 25 Jul 2022 06:20:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rUKxaZX0; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234616AbiGYNKg (ORCPT + 99 others); Mon, 25 Jul 2022 09:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232380AbiGYNKf (ORCPT ); Mon, 25 Jul 2022 09:10:35 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4919665E4; Mon, 25 Jul 2022 06:10:28 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D98B11FADC; Mon, 25 Jul 2022 13:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1658754626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KX1pX+qxhjtmIbz/mv+FEb+97nfiqNjUtPVXNgyC9+k=; b=rUKxaZX0CHPTS50VFaCO+mGOMhsdNEtgp1vg5BxHKnKW2AOa+lz9H2pdCywO1hbdmx6a12 RXcx0svD2XQLxceow51BjMeBWKi+WsEe7m4J14Omy/LBa3f6UCgztWlY7Wd0zsrhg3DYKt spMKmHdGfEXrJoj06P+/vb6fleLOEaw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1658754626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KX1pX+qxhjtmIbz/mv+FEb+97nfiqNjUtPVXNgyC9+k=; b=8kOgZbPTQT3vpyhm8I40dvouQa6bVFortCiKzh6Qdk7sYywtd8pQZXxpDgniuZklq2fxu/ Qypc2YvD108uEVCw== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id D24E82C152; Mon, 25 Jul 2022 13:10:26 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id 56840444B2F; Mon, 25 Jul 2022 15:10:26 +0200 (CEST) From: Andreas Schwab To: Daniel Bristot de Oliveira Subject: [PATCH] rtla: fix double free CC: Steven Rostedt , linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org X-Yow: Should I do my BOBBIE VINTON medley? Date: Mon, 25 Jul 2022 15:10:26 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't call trace_instance_destroy in trace_instance_init when it fails, this is done by the caller. Signed-off-by: Andreas Schwab --- tools/tracing/rtla/src/trace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/tracing/rtla/src/trace.c b/tools/tracing/rtla/src/trace.c index 5784c9f9e570..7c27fc2a52cb 100644 --- a/tools/tracing/rtla/src/trace.c +++ b/tools/tracing/rtla/src/trace.c @@ -179,7 +179,6 @@ int trace_instance_init(struct trace_instance *trace, char *tool_name) return 0; out_err: - trace_instance_destroy(trace); return 1; } -- 2.37.1 -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."