Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 15:52:02 +0300
From:   Vadym Kochan <vadym.kochan@plvision.eu>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     broonie@kernel.org, enachman@marvell.com,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        lnoam@marvell.com
Subject: Re: [PATCH 4/7] spi: a3700: support BE for AC5 SPI driver
Message-ID: <20220725125202.GA5304@plvision.eu>
References: <20220723102237.10281-1-vadym.kochan@plvision.eu>
 <53b307a3-67e0-2acd-5d4a-0970f717afa7@wanadoo.fr>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <53b307a3-67e0-2acd-5d4a-0970f717afa7@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?yOQJflnkg2sKB2Iniv7t4NiE5DvKvh8HGLTgdaMNm81x3jgLRh6IaILAgK?=
 =?iso-8859-1?Q?6nJNOpeQA7TUghin0HwqXOcyVDwCEackk+ZDyV4JBEW3LZTNRRVq7Ytpus?=
 =?iso-8859-1?Q?WQ9SVZddCJJbEqL1eYLNnmfNDeZ4Xs8CUV0emuUcpqOARYkoC1lP7o5Nsn?=
 =?iso-8859-1?Q?PsJEjT2tq/lBVIRdc8Sfu3TMdKUuQfTGYc6DPfo6hTS4ECuHqwfyaEIqx9?=
 =?iso-8859-1?Q?g/h5TdgGxpw8F36s1IsqSKWYqiLH/4yeBmBFKbe7g34HobdBSopBbHCrQS?=
 =?iso-8859-1?Q?F8jrSe7m8cyBjv7ddtv2/yjuZuuHjVRV6fyDG90JH2OXpOEN9svBbgJtPW?=
 =?iso-8859-1?Q?BvU73/b/22IaPt7QKjP7wPGeJvq3MDUksAsGFDsw48cpCNCIXe0Bm9Mzfz?=
 =?iso-8859-1?Q?IvxbynxE2f6jf1tRAn9a3GeWYXDTji+I4ucTjLvhhp0W1GEl2GmzlAhpoF?=
 =?iso-8859-1?Q?ld5yqZgGDtSW/F3U/reCwDeo6/iMq9+kva2tIdBtwRWK9SAoRvd7lvI3t1?=
 =?iso-8859-1?Q?0ESrtvUzuJayCQRotcmjqWX/uzBl/cBp+szhtnsBPEiCWv0op03O+iLcUy?=
 =?iso-8859-1?Q?Gs9C8m9RSpHXbMidH+blmqv3W0BDMQmyTrq4sMnX4MSe+4ZmDV2H3fXTa6?=
 =?iso-8859-1?Q?9mTngIgiUM/aQSa0qSJbUvxitnnxLCkhpo4PjwWm0vbE3RP3N3O5GehJMJ?=
 =?iso-8859-1?Q?zLBNhpAmJYvDFmDBEguTpVtykKd4JQFSllQUetj8kADB3S7PfOz/aLLS2I?=
 =?iso-8859-1?Q?NOtwUjB9Q/QRLm8dFj522ZOym4y1GBHWQyptOnvVygKeIFfdj099qIcF8X?=
 =?iso-8859-1?Q?T68Q6o6LFWU+tKRXZx3v359U4IzLqPUS3dyo50rfYI49EiM9dch6u70K+E?=
 =?iso-8859-1?Q?S47+Te9SIvFUG2lNQvQXSlAmZNQjvNf2wRRBPl7vJ9qgDXx6+gyLsdWnwe?=
 =?iso-8859-1?Q?cCOUdvuNCd3lrWVhQ72mvNh+BNIAqhV4j/bvsEBcoUe9iuAzqcGvWZIE/G?=
 =?iso-8859-1?Q?eNOLIhMcXo4iAMryqSdKEu4eyWLv/7rs/HnApDUF5lw+3eA/KQ0rjsCFbh?=
 =?iso-8859-1?Q?fjNn57Iu3Ln+wfR83E5nRU92jcqmD6+a63AUvFLmnut/0BfohoJ3nx4RZu?=
 =?iso-8859-1?Q?n2R8i/F/MpF/WctNSRlC2BtzFgE3/hEy0vc35ZujXgga797bK/HX5dYK1w?=
 =?iso-8859-1?Q?bja5hAyPjvi+39UQ0X1XwXZjuJ2eebizFISU54ME+lEBKNnkL/I/k4J/87?=
 =?iso-8859-1?Q?KefjqCnUO3D+++e0ed2xYhSaXY5kYsvnJmz8BdZsYpXgG/7NJ0wsYGHCFe?=
 =?iso-8859-1?Q?DneSi5F22LLxEjL2VEiYhSSsuFEn2s8wgoHLjujoO/G/ME5JDFM94Htpty?=
 =?iso-8859-1?Q?/8QcyW9uTnqyG9edV6I/j4xDf8cXD/eK1FnDlytL+cLRSGw/3S+AFqxHVY?=
 =?iso-8859-1?Q?4Nmf0CDm+m+fsbD1s8oo980l8achQYZM0AVJXB4zTdsZuVn5vt5+oQABWP?=
 =?iso-8859-1?Q?i1TbwNxi4MPennIObJkcWFgDylv1PWiIbY+ChT/YsE4ZqmDMfTEkbicp96?=
 =?iso-8859-1?Q?Jtm3A+1JZw8jZDdmRvYh0oWdSEAReTF+9r2xvdi2hhmKByAAEeVnvmKe5K?=
 =?iso-8859-1?Q?NJ0R5D1DAxZTwC8IYVK+SSK/ZxhQdsjLY9K9wnj4L3mMYShvJduWVSrw?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 43f5fe9d-b46d-4409-536b-08da6e3c7ad7
X-MS-Exchange-CrossTenant-AuthSource: VI1P190MB0317.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 12:52:06.6558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z/3cu0OXJ8z9FRViiU7NcWb3jeB1NNLrCDWe6L5Snc4Su1AGcKrYLySWzykpTuE2E0wzbPhtfY1tAkGqc+hiYr+TG0z4bagwFlSddcaJNdM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P190MB1931
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Christophe,

On Sat, Jul 23, 2022 at 12:49:55PM +0200, Christophe JAILLET wrote:
> Le 23/07/2022 ? 12:22, Vadym Kochan a ?crit?:
> > From: Noam <lnoam-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> > 
> > Tested-by: Raz Adashi <raza-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> > Reviewed-by: Raz Adashi <raza-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Vadym Kochan <vadym.kochan-Nq3fbkz6jlnsq35pWSNszA@public.gmane.org>
> > ---
> >   drivers/spi/spi-armada-3700.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
> > index d8cc4b270644..386c7959ea93 100644
> > --- a/drivers/spi/spi-armada-3700.c
> > +++ b/drivers/spi/spi-armada-3700.c
> > @@ -497,7 +497,7 @@ static int a3700_spi_fifo_write(struct a3700_spi *a3700_spi)
> >   	while (!a3700_is_wfifo_full(a3700_spi) && a3700_spi->buf_len) {
> >   		val = *(u32 *)a3700_spi->tx_buf;
> > -		spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val);
> > +		spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, cpu_to_le32(val));
> >   		a3700_spi->buf_len -= 4;
> >   		a3700_spi->tx_buf += 4;
> >   	}
> > @@ -519,7 +519,7 @@ static int a3700_spi_fifo_read(struct a3700_spi *a3700_spi)
> >   	while (!a3700_is_rfifo_empty(a3700_spi) && a3700_spi->buf_len) {
> >   		val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG);
> >   		if (a3700_spi->buf_len >= 4) {
> > -
> > +			val = cpu_to_le32(val);
> 
> Hi,
> 
> even if both should generate the same code, should'nt this be le32_to_cpu()?
> 
> CJ
> 
> >   			memcpy(a3700_spi->rx_buf, &val, 4);
> >   			a3700_spi->buf_len -= 4;
> 

Thank you!