Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 11:49:18 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Baolu Lu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org,
        Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v10 10/12] iommu: Prepare IOMMU domain for IOPF
Message-ID: <20220725144918.GH3747@nvidia.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-11-baolu.lu@linux.intel.com>
 <20220723143334.GJ79279@nvidia.com>
 <487b533a-b289-eee7-0bd8-3be36c6e00e3@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <487b533a-b289-eee7-0bd8-3be36c6e00e3@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wcyq8zVJie4OP14hLoz8PYRuheyBymFTSIhNLtK+toeykqBmDMRuqMmmP6Wf?=
 =?us-ascii?Q?PcBGnKwxKKxhd/Jp1W31Xm/C5Js2nnxDOnsO/G/pivg/NUjDFxS4GnA3dfB+?=
 =?us-ascii?Q?ESlAQ6V2Fi3ga1jB/8iO7jF+7x3ewqNlslDDkeceHqzIV1xpd5Psmfub0xei?=
 =?us-ascii?Q?MQ8EpZ+nTfsTdcyAxE727FfqVzFrgAApmtUqjieL8K2AwdKXyUlgiCele7eD?=
 =?us-ascii?Q?lP/QbJaaEvcz2ciiaLru7nd/E2ygvrn8QWKoQqMUwpraU69Wpjajj/GwJCdc?=
 =?us-ascii?Q?TjKVNNiDCWbV6EzkZ9H9kuQybluHGUVghiA+4ELQzEfa8uFJjTe1NXqnac+N?=
 =?us-ascii?Q?zxtuBAS3Ysc4WYV1d1ufpTskk2UGCq7HIGLFEBc4f1VYM27Pj99mRP9Y8uUE?=
 =?us-ascii?Q?zN4E9mzV3N6lqTAsFh7b7RfAOPr09Fz8O9rEHk88tz64go/hyiVFbf2ifpao?=
 =?us-ascii?Q?cDaJbRn177uLpR1E+oIabCSnWyzjk9AWHYDQiujx51cW8Aw3bszDc6Nym0kb?=
 =?us-ascii?Q?T98h1fVkh2qvNK/6Y6szQ3llTrqf2H0kMuSAwdiHXnRANQCGJD83QLPdHMeO?=
 =?us-ascii?Q?jQuQhYMAz+AFz/w19DEPt0vpd8DJjrnzZJZvDGa+ZkjlszKcBW4XABShJCu4?=
 =?us-ascii?Q?zNnKUecLG2+nclNBbiRnobu9/ibvQZwDQfx3x9bH80mwiYibqYGysY7oi/5+?=
 =?us-ascii?Q?IVdYtfPeOmSwoFuQq2UwAUiEMIIi/i2Gi3yG6jpwNpoSd1PVMID5F8GDfUfV?=
 =?us-ascii?Q?WttVNmKL/FqgkGbyhwlB6pih9XdkEszF8OE4qzihOvm4uLR+R35hbNRn53bX?=
 =?us-ascii?Q?wqItNPBJKow7h5mLvhScTo4Eb7M9X+cIXRa4ynHS1l4WAinOBFR+oOjsaYC4?=
 =?us-ascii?Q?b6vNZlTS6rfB8TuJfdtaZ3LtPRJ1Inpb9deVVLdAdi3o2maXJ1Nn5VKi/hO2?=
 =?us-ascii?Q?/4rReX12HK9yCLCGbmfotjuML5QEoWuxHNoMrZtEQJ8ypnL8pm/o0dWfuo3n?=
 =?us-ascii?Q?FFFR0rdAtHoUJyVAa0vrLTMjlZzYRD+Wr23gaRPfejkXudzpDXzttLg8KFM6?=
 =?us-ascii?Q?/G8tbyiahZMnq1HKwhyzTAkAVRVuE2Mbryy/GaxgQxkziwXfHHZKIk/xrZz4?=
 =?us-ascii?Q?DWYWLAr13iruPbRt0K9OMeSrCzCfx4urMK23TXfSoT4Mr55V/bD4a0KokmkH?=
 =?us-ascii?Q?787RSvzjfj9SUtbPQPpPbKnUjxa3S90c6KLhIN0r/6rq7eeqVm3bsRPb5Iiz?=
 =?us-ascii?Q?yokDlAXi3A320E5PhXIjLDDw7Wdbpkft7FFzW58sAMn5ukYq7ULbWMFLFMJK?=
 =?us-ascii?Q?wfQY2x5IrkuMFWxyUx5uz5FXGhOiME2ExmqdF99yQ3GL/otMAnNn1jNm6fg+?=
 =?us-ascii?Q?IiHhkbOLwn/aCZoGYgz7JWBrJLwO/A1w/pGY/MoCNWFIWFCToGIRelu8A0IF?=
 =?us-ascii?Q?CykSs2qiWX9dUNCFjKn5QZvD2ey8jpEFtz5t5qQ6Mp2cT+4LhvTTY4iyBXQo?=
 =?us-ascii?Q?8Ny7J0Nn40Xtd+37NOhWPbwrgBcNkcp7b+nBRygGBQucvuS0585kFO2o8gwM?=
 =?us-ascii?Q?m3P9AEOlQxVsl0uP+uo=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f972783-3f4e-43de-d1b2-08da6e4cdbc2
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 14:49:21.1612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lhyFL6zmWLIzuVU5t1M4PvawBcLNRNSqABtBABmg7UaokExZMFS2ix3dM7ydFAaf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6955
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 24, 2022 at 10:04:50PM +0800, Baolu Lu wrote:
> > Why do we need two falut callbacks? The only difference is that one is
> > recoverable and the other is not, right?
> > 
> > Can we run both down the same op?
> 
> The iommu_fault_handler_t is for report_iommu_fault() which could be
> replaced with the newer iommu_report_device_fault().
> 
> https://lore.kernel.org/linux-iommu/Yo4Nw9QyllT1RZbd@myrica/

Okay, sounds like a good future project, maybe add a fixme comment or
something so others understand.

Jason