Received: by 2002:a05:6830:16d2:b0:61c:ac69:ca1b with SMTP id l18csp2124308otr; Mon, 25 Jul 2022 07:56:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sOlcaVh/0NS5JHLH/6HMlOiJE/TbG13QdrZVXAeJx+6tpvWONLK9blL2EO52u5jes9jNxY X-Received: by 2002:aa7:c382:0:b0:43b:bbaa:31fb with SMTP id k2-20020aa7c382000000b0043bbbaa31fbmr13915507edq.269.1658760976251; Mon, 25 Jul 2022 07:56:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658760976; cv=none; d=google.com; s=arc-20160816; b=r3sQatAOpDZqdNx0V/X9nf/6JoKYcb23U0KG0QfzTRYmqGtrSbGrRSDzU/GHU5YKJQ KtUS55Y0RcQjEELBtmXt4aFFM+J4aEENuPM+c8A1wq+tqkJjsbrrISngRAwGcaAQPdUb pnsvlwsb7VlUa5z6TSJFNoECrCIfORnmaNqasAjHb8WkFjaHL8ksjuPxjMb56qD04hwV 2SU8CGWAaWVcvrtIPvCoKvGpZNb413+0/8tK3REWEO+jVERNE4ExVPuQaw42GTV/nUnd 8/Hoe4XJE6h6EPO7ZK/ud7qJFjJdZKz3507ybfYH+L+w7Dhaj4MM4Ll6BZ22/UMhG3qz PcOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=RcMpDk4sHjrTBJD1O8H4hTTiTB5UlktNrNudfoiy7gQ=; b=ITVKDt11YAgSDE9iHzJLfcQiAnw/F8NTJTeTJLtOojH+s2yHuXSWa8KVod3h5oV1nC kyZaMM91+Z33xTLB5N9IeG/SXhFdT0Et1RRWlYJ1hk84ItzSIXgozVco784i16Wq5tFX cyXWRj2Lj/3UozknLlad0RoGE2XCsiABBuYv5itkbepJb06GNzBHYcgioZG0dS2oEtOK faMn8cY/BRjKAH4Eqpd9SgEN0dNAiFVLkLAdkbGAuz1C5LkB8FJ8zhpcM96hI8aA5FdM 4ciCmlcaF4zHeCb7pGI9xbHYnAg9Kv7QwcCZfmYcItJlun6RUjyhoz9+66yPY3iRJpJd 9ZOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020a1709067c1200b0072eece129b1si11035056ejo.753.2022.07.25.07.55.51; Mon, 25 Jul 2022 07:56:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235753AbiGYOwl (ORCPT + 99 others); Mon, 25 Jul 2022 10:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234031AbiGYOwi (ORCPT ); Mon, 25 Jul 2022 10:52:38 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7956D1839E for ; Mon, 25 Jul 2022 07:52:35 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D4852D6E; Mon, 25 Jul 2022 07:52:35 -0700 (PDT) Received: from e121896.arm.com (unknown [10.57.41.239]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 054D73F73D; Mon, 25 Jul 2022 07:52:33 -0700 (PDT) From: James Clark To: suzuki.poulose@arm.com, coresight@lists.linaro.org Cc: mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org, James Clark Subject: [PATCH v1 1/4] coresight: Remove unused function parameter Date: Mon, 25 Jul 2022 15:52:18 +0100 Message-Id: <20220725145221.517776-2-james.clark@arm.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20220725145221.517776-1-james.clark@arm.com> References: <20220725145221.517776-1-james.clark@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ability to use a custom function in this sysfs show function isn't used so remove it. No functional changes. Signed-off-by: James Clark --- drivers/hwtracing/coresight/coresight-priv.h | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h index ff1dd2092ac5..f2458b794ef3 100644 --- a/drivers/hwtracing/coresight/coresight-priv.h +++ b/drivers/hwtracing/coresight/coresight-priv.h @@ -40,31 +40,23 @@ #define ETM_MODE_EXCL_KERN BIT(30) #define ETM_MODE_EXCL_USER BIT(31) -typedef u32 (*coresight_read_fn)(const struct device *, u32 offset); -#define __coresight_simple_func(type, func, name, lo_off, hi_off) \ +#define __coresight_simple_show(type, name, lo_off, hi_off) \ static ssize_t name##_show(struct device *_dev, \ struct device_attribute *attr, char *buf) \ { \ type *drvdata = dev_get_drvdata(_dev->parent); \ - coresight_read_fn fn = func; \ u64 val; \ pm_runtime_get_sync(_dev->parent); \ - if (fn) \ - val = (u64)fn(_dev->parent, lo_off); \ - else \ - val = coresight_read_reg_pair(drvdata->base, \ - lo_off, hi_off); \ + val = coresight_read_reg_pair(drvdata->base, lo_off, hi_off); \ pm_runtime_put_sync(_dev->parent); \ return scnprintf(buf, PAGE_SIZE, "0x%llx\n", val); \ } \ static DEVICE_ATTR_RO(name) -#define coresight_simple_func(type, func, name, offset) \ - __coresight_simple_func(type, func, name, offset, -1) #define coresight_simple_reg32(type, name, offset) \ - __coresight_simple_func(type, NULL, name, offset, -1) + __coresight_simple_show(type, name, offset, -1) #define coresight_simple_reg64(type, name, lo_off, hi_off) \ - __coresight_simple_func(type, NULL, name, lo_off, hi_off) + __coresight_simple_show(type, name, lo_off, hi_off) extern const u32 coresight_barrier_pkt[4]; #define CORESIGHT_BARRIER_PKT_SIZE (sizeof(coresight_barrier_pkt)) -- 2.28.0