Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "claudiu.beznea@microchip.com" <claudiu.beznea@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "ronak.jain@xilinx.com" <ronak.jain@xilinx.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "git@xilinx.com" <git@xilinx.com>, "git (AMD-Xilinx)" <git@amd.com>
Subject: RE: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
 configuration support
Thread-Topic: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
 configuration support
Thread-Index: AQHYnaLjy2AcewErSEyspw5q+NWPga2NwKqAgAFZDXA=
Date:   Mon, 25 Jul 2022 14:34:51 +0000
Message-ID: <MN0PR12MB59537FD82D25E5B6BE17D1B6B7959@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <1658477520-13551-1-git-send-email-radhey.shyam.pandey@amd.com>
 <1658477520-13551-3-git-send-email-radhey.shyam.pandey@amd.com>
 <Yt15J6fO5j9jxFxp@lunn.ch>
In-Reply-To: <Yt15J6fO5j9jxFxp@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eadGt6pSUOPwaLhFCZIR1ZWOtH9ApdWAtS1GkXyjLoFdaicQVLee1ZVIhXjH?=
 =?us-ascii?Q?bhk4XQ4mhMgfyJChi6sI5qcSlsaj0ULwIkh2kTBY/Bi7KZ6bnYtXoqs54ljV?=
 =?us-ascii?Q?9XrRropSB/tCz6XTBO3Y38rMuvxIA+zsTAfuhzi4IvHmvOao7bCRaHjYzyct?=
 =?us-ascii?Q?IHD2wbUuFjHxhIHer7WoknsM/Y/DYvVuEUtHnMO3pIWXN3Zmij4SnmexI5LZ?=
 =?us-ascii?Q?2ZFQuaInkStH+6CWc6QT0jqRwXAw1j2PHiVa0KQmxNMQhmRVtnc80IvUMKNk?=
 =?us-ascii?Q?I/Yfx0WU/vu9eCVV0rTPQ3/0F40pIxAzWKoDineFjkArVOEbMmHr3qgc8bRz?=
 =?us-ascii?Q?iQYHjfkfpwYAXTPozW5IYG1+djnDcX4cna05PzILlfPeDw03Lwq8CP/c8Hw9?=
 =?us-ascii?Q?pPUs9koWI+mlHFenu1a8Wu+GG/ptFrANek1HJtgzFXgYXzU07iGmCeKdomQD?=
 =?us-ascii?Q?XUs0B5GCPLeAAyS4xqMpG1NrbSOsCrf2iSrzVcZoark55gP4RkG/AngWTie4?=
 =?us-ascii?Q?yfX+cPa0och23BpoVDkEagZp4cf3IfOR5N1sXvSWd4GEDkIxBEePBm21YkyI?=
 =?us-ascii?Q?xhUX1D8KCR+kiIXg3KHVLSt6qimBwiY2Pstys2psleNDv0a7uH+6NJ9qYOQT?=
 =?us-ascii?Q?yC9RxQR1mBVZ7DC9x344Okn94oOKPk307rvC1LSsP/LjYmw8JeNMVoKbMeeT?=
 =?us-ascii?Q?g9KQTw75IYFGmt4LqFCh+OWG48tEoFAGbsCRqA36tmo7pD7aujM+VDV3Tv5b?=
 =?us-ascii?Q?ru4JPOZaW2FJGT5Swm3kcRlTvljS3nYqSocqoq1WuQOh8YssQjTOTjs/Upj6?=
 =?us-ascii?Q?AoFKJUHjRhM79x9vQF/2ik8zsyj5fuwgvRZ9IvccYpLusbYFVGwasWuQtEPH?=
 =?us-ascii?Q?526apppQWYLtYmLsn/4fBf/ygagICf6vSe2g3/hcdfh5QncZmoTj7rOKQBmT?=
 =?us-ascii?Q?l26zpdoNElgMG5qUzRa0VlkfoizEKag+aIsDbm1+lNbjpH4X87xpKoXsddqh?=
 =?us-ascii?Q?n+hIYPM7whHG5w2PikqW7ZZGHemmpYi+4rHZQS4jsMXtT5V3EWtIk94GN49+?=
 =?us-ascii?Q?7HHk4JwPaXjs5xGwP+v7LjIGEjEepnQAqiqy+ALZl8268vaRxa51h9fQvhj0?=
 =?us-ascii?Q?c5EbV1sU1KxWNXr1MMGGSdIvNFi0Av3OzH92ehOeRqYmjXUfiLbE9Gy83DHU?=
 =?us-ascii?Q?yg0F+Lhs5vqj4nZWoR6GM+2FoU/5tSsMv6XMxHc0ZDw4Jq8UhVP083tgA0zA?=
 =?us-ascii?Q?tLVtWzaPEkReJDoIaEw8nDDJliA/UTzi97N5DvHKRQh+XaYdUAokvhIQ6n61?=
 =?us-ascii?Q?fT+7LCdeyr7makRAdsqXghg2qT3pKs/1vc8BtwdFgnUJ8Zi1AmvbYeMSOGlm?=
 =?us-ascii?Q?8f1hzaD94zF7xEOvJ/vC+iPLJuRw1HDchHk5zfamvkgRO2yzWttQLaQc1bho?=
 =?us-ascii?Q?p5Qvd48R/ZtlbY6XjeZ+J06IEwc6VrxWC3YPOcbYfeLpOUrQEf6hjgk0W/r3?=
 =?us-ascii?Q?KrdoOk3ZkkM2dicCZWRvHSuLhCvk7SiUSa1lfWUasaHq/G28GLae1HQmHSc3?=
 =?us-ascii?Q?Z0lDsvnw2cPM5AwJpaGUUfHzgoodITXgAnPKAVPwa9u3IXViyULUK8fqA/Bf?=
 =?us-ascii?Q?1rr5iBK8VtyKR1SdVGhFjJk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cbc5803-0018-4874-5cd7-08da6e4ad578
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 14:34:51.3791
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oXv1AOUNCTtNFR7azit/T645EW3xx1aN3fOFWluhq4WDWEoWkfjDhbZ7bD9MfvAc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1566
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Sunday, July 24, 2022 10:24 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Cc: michal.simek@xilinx.com; nicolas.ferre@microchip.com;
> claudiu.beznea@microchip.com; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> gregkh@linuxfoundation.org; ronak.jain@xilinx.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; git@xilinx.com; git (AMD-Xilinx) <git@amd.com>
> Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
> configuration support
>=20
> > +		ret =3D of_property_read_u32_array(pdev->dev.of_node,
> "power-domains",
> > +						 pm_info,
> ARRAY_SIZE(pm_info));
> > +		if (ret < 0) {
> > +			dev_err(&pdev->dev, "Failed to read power
> management information\n");
> > +			return ret;
> > +		}
> > +		ret =3D zynqmp_pm_set_gem_config(pm_info[1],
> GEM_CONFIG_FIXED, 0);
> > +		if (ret < 0)
> > +			return ret;
> > +
>=20
> Documentation/devicetree/bindings/net/cdns,macb.yaml says:
>=20
>   power-domains:
>     maxItems: 1
>=20
> Yet you are using pm_info[1]?

From power-domain description - It's a phandle and PM domain=20
specifier as defined by bindings of the power controller specified
by phandle.

I assume the numbers of cells is specified by "#power-domain-cells":
Power-domain-cell is set to 1 in this case.

arch/arm64/boot/dts/xilinx/zynqmp.dtsi
#power-domain-cells =3D <1>;
power-domains =3D <&zynqmp_firmware PD_ETH_0>;

Please let me know your thoughts.

>=20
>     Andrew