Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 11:46:05 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc:     Baolu Lu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 08/12] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Message-ID: <20220725144605.GF3747@nvidia.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-9-baolu.lu@linux.intel.com>
 <20220723142650.GH79279@nvidia.com>
 <bffb6e2d-d310-49b9-0725-37ab4263c22d@linux.intel.com>
 <Yt5IqyZw/Sa6Ck5t@myrica>
 <7862ed6f-b834-5dc7-8677-31ff52fec76d@linux.intel.com>
 <Yt5n6JCrigzh3cwh@myrica>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yt5n6JCrigzh3cwh@myrica>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8ZHjITP3eRCvuOBQDTdeZoDMx1QnlzS86Mr3ni4WxfF9oeDdUeCLCbjirHnF?=
 =?us-ascii?Q?ckyAesKKCjMPTdrIQeYgG5SbJKFihCq46QuamLYNFXaMHYUQQBlu3Z8C4sPk?=
 =?us-ascii?Q?1+EjT1Jh3FEJVQAZgT626b7CkvVOgtu0DKDM9e7RCWA+xErDP98GeZ/9Uzv8?=
 =?us-ascii?Q?u0viDTzGrCS2SQVkka+MQvOLcleTBn2ZK0wwa10niOsIaAHkxkn78y6ZpDNX?=
 =?us-ascii?Q?qZaGSjS77jkic9YkHifrIHb2pdBnakd3vNdzKdv6W1Uh6OZcNWSPgM8A+MtD?=
 =?us-ascii?Q?6PuetuOQcilyJggkFhJaaxqsUmbREVFFD4THTLFPrQFXYeofbzw6RlkSXnkQ?=
 =?us-ascii?Q?mATcJdff6jcIhNY0vUXGPIsP6NedzsqxHX25daPmKXpXTcWfms6xxpVMqX6Z?=
 =?us-ascii?Q?b/Tn98LDEDjJf3zJpSZAOXf1QCm1uKeWYn/rErTqNagycSMarrGiTjE/sbkf?=
 =?us-ascii?Q?LTLlg4B9MzGosePkzu8BlMRTl8q6S1UYmW/4Uq3+3wzQA1BXt/RE1z8pQF+h?=
 =?us-ascii?Q?qBcUBpzILAzjXYf2UKPgPCQLMMFska7pplwhFYBxWbvZAqtMnilKEO6kOLCK?=
 =?us-ascii?Q?DDHHfs2vHpr//DivJR7XnIRPAyqdUiE+OQVH//pO7pgxEvdwHcsblZYfuLC+?=
 =?us-ascii?Q?sbu6WDnR1ahuBAHUpIe3UfrVumFyETHosQrTOogZQdGXXkCwEMneskVj7OpX?=
 =?us-ascii?Q?76mYqk1A7eXdkltsQj0yk9wl026DW2kZhQAOuvXVwcoh5ywF9BkcpcHwtzzm?=
 =?us-ascii?Q?tkK8Y1U+vZkEpEVWHXLljyTA822d59XUBe5v8Vq4hmJkPMIvyA8MKHOTM64t?=
 =?us-ascii?Q?NWWMG2/I4KDww5yABM+a4AbmU02/MTTH1dVBdfKz8tjShWF+eClPE3GoJ1lr?=
 =?us-ascii?Q?PwsDIGEDDz73MMIS2GAoqEIaZ3JA3/6ZB1UjmeQTFY9wSy1fcPQ/Bs0awKle?=
 =?us-ascii?Q?LakLF7tRn9Ui4tWJDm6P8wHIxNBCVKMiOTCpMYJ8SqVYQBVqbqGFaJbcFu0z?=
 =?us-ascii?Q?+dAD3NGUrr9GsiqpUf9EKpGC0X0Vn0KTuEWYnCeW2GMNtTaGRbgbcy6Fojw/?=
 =?us-ascii?Q?q1gpc7k0fAMJzRzRBLMSoqV0YTGTfWEnYEpNiMQ87nSTAf9RUcAuFPxtnwCH?=
 =?us-ascii?Q?oN7N5Fcy4KhhbK4vAnEjslruLfPTB48zCL45KBXEpyjvVHoXaqe6Jyfgmczy?=
 =?us-ascii?Q?4Aq6OouD8xc3ttIF3odOD7ZQcCWAKRqkssJaenPvjFOy57eBBliNzLndH99R?=
 =?us-ascii?Q?tHhHEuFKbrMsDMBxW88Ecnyw3q6L3ZF0oPECKXwXoYKqvUIRmc+eZdMtVkwv?=
 =?us-ascii?Q?xiwJLSNDe3vX6KN0L+7TmWKdHZPeLCB0bPVsaGFkSYAeoR6QU/JNVy9aXq1m?=
 =?us-ascii?Q?25cRy56FHH8T3jMAdoCvWqX4IuXCmwxBrqlqeMqpcMGqGuQwPQZYe2bT5dB9?=
 =?us-ascii?Q?nxUizuLWWMfKlcNlTyW92ekInbAmJ9IfSSBOL8P/e42KcpUSnJ1nGHzz1tTP?=
 =?us-ascii?Q?u4avuQQOFp/MR0g46FXKsq22VYNFyYuYWrMx7ixl/07an0Uw0JeP2jcCqjLw?=
 =?us-ascii?Q?FdUpqm5XCmAg6VdFDac=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a0ac13b-6800-4010-b737-08da6e4c69b1
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 14:46:09.8995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ffq7XdlABjVDh7ZMAOt9pwgC95dRNue/naDbinJcTgFRQwX/tNyvDX0/gJH9T5XJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6134
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 25, 2022 at 10:52:40AM +0100, Jean-Philippe Brucker wrote:
> > The iommu core provides the interface to retrieve attached domain with a
> > {device, pasid} pair. Therefore in the smmuv3 driver, the set_dev_pasid
> > could do like this:
> 
> Thanks for the example, yes I can do something like this. I maintain that
> attach+detach is clearer, but as long as it can be made to work, fine by
> me

Except it is not clearer, because there isn't actually a detatch in
our model - many things already got messed up in the non-pasid case
because of this confusing assumption.

We have only a "set" operation and set moves between any two domain
configurations.

You don't need to call attach/detach pairs, just repeated attaches,
which is how the normal path works. detach is called in the legacy
flow for the NULL domain

So, creating a pair invites the wrong idea that they actually are a
pair.

> > The check of "(!domain || domain->type == IOMMU_DOMAIN_UNMANAGED)" looks
> > odd, but could get cleaned up after a real blocking domain is added.
> > Then, we can simply check "domain->type == IOMMU_DOMAIN_BLOCKING".

So this is probably a good reason enough not to do it yet, though it
would be nice to get a proper blocking domain concept in the SMMU
driver to support VFIO, it could be done later.

Jason