Received: by 2002:a05:6830:16d2:b0:61c:ac69:ca1b with SMTP id l18csp2150092otr; Mon, 25 Jul 2022 08:29:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uHjR19R89Uk8ldo4/q6xF0jzFnSBARYz9RGmdIiKy4OdANaCXVo2qB0uZkMAjxjXReU8Go X-Received: by 2002:aa7:d683:0:b0:43b:94f0:794 with SMTP id d3-20020aa7d683000000b0043b94f00794mr14080987edr.54.1658762990354; Mon, 25 Jul 2022 08:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658762990; cv=none; d=google.com; s=arc-20160816; b=ESm0tTlJDvDiU4B6DzgVrKDzxMK+yLqKTiJscf292nbvrg4x3w7uUQImi+nI7WWRxU 8vvSB4bpQOzABqgV1meAFTs3f9BiQSSy9pvbMtZnaPthjDgMA+rIdDt/44a8X6pxlLzf 7ATIoXc6v4V+9jyz5qp/NADdW97D11vZim9SFNFJJJgWThhRoW7VgUqjpM+wAOnyx1Y+ BdTiYhCpJaembRQOBm6ojNPK2VFTf0SmBvXBKfELQsmLiymIKcDhDtPSswpVKaJwDhXW UfbCbEqSe6HJMIF89e33LGthaasddqL5duuBhMnKDPeUC+uOACFw27pP1Y+LLwzPb+QI /LlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=HwPPbRKpDT3yN6oMcf4hXcvxGM1iP7BQGCdSJdEDvxc=; b=Guu070un/j+nm1PsSDXKoRQrLcUCq1LQP0OymZNYDx7SB7lkzuQYAnq5MWgAD4CHEw QA8r8LvZ+5Ct9gxU6Ky43jXE55a0xXavwTSm71i1aUlmJCR+w/fL5nivmToxBUcyGanv kgzn0Ea4003/W2AnBsTSA6qbOZ+qLm2bMolXpnCF8xvBTY5tuUDh4UStKKXWdwAAAeIl 2pOVoMTeD1SAaAfFgNEYR7dMIucDj/n06K6bmNyqOMs7Ws+FCOv7AU1joHZZ0OjSJa+0 GRl2UBHp+00FZCzDlgaw4m7gpa1LlFeVr7Q8aVps6h2AkPTWyTOPniChEBgd58L0N141 AUhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oScXdJx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb10-20020a170907160a00b0072b68e6cd9dsi14248795ejc.389.2022.07.25.08.29.25; Mon, 25 Jul 2022 08:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oScXdJx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236381AbiGYPX6 (ORCPT + 99 others); Mon, 25 Jul 2022 11:23:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236452AbiGYPXm (ORCPT ); Mon, 25 Jul 2022 11:23:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1AE6BEE; Mon, 25 Jul 2022 08:23:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60D186122D; Mon, 25 Jul 2022 15:23:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 943AAC341C6; Mon, 25 Jul 2022 15:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658762609; bh=3s3HCAIq22KW8xdlHADk+52r1ZJHJUwaz1P2FsyYFfU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oScXdJx5xfbg//Whh9manEFT986v5s9h4ig/+L7Fl1xIsraZpC69KrO3xVHv2ggmA idz2nHsBB9F9cxAe/tY5SNmZlc2IVP381AKRbwRgDh9DDDAMD7MP3IOWlaIXQWuNgg QB8+BaFbH+RJ54PsTorxmFWCtucEIEwhGP7JOx+YBJtmQ1sICZGqtGL4PBf9MgGeOg s9ikuOiNopmUNnYFMOKXb3JEskJqAZXKCZELcy/2NcD+6iksi5d+cBwGZflga/A/Is Ptkl432RnAvplE87qAavg5V9sfZR4dbvUzZCyGc0qHqlOWZs6+mV2///k4hiuW5nsx 7U7F1oXYPhyWQ== Message-ID: <8112c80c-8e65-aa0e-e335-562d9b8d3343@kernel.org> Date: Mon, 25 Jul 2022 17:23:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] rtla: Fix double free Content-Language: en-US To: Andreas Schwab , Steven Rostedt Cc: linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220725105639.295a7d7d@gandalf.local.home> From: Daniel Bristot de Oliveira In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/22 17:12, Andreas Schwab wrote: > Avoid double free by making trace_instance_destroy indempotent. When > trace_instance_init fails, it calls trace_instance_destroy, but its only > caller osnoise_destroy_tool calls it again. > > Fixes: 0605bf009f18 ("rtla: Add osnoise tool") > Signed-off-by: Andreas Schwab Acked-by: Daniel Bristot de Oliveira Thanks! -- Daniel