Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc:     linuxppc-dev@lists.ozlabs.org,
        Camelia Groza <camelia.groza@nxp.com>,
        linux-kernel@vger.kernel.org (open list),
        Madalin Bucur <madalin.bucur@nxp.com>,
        linux-arm-kernel@lists.infradead.org,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH v4 21/25] net: fman: Change return type of disable to void
Date:   Mon, 25 Jul 2022 11:10:35 -0400
Message-Id: <20220725151039.2581576-22-sean.anderson@seco.com>
In-Reply-To: <20220725151039.2581576-1-sean.anderson@seco.com>
References: <20220725151039.2581576-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c/3l8I6G2af1kHCa2d95LEczKHi76M0gyyrSKadM4EHyfRz5zIFowZaQjA4X?=
 =?us-ascii?Q?3S6oLLFdC39LE2mFj8cJrC1dovTI6miW+691rhBPkLuxESeOGX8/0JkPzuf8?=
 =?us-ascii?Q?++/O+TvPmX613lIujzWXOxKJpyeZPyYemiPZezyLjvLQRSzohkdCtDhb52FU?=
 =?us-ascii?Q?a8qq/t4Uc67ctjJQYvqdIcZV4slKh2ah4k2L2rL4K/tQP8vSXa0HlfwVpijj?=
 =?us-ascii?Q?UdXlq1TXg7kGSK9tnx9uLo3ekVidWozJypBuK4l5mG/owaIqLxzf4faWZ8qS?=
 =?us-ascii?Q?sM52n+y35hfgSnoWOkVz8hJAE9Dd+HdJ0mUKxZIJ9VRpPl9575NMNAJU0vIh?=
 =?us-ascii?Q?H0cbcWnEe/le2ZhK+H9p11G16Kpw2ZU168SlZSK/eXgeLjKGYZh+3KMIrOk3?=
 =?us-ascii?Q?vAZLbqh17ur6ZKD+IsoBen9EEkPv1wFasivbpdxYvlNRiIOWDHIcxpANriI+?=
 =?us-ascii?Q?vd4IieIsR6UaeerP5HQXrrw+UcnfTeOrNficbY84eUYUgVche7OsA8PGp6Qz?=
 =?us-ascii?Q?WBYYrzwaQBgHevjT4j5zFyXyzKi7a4C3upzeE3vAuDb8N0ncGKpdycn8aVno?=
 =?us-ascii?Q?GUU2FVmwoCNec3cF9bbKnL/yVt4of/EKMo3WmYXq/IDDMRvvNAaDgw8LWgUe?=
 =?us-ascii?Q?MCLO0a3LW/oc1thP1R114kd/SbDw2cIjPJUwthkFJvD5uxRdMWaQkpAwRlXt?=
 =?us-ascii?Q?vWNQB+4ZwCS7847/PHqVG27YaQ4gG6USMmrwN3xvtxjebGDIccmFubb+1hTp?=
 =?us-ascii?Q?K/AtmABifwjZTUoSgJ1okOiSoWlN2tsaemr7jO8uj3Ou4+9wSKgUgOSLoFtR?=
 =?us-ascii?Q?Kn8xgkwXP5sJEEZGr4JsHGnHnjnv8R0xLwKU74XMODztc4fjurIYONCCIQWi?=
 =?us-ascii?Q?NvQa9cu2VuaCH1Lpw7m7wsDQHpOeDpuxXfglL0POm8oDxVFoEfCKyhGZg86F?=
 =?us-ascii?Q?PoCXpVDi+TTP8GwJXeg8CTLQVzU99V3fovuw97iE/1PG/v5vBDN2XfUGlOny?=
 =?us-ascii?Q?JS1vHrVtthVOUKZf0ZzBruOdk5NNa+lGK4iCBwOPXZDN5/9t/Yy8dpf1lWGg?=
 =?us-ascii?Q?gM57W2nfa4km8JzVxFWSP84JHIqQixveLyAvZ9RhsBSsL4q9HQCgaAKVvt/5?=
 =?us-ascii?Q?XKWNk+cyALCdrwONnEVFMUxAIHluEV+nC7aQeyAqeTKCtLs3uKQdO0Hi7Eub?=
 =?us-ascii?Q?0lsawD4MQJeCF/dHtq8zcIMjOmqRDOtJksFtYHXL5yUGwzgZ0Ojs27IJDtD8?=
 =?us-ascii?Q?srdk4aBx0u+n58Fx2CMOylBqhScO/USuufLW0vCth/nZFLCCl1RmJp1EsLuf?=
 =?us-ascii?Q?F7TrMmAPOsdWwAV0UGzr+fGNOQg9YhOvSY4I8Jp8B3b7UNQkLqYJUPLdzi/d?=
 =?us-ascii?Q?LWM4IlvbaRJm0E6exv+b132wigPwI0A5jGRt2vj3qH9yhfqGtNviI25JmVW8?=
 =?us-ascii?Q?fqYY3tomR8LkLVSNoHwglVP9lunyoWIj2cm6bdLtJ+IDQ5u8CCU+8pbtnWUR?=
 =?us-ascii?Q?JftJ5isuiEvON4eNQTW4E9Y1T1fatsKqWOawWaSNU7sB/SwE0oA5RrPQ9Cyr?=
 =?us-ascii?Q?/9MLMu5k2YGIg5OLn6+/N47kzSaWGg+ouwMZ/m1nM6ka5oy8Y65ri/sSJj72?=
 =?us-ascii?Q?3Q=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4412de39-12fe-417c-acf3-08da6e4ff7da
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:11:36.7371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6/ApFkPfrJvjEU5JEzGUmzlUR4uqLIaDsjUK9XetJNWm8DYmBxRicwTFXWcoNIyphsERQxx2RI+fU9l/c1yoiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3723
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When disabling, there is nothing we can do about errors. In fact, the
only error which can occur is misuse of the API. Just warn in the mac
driver instead.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Acked-by: Camelia Groza <camelia.groza@nxp.com>
---

(no changes since v1)

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c   | 5 +----
 drivers/net/ethernet/freescale/fman/fman_dtsec.c | 7 ++-----
 drivers/net/ethernet/freescale/fman/fman_memac.c | 8 +++-----
 drivers/net/ethernet/freescale/fman/fman_tgec.c  | 7 ++-----
 drivers/net/ethernet/freescale/fman/mac.h        | 2 +-
 5 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index d443d53c4504..0ea29f83d0e4 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -290,10 +290,7 @@ static int dpaa_stop(struct net_device *net_dev)
 
 	if (mac_dev->phy_dev)
 		phy_stop(mac_dev->phy_dev);
-	err = mac_dev->disable(mac_dev->fman_mac);
-	if (err < 0)
-		netif_err(priv, ifdown, net_dev, "mac_dev->disable() = %d\n",
-			  err);
+	mac_dev->disable(mac_dev->fman_mac);
 
 	for (i = 0; i < ARRAY_SIZE(mac_dev->port); i++) {
 		error = fman_port_disable(mac_dev->port[i]);
diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
index 7acd57424034..f2dd07b714ea 100644
--- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
@@ -871,13 +871,12 @@ static int dtsec_enable(struct fman_mac *dtsec)
 	return 0;
 }
 
-static int dtsec_disable(struct fman_mac *dtsec)
+static void dtsec_disable(struct fman_mac *dtsec)
 {
 	struct dtsec_regs __iomem *regs = dtsec->regs;
 	u32 tmp;
 
-	if (!is_init_done(dtsec->dtsec_drv_param))
-		return -EINVAL;
+	WARN_ON_ONCE(!is_init_done(dtsec->dtsec_drv_param));
 
 	/* Graceful stop - Assert the graceful Rx/Tx stop bit */
 	graceful_stop(dtsec);
@@ -885,8 +884,6 @@ static int dtsec_disable(struct fman_mac *dtsec)
 	tmp = ioread32be(&regs->maccfg1);
 	tmp &= ~(MACCFG1_RX_EN | MACCFG1_TX_EN);
 	iowrite32be(tmp, &regs->maccfg1);
-
-	return 0;
 }
 
 static int dtsec_set_tx_pause_frames(struct fman_mac *dtsec,
diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 19619af99f9c..8ad93a4c0c21 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -701,19 +701,17 @@ static int memac_enable(struct fman_mac *memac)
 	return 0;
 }
 
-static int memac_disable(struct fman_mac *memac)
+static void memac_disable(struct fman_mac *memac)
+
 {
 	struct memac_regs __iomem *regs = memac->regs;
 	u32 tmp;
 
-	if (!is_init_done(memac->memac_drv_param))
-		return -EINVAL;
+	WARN_ON_ONCE(!is_init_done(memac->memac_drv_param));
 
 	tmp = ioread32be(&regs->command_config);
 	tmp &= ~(CMD_CFG_RX_EN | CMD_CFG_TX_EN);
 	iowrite32be(tmp, &regs->command_config);
-
-	return 0;
 }
 
 static int memac_set_promiscuous(struct fman_mac *memac, bool new_val)
diff --git a/drivers/net/ethernet/freescale/fman/fman_tgec.c b/drivers/net/ethernet/freescale/fman/fman_tgec.c
index 010c0e0b57d7..f4cdf0cf7c32 100644
--- a/drivers/net/ethernet/freescale/fman/fman_tgec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_tgec.c
@@ -408,19 +408,16 @@ static int tgec_enable(struct fman_mac *tgec)
 	return 0;
 }
 
-static int tgec_disable(struct fman_mac *tgec)
+static void tgec_disable(struct fman_mac *tgec)
 {
 	struct tgec_regs __iomem *regs = tgec->regs;
 	u32 tmp;
 
-	if (!is_init_done(tgec->cfg))
-		return -EINVAL;
+	WARN_ON_ONCE(!is_init_done(tgec->cfg));
 
 	tmp = ioread32be(&regs->command_config);
 	tmp &= ~(CMD_CFG_RX_EN | CMD_CFG_TX_EN);
 	iowrite32be(tmp, &regs->command_config);
-
-	return 0;
 }
 
 static int tgec_set_promiscuous(struct fman_mac *tgec, bool new_val)
diff --git a/drivers/net/ethernet/freescale/fman/mac.h b/drivers/net/ethernet/freescale/fman/mac.h
index c5fb4d46210f..a55efcb7998c 100644
--- a/drivers/net/ethernet/freescale/fman/mac.h
+++ b/drivers/net/ethernet/freescale/fman/mac.h
@@ -38,7 +38,7 @@ struct mac_device {
 	bool allmulti;
 
 	int (*enable)(struct fman_mac *mac_dev);
-	int (*disable)(struct fman_mac *mac_dev);
+	void (*disable)(struct fman_mac *mac_dev);
 	void (*adjust_link)(struct mac_device *mac_dev);
 	int (*set_promisc)(struct fman_mac *mac_dev, bool enable);
 	int (*change_addr)(struct fman_mac *mac_dev, const enet_addr_t *enet_addr);
-- 
2.35.1.1320.gc452695387.dirty