Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Sean Anderson <sean.anderson@seco.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: [PATCH v3 11/11] net: phy: aquantia: Add support for rate adaptation
Date:   Mon, 25 Jul 2022 11:37:29 -0400
Message-Id: <20220725153730.2604096-12-sean.anderson@seco.com>
In-Reply-To: <20220725153730.2604096-1-sean.anderson@seco.com>
References: <20220725153730.2604096-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uNzriAjfNItmztd6wjPSKsyhoKGXxaZEm1D9tgyqLpO/KYymQbgaz8qqeFTo?=
 =?us-ascii?Q?bYAvOw30rG3tHvuTddKuBJ5hdMtJUdjJ00zAz8+HQCXWhTSsijbPqu9mA1RT?=
 =?us-ascii?Q?5azr1vrRzDzCU2OQSkcZ89oaY4tS9KMmpMgNzUySL8rcoUd9Xji7tTM9ZjDc?=
 =?us-ascii?Q?h9rtrju+cFHSuL1mDNQj+HzNBxWqDQsgk/+N+Di91lbgZcBriraNO48bD8ha?=
 =?us-ascii?Q?Xuo/KohfFuSb/do1L4hc+wsTVrEBD64glf9IzZ222JX++elf6CCnw+GLo8J8?=
 =?us-ascii?Q?Dg0qL5xWMAcYkwh7Quh/usokLDZ5BQN3hFfIaE1H0Ovg3gOj1p/iyuoNXp8W?=
 =?us-ascii?Q?f4oqQ+oiHfdtLXzVwqtGEqMpTo5yKj6Xn0flFHPZe5IiOT5SvzY/7RlVmrk6?=
 =?us-ascii?Q?FqxmCvGUVtX+EvJpTphfHBlN4TT8uBTz6nUjop8EWzpZZ0G7WfOlCJPgeyZO?=
 =?us-ascii?Q?np+/W7+mACKin7C7sp7EnefzVDyM0uhfL70NDvfSlzfyzcvQq+cOWybul2XZ?=
 =?us-ascii?Q?no/CsZuA8mcxn7bfja303fIhSKMpoF5w5+4WFIudvZStdtJ9VqmnaK2EM8Yc?=
 =?us-ascii?Q?i8VsdRkGhzrR+ZYNwpzy0aJRxO9d7M17hVB606hFzzVbqrWUeuONjOCGN91K?=
 =?us-ascii?Q?4yDqXb9eRsdUdG7CB7/6YiTL9NNy5Pz5AsYgUCpd2CBZGqbcutHe218FhMcQ?=
 =?us-ascii?Q?5oyly4Qqj1KHUJBwNOYb5YvbwjeA9ZRUXEjKTWx/nEBuRlTILgtp+h7fKZxt?=
 =?us-ascii?Q?a9PvhE8Bq7/HqCW9YsAPBnKqDUMKpwqPhypavP9J4sMiHG5TZiY+ACncgYe1?=
 =?us-ascii?Q?ogGlaC3YaNI88epv6cl2GS1CfaLfiV+f3259F5lmmE6BlgC2qP0wa2p2VTOo?=
 =?us-ascii?Q?sZGEgmlQVyMVJvbPsxutw9VWT7vUm8C6gnosrVuYHeQAkF1fUsT54c1+Dfi4?=
 =?us-ascii?Q?qmEkdXU+kHgPAdvXFRKDOhWLijbswWi+Fo+vtLKIP0/vgO7ZN/2sYUFRmb+I?=
 =?us-ascii?Q?B200H02k2CoRFRM3plJtMKPAcyRA5lUc427vDO1RMny8UiRcqaf/AlHYN9xd?=
 =?us-ascii?Q?pQRwc2pwIDvZcBjeuyxvFrD1AHXsUHN1IOGWszEnx/2kgak9sDPVhu4pDtrr?=
 =?us-ascii?Q?qaHxXdIaKnE+cSlVN3a11rIlMqh33GeZcwoQqQuaVGnPg6pgNfLkfB4DBeeu?=
 =?us-ascii?Q?/YRp3KDNrwbumVwA2NMWrcYv8wx3SxqwmfgYholp354aBIxeMTd344y4HFNz?=
 =?us-ascii?Q?FzWOxSLMZzcV90pgi0DfoItbIJtAbtfNyR6y9cXLXmmRfqIzAeyIyV0fsYxt?=
 =?us-ascii?Q?671ZitsDpMdwaj0ImX4c6XJxjNyQCVMfRtleDLTERoMOeUz94y3ZvTZ5bFL3?=
 =?us-ascii?Q?WsgQwQYf1GxUYkeUbgkRkYUh2la9fAWhYEyOnNHxmyT32o7u7p5xg0lgFuhk?=
 =?us-ascii?Q?UOCpbtz0hnWX/DxOHZ+rFWBVAYWCK91GdUJ/U6w0V23zOuTN/22x3MWUAye1?=
 =?us-ascii?Q?qUyDeQ2BxES+z+KrJ+pkhZ8cmmgszYWpBQZhXJroFuIq38m7S8JP6G8/bnEw?=
 =?us-ascii?Q?EI00/PrfFgKCzYclM3Vybu0maWlTxkDnXEz+7mEmsTHzGMkd5M9/13+ecqsC?=
 =?us-ascii?Q?HA=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 448eb526-a181-42b8-96c1-08da6e53a793
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:38:00.0248
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BMR1E5MrZ0F4TPnDY08JoiFk6XanATOo6+Tktq5EciGn44XLoC9gT1i/E7C4qQqk8Y969eQbUzf9ebe3DgqXhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6464
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This adds support for rate adaptation for phys similar to the AQR107. We
assume that all phys using aqr107_read_status support rate adaptation.
However, it could be possible to determine support based on the firmware
revision if there are phys discovered which do not support rate adaptation.
However, as rate adaptation is advertised in the datasheets for these phys,
I suspect it is supported most boards.

Despite the name, the "config" registers are updated with the current rate
adaptation method (if any). Because they appear to be updated
automatically, I don't know if these registers can be used to disable rate
adaptation.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

(no changes since v2)

Changes in v2:
- Add comments clarifying the register defines
- Reorder variables in aqr107_read_rate

 drivers/net/phy/aquantia_main.c | 51 ++++++++++++++++++++++++++++++---
 1 file changed, 47 insertions(+), 4 deletions(-)

diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c
index b3a5db487e52..dd73891cf68a 100644
--- a/drivers/net/phy/aquantia_main.c
+++ b/drivers/net/phy/aquantia_main.c
@@ -94,6 +94,19 @@
 #define VEND1_GLOBAL_FW_ID_MAJOR		GENMASK(15, 8)
 #define VEND1_GLOBAL_FW_ID_MINOR		GENMASK(7, 0)
 
+/* The following registers all have similar layouts; first the registers... */
+#define VEND1_GLOBAL_CFG_10M			0x0310
+#define VEND1_GLOBAL_CFG_100M			0x031b
+#define VEND1_GLOBAL_CFG_1G			0x031c
+#define VEND1_GLOBAL_CFG_2_5G			0x031d
+#define VEND1_GLOBAL_CFG_5G			0x031e
+#define VEND1_GLOBAL_CFG_10G			0x031f
+/* ...and now the fields */
+#define VEND1_GLOBAL_CFG_RATE_ADAPT		GENMASK(8, 7)
+#define VEND1_GLOBAL_CFG_RATE_ADAPT_NONE	0
+#define VEND1_GLOBAL_CFG_RATE_ADAPT_USX		1
+#define VEND1_GLOBAL_CFG_RATE_ADAPT_PAUSE	2
+
 #define VEND1_GLOBAL_RSVD_STAT1			0xc885
 #define VEND1_GLOBAL_RSVD_STAT1_FW_BUILD_ID	GENMASK(7, 4)
 #define VEND1_GLOBAL_RSVD_STAT1_PROV_ID		GENMASK(3, 0)
@@ -338,40 +351,57 @@ static int aqr_read_status(struct phy_device *phydev)
 
 static int aqr107_read_rate(struct phy_device *phydev)
 {
+	u32 config_reg;
 	int val;
 
 	val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_AN_TX_VEND_STATUS1);
 	if (val < 0)
 		return val;
 
+	if (val & MDIO_AN_TX_VEND_STATUS1_FULL_DUPLEX)
+		phydev->duplex = DUPLEX_FULL;
+	else
+		phydev->duplex = DUPLEX_HALF;
+
 	switch (FIELD_GET(MDIO_AN_TX_VEND_STATUS1_RATE_MASK, val)) {
 	case MDIO_AN_TX_VEND_STATUS1_10BASET:
 		phydev->speed = SPEED_10;
+		config_reg = VEND1_GLOBAL_CFG_10M;
 		break;
 	case MDIO_AN_TX_VEND_STATUS1_100BASETX:
 		phydev->speed = SPEED_100;
+		config_reg = VEND1_GLOBAL_CFG_100M;
 		break;
 	case MDIO_AN_TX_VEND_STATUS1_1000BASET:
 		phydev->speed = SPEED_1000;
+		config_reg = VEND1_GLOBAL_CFG_1G;
 		break;
 	case MDIO_AN_TX_VEND_STATUS1_2500BASET:
 		phydev->speed = SPEED_2500;
+		config_reg = VEND1_GLOBAL_CFG_2_5G;
 		break;
 	case MDIO_AN_TX_VEND_STATUS1_5000BASET:
 		phydev->speed = SPEED_5000;
+		config_reg = VEND1_GLOBAL_CFG_5G;
 		break;
 	case MDIO_AN_TX_VEND_STATUS1_10GBASET:
 		phydev->speed = SPEED_10000;
+		config_reg = VEND1_GLOBAL_CFG_10G;
 		break;
 	default:
 		phydev->speed = SPEED_UNKNOWN;
-		break;
+		return 0;
 	}
 
-	if (val & MDIO_AN_TX_VEND_STATUS1_FULL_DUPLEX)
-		phydev->duplex = DUPLEX_FULL;
+	val = phy_read_mmd(phydev, MDIO_MMD_VEND1, config_reg);
+	if (val < 0)
+		return val;
+
+	if (FIELD_GET(VEND1_GLOBAL_CFG_RATE_ADAPT, val) ==
+	    VEND1_GLOBAL_CFG_RATE_ADAPT_PAUSE)
+		phydev->rate_adaptation = RATE_ADAPT_PAUSE;
 	else
-		phydev->duplex = DUPLEX_HALF;
+		phydev->rate_adaptation = RATE_ADAPT_NONE;
 
 	return 0;
 }
@@ -612,6 +642,16 @@ static void aqr107_link_change_notify(struct phy_device *phydev)
 		phydev_info(phydev, "Aquantia 1000Base-T2 mode active\n");
 }
 
+static int aqr107_get_rate_adaptation(struct phy_device *phydev,
+				      phy_interface_t iface)
+{
+	if (iface == PHY_INTERFACE_MODE_10GBASER ||
+	    iface == PHY_INTERFACE_MODE_2500BASEX ||
+	    iface == PHY_INTERFACE_MODE_NA)
+		return RATE_ADAPT_PAUSE;
+	return RATE_ADAPT_NONE;
+}
+
 static int aqr107_suspend(struct phy_device *phydev)
 {
 	return phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MDIO_CTRL1,
@@ -673,6 +713,7 @@ static struct phy_driver aqr_driver[] = {
 	PHY_ID_MATCH_MODEL(PHY_ID_AQR107),
 	.name		= "Aquantia AQR107",
 	.probe		= aqr107_probe,
+	.get_rate_adaptation = aqr107_get_rate_adaptation,
 	.config_init	= aqr107_config_init,
 	.config_aneg    = aqr_config_aneg,
 	.config_intr	= aqr_config_intr,
@@ -691,6 +732,7 @@ static struct phy_driver aqr_driver[] = {
 	PHY_ID_MATCH_MODEL(PHY_ID_AQCS109),
 	.name		= "Aquantia AQCS109",
 	.probe		= aqr107_probe,
+	.get_rate_adaptation = aqr107_get_rate_adaptation,
 	.config_init	= aqcs109_config_init,
 	.config_aneg    = aqr_config_aneg,
 	.config_intr	= aqr_config_intr,
@@ -717,6 +759,7 @@ static struct phy_driver aqr_driver[] = {
 	PHY_ID_MATCH_MODEL(PHY_ID_AQR113C),
 	.name           = "Aquantia AQR113C",
 	.probe          = aqr107_probe,
+	.get_rate_adaptation = aqr107_get_rate_adaptation,
 	.config_init    = aqr107_config_init,
 	.config_aneg    = aqr_config_aneg,
 	.config_intr    = aqr_config_intr,
-- 
2.35.1.1320.gc452695387.dirty