Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp40520imn; Mon, 25 Jul 2022 09:41:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uiwjvXAz5MTPkGwbXXxG4LUFp0nJn4KmrB+y8FnjJMIRJGLaTynvgvYUS8zDm69FCWsF4P X-Received: by 2002:a17:907:2889:b0:72b:50c8:c703 with SMTP id em9-20020a170907288900b0072b50c8c703mr10510624ejc.694.1658767302588; Mon, 25 Jul 2022 09:41:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658767302; cv=none; d=google.com; s=arc-20160816; b=dQbHV5m9jkWzloYfzeiEIzLhP5Gq6M1N26iBgVPq+6yAdqAMI/lZtbeQqGGXmqKPiS pLb+lvah/QmWVzWTZjIaI+uWF+vD7bMTXUTIrs5YNCleB2IHhdegS25z1yat300+9oqZ kfOUWKeTdBHLdWuU3pX/jmcuSvIh6VKDmiK2kRbXqjfhvkoZqO5jxNKXyrZPueTuN1le tjAVRaHcYXK7izABieAQGneMqlNPbSXzPGL20CWtHDDWrM9fZn4+glTjrXCMnXiRHnsq biSx0Xm221G50SN+Wk2D6APDvqxkQ0kOwAVN5VYq0uWZbGZZ3k7Wd7kja8XPX+4Z0ZbY zK/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7xVgMqmN/86GQHcqXO1yw7VSBDbzPsFu44uQMKjUJeE=; b=XM9fi5ioDE5TEQLNGC7hy6toY46AJyp9H1WMb+CHbhLa6sKs1alzTjBHKH2Ycflxru 01gpyRqFVBPKXdMBgSui/5Z+Cv01EmGrtfzLYJVYoGFKuvjaz1i7SG8RyHyJpIAIBQOY 6LyvNpFEG427YQ1BbGdXtwmX6p1dWli1zYqKZZFcyHorK6M1ZcSE71yFs4T98eb+kL/B EFxAX62SEBJn7IjvxajGCCMa/J6SgIemDeM4/C60fycrDtKW7bxHmBYpZLVaeieuGdJz NgqUnMlaNKCCFQ4qyEbUiCFSGLRALIpRxuKLwE8XOIuiUqW4pHFR59HOwLncU0VhA4s6 PGXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=G1BoE6F8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n25-20020aa7d059000000b0043bb6c97fa0si11839547edo.75.2022.07.25.09.41.18; Mon, 25 Jul 2022 09:41:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=G1BoE6F8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236414AbiGYQkF (ORCPT + 99 others); Mon, 25 Jul 2022 12:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236517AbiGYQjz (ORCPT ); Mon, 25 Jul 2022 12:39:55 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8753E1DA56 for ; Mon, 25 Jul 2022 09:39:51 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id x11so8606403qts.13 for ; Mon, 25 Jul 2022 09:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7xVgMqmN/86GQHcqXO1yw7VSBDbzPsFu44uQMKjUJeE=; b=G1BoE6F8flgmzsQzfW3nkF7mptQonm328gZXYogDGG2IBIo/98/hfHLbhV7UAJkXQI X8ynxusv76jgdnblo7OxdqtfwPoXk/rNSeoDm2clKMjo+cyP+MkOivoz3cjRpyBfFOMl SIlEVNpakmxkbmqt4+XxLQLJ4QQ5PCkIi8fjAenSwWjxlcnBfytss8LLn3ERV7YvDbZa +VH8K1yK0xvi9ijH2dX3DZyfC4rI5TE1UjZr8z9tc/TucWdSj8cQGKObuYxB1bKQ6CbK 2/AGAfXA0e/T+pDGaivYnTvUT5YBiUB+stnvoGNHnjm/BVx/LCqP/LJmcqT6Q4OGgHau mRpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7xVgMqmN/86GQHcqXO1yw7VSBDbzPsFu44uQMKjUJeE=; b=5NX/b9S5RYFHDaTfdmlp+y9UrOL/q5l/yTL00/F2cFrax8wYOLcAibLNnRCUU0hDtM yxFMYTQWM1aoYDl/8CY3yBxNPiTjM7SBxvEfTTcfwQU3SY3spK15YaALkoB4mq+0BVE9 LOzIWEhPBgHPLC7Vx/ZMNnnqE0+0RfAfLRfqLXhh1Fn5d7eQ80W1RidU/dl7/O1hz3X0 e2j3jA+beKsG8p5oBhSC10SmjT7jJhY6Zf/UA87YajYfY0hEOI/PSr7h5uPQ/RfGMe+X +W9uunSp9c7BONb9Ga0VrZpwzbiGlcOvu59gGgim6IUE/FEhtGbbmZj2XrtBXUp2ln8x Lw4A== X-Gm-Message-State: AJIora/vapC/dBSFoaa6A46GpAnTOTEOVlFUuMCw/xt6nwh0oZE9CwHJ A/etW6brizeKGk4fVCsNAoHaX7yZ/eE9Kw== X-Received: by 2002:a05:622a:1710:b0:31f:340:41dc with SMTP id h16-20020a05622a171000b0031f034041dcmr11262377qtk.311.1658767190695; Mon, 25 Jul 2022 09:39:50 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:994f]) by smtp.gmail.com with ESMTPSA id r19-20020a37a813000000b006a6d7c3a82esm9041344qke.15.2022.07.25.09.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 09:39:50 -0700 (PDT) Date: Mon, 25 Jul 2022 12:39:49 -0400 From: Johannes Weiner To: Chengming Zhou Cc: surenb@google.com, mingo@redhat.com, peterz@infradead.org, tj@kernel.org, corbet@lwn.net, akpm@linux-foundation.org, rdunlap@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, cgroups@vger.kernel.org Subject: Re: [PATCH 3/9] sched/psi: move private helpers to sched/stats.h Message-ID: References: <20220721040439.2651-1-zhouchengming@bytedance.com> <20220721040439.2651-4-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220721040439.2651-4-zhouchengming@bytedance.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 12:04:33PM +0800, Chengming Zhou wrote: > This patch move psi_task_change/psi_task_switch declarations out of > PSI public header, since they are only needed for implementing the > PSI stats tracking in sched/stats.h > > psi_task_switch is obvious, psi_task_change can't be public helper > since it doesn't check psi_disabled static key. And there is no > any user now, so put it in sched/stats.h too. > > Signed-off-by: Chengming Zhou Acked-by: Johannes Weiner