Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fac8ce6e-6f5f-598d-35cc-7bf01ac90f30@amd.com>
Date:   Mon, 25 Jul 2022 12:40:28 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amdgpu: remove useless condition in
 amdgpu_job_stop_all_jobs_on_sched()
Content-Language: en-US
To:     Andrey Strachuk <strochuk@ispras.ru>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Emma Anholt <emma@anholt.net>,
        Melissa Wen <mwen@igalia.com>,
        Guchun Chen <guchun.chen@amd.com>,
        Surbhi Kakarya <surbhi.kakarya@amd.com>,
        Jack Zhang <Jack.Zhang1@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
References: <20220719103954.6737-1-strochuk@ispras.ru>
From:   Andrey Grodzovsky <andrey.grodzovsky@amd.com>
In-Reply-To: <20220719103954.6737-1-strochuk@ispras.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEZrNDVySFZGdjdWamZtWmJ4RW9xY3lNcnNqNjFjVE00NVNneDRNR3VLQkVr?=
 =?utf-8?B?L3FvZHRhR0NIQU5CbW8zMGs5Y2V4V3I3Y2pjTHltTkV2NERyZjY5ZTlsTlZw?=
 =?utf-8?B?cTliM0dlMVpjOGFnYzYyRkd1eDVXNDE2UjF2aEYwWEdmenNKdGFZUmRzZWd2?=
 =?utf-8?B?OTQxRjJOWFhia3dIZVM2QVlwa3FQZ2dmOGxwNElEUElBMTRyMFdjRDJGTEtP?=
 =?utf-8?B?OXVOUEFaQ21peTNBSmVGbmRDTFd5dVR0K3FtL2JhWGk3WG51U1RPcVorRnlE?=
 =?utf-8?B?RzNmVWF3VUZlL0lHUUUxU21UdXpGRU9FYVNYY00zTm5hUkgwWlcwbHp5S0ky?=
 =?utf-8?B?WHEvUFY2bGI4azRNSUpxRi95bzI3K3ZLVHhsT2ZFNngrd2FEdE1PcjdhT2ZQ?=
 =?utf-8?B?alk3MTFCdzk1aHdBcDJLdUxIUitxMUFXK2h1Q3drL2ZqdmhwNTVQQXBlV2hw?=
 =?utf-8?B?NU9iRWNwSTV3ODJsTjZYRGtYelpxejcvRDl1VEVObW9zS3QycTFwOXpCNzQ4?=
 =?utf-8?B?V3pvN2s5czRScE1Rb2FxZmhHdDBWeUI3TVBvektlU05KZVhyU1dlbjB6b0p0?=
 =?utf-8?B?ZWhyYkVXajduaHFHOWpncU8vUFJlNXN3MFpkZVpVL2tvb1JXWVNpYlBtcXQ0?=
 =?utf-8?B?Rk9IYnBHbklxenVIYXg4cytCUWNLYjdudC9Qd25MWmJReWE3dHNFV2lPT0lj?=
 =?utf-8?B?dm52SXVOSjZFN0dQS084RGNnMlFBbklkeUs0Nk5PZG1IaWptYTFOMHRCT0Js?=
 =?utf-8?B?dk5jVGs3bUxnNkxYN241WWlrYks4ZGhSZGdiWUc2TUc5UWZBUitTUWYwOGFU?=
 =?utf-8?B?bVRLSzY5a3lET3FmMFBrT1o4Z2kwclFZR0JMUmx1djFPeitOYkNXMWdTRXA2?=
 =?utf-8?B?ZFVESFRvV0s4UVM4Vjk2MmMxYk5RejJva2FhaXI4VXRMVCsvYXhWQ1kvZ0N5?=
 =?utf-8?B?eVV1cTR5QXQxUGdvRVJSTzFWTkp5NStsNmJwWWlySEJpSkNOMlAwQ2ZoS2p5?=
 =?utf-8?B?SlJzak03ZGhiUnFvdFVTSFJPMTNJcEk0dHBhdVVPVjFJZlZUc2xCNi9UM1Jk?=
 =?utf-8?B?eTJuZ01DMnNTVXo3NE1XeFhyRmR0Unk5MGdNZGJUVXhvclN4d1JNWDQ2bmZZ?=
 =?utf-8?B?L3EvWFBtcDdXZVdkZUZ5QW5YdVlTdkR0VFZGbThHcElaU04vQjI3QVB0NEVq?=
 =?utf-8?B?M1k2YkFGRzllVkltdTlrRFpvLzBZbVBoZDhCY0ZocGZwVjI4eHZpUGJvZlk2?=
 =?utf-8?B?Skd1YllQRTMyT3ozZHQ1NWQ3c24wTkZQenJQT1hqclV1ZEh2akJzazVMMmMv?=
 =?utf-8?B?cDNocmV1K0prSW9qcC9idkJvRFRqbE90bDkybCtNY2c4VnA1eEJaR3NsbnJM?=
 =?utf-8?B?WjJhV3ZIZ0FBV2dQelZEOVVKUVVRRmpXVlN3YlNudU1qMVpQczYrY2hBcHNT?=
 =?utf-8?B?WGc1M2Mwc1lPa1F3dzczVFVnUEZpRm1rbDBYTENWYnluYytQWndJaE9IYWIv?=
 =?utf-8?B?STZ6aDZLZmtrakxwd0RSc21EWFBzMGZSWDY5RjdZTTBEOFoweTNyV0pUYlN6?=
 =?utf-8?B?LzZBcFV3dDVVWm1OUWRrTCtVYWhwU2U2a0tGeC8vYjVpZTZYeFdGbGdNcm11?=
 =?utf-8?B?ZFMvOE5RMTVtYVUvOTlxQWx1Q2tnS2RMSHNyUjZCVlM2WXdPdlgwdW52QjN0?=
 =?utf-8?B?eTBLc2JmcTVIcm1WYzN4dEVPZHNKWGRYKzNuNGc5UmlaYnNLYUQ1QU1nVGVl?=
 =?utf-8?B?djhSUmJVVkkwV0U5c2RMM0lnR3JlRVQweFpsMG1ITGVBWHFHUTF1UTF4Tmls?=
 =?utf-8?B?RGl5SVpHOGJvYThDM1NNUXRQaVRjQk1VZlR1cHV1ZkxCaER6OCs3YktDT0kw?=
 =?utf-8?B?clZpcTlPbDBxQTZWNFpCbjZndDNHU0xqNHJBYUxVTXIxc1R2d05LQ2t4Mkhj?=
 =?utf-8?B?OUVDUW5qWWNibmpBTHgyZms4ZkQrU0cyTjhiOFBYMk9mM0hOdkJhRHhCWU92?=
 =?utf-8?B?bTU3Q290UzlPa2ZaL2dGdFNZMXZSdlpucW15UHh5NmNPT0t1MFpXKzh3SUtX?=
 =?utf-8?B?aDMzRkxlYmloMkUySy9GZWllQ2NKZnZRRmZHKzRieXlkak81U0hnWTk1aXk1?=
 =?utf-8?B?SDEzYUFCa2VDN0FOdmlMcExMbmdzL0wzYjB2YUJUQzIwUEZSOUJzMGFyQS9r?=
 =?utf-8?Q?IQqJ6145RrDzHiRG9nXVo04b6G/AUNgNw4QBfEaI0wuu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfb9b0e7-14f4-4b22-4a1e-08da6e5c642f
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1947.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 16:40:32.5869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cqckq8GXtnR2lYIoPWER2Y7nxfd2pqa/Pa/xMKkaXJYM1kYh3iLnlwU9Dcj/ctmBYX+b49ZkYI/Al72lDipalQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6890
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>

Andrey

On 2022-07-19 06:39, Andrey Strachuk wrote:
> Local variable 'rq' is initialized by an address
> of field of drm_sched_job, so it does not make
> sense to compare 'rq' with NULL.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
> Fixes: 7c6e68c777f1 ("drm/amdgpu: Avoid HW GPU reset for RAS.")
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 67f66f2f1809..600401f2a98f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -285,10 +285,6 @@ void amdgpu_job_stop_all_jobs_on_sched(struct drm_gpu_scheduler *sched)
>   	/* Signal all jobs not yet scheduled */
>   	for (i = DRM_SCHED_PRIORITY_COUNT - 1; i >= DRM_SCHED_PRIORITY_MIN; i--) {
>   		struct drm_sched_rq *rq = &sched->sched_rq[i];
> -
> -		if (!rq)
> -			continue;
> -
>   		spin_lock(&rq->lock);
>   		list_for_each_entry(s_entity, &rq->entities, list) {
>   			while ((s_job = to_drm_sched_job(spsc_queue_pop(&s_entity->job_queue)))) {