Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp57371imn; Mon, 25 Jul 2022 10:04:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u6rcr21R+X534VeBivq20EaeYyi9oBCstwyzjs/K9hzIgu2jideWnE5ws+aQhxkniTjIFq X-Received: by 2002:a17:90b:702:b0:1f2:3573:9b45 with SMTP id s2-20020a17090b070200b001f235739b45mr15032663pjz.59.1658768646242; Mon, 25 Jul 2022 10:04:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658768646; cv=none; d=google.com; s=arc-20160816; b=ZXohIGM5iJnmIBjEzYrvvBrgtT80Wvtz5ZbhiJRUfUjAhboWqidKPa8TNNbhrurQCs Ua+YzUaKZL4ht8GcUeG3nQUa+R/h8Gmr4tQOdSqAhYzrifOWXL45ExHbV0Qf8oU/qZF+ 5YF+wEXAA4bVJO6gy7Dvtt0VhOBH5wbfmVdOTtQ0StL/tXXNa6tuxit5jnSNYLXAcaia /Q0p+Ppfhzw53nTa7xPgSxFX0q1VG075M/PwRhNUth6FyyHFkJvYDByIQGV/ZpTua8fg W+M2ZDaaKxFMxoGp0Ljm7YkFjYbxs1643XPQPNPwWsmt/Zg+X8f7jkAhyUOAqyp3DCZz 6pdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ueOMTo6DsQCvnulLJ7Rsqpth0YKKV57efxM+awobwkc=; b=pTMrPqp4+zFY+5H+hfo7ifDLLYwu/rTx2zuFEDPlL49/eksEM/+T5UieS804ZwQ9X+ is5lJSoHJtJ00pwhFPFiCyIZjdMCsIUzzv9+78fyOTcE2LeY+YLt2LDf2oLQgwQI6/VH OuIpEbURnXSHjkfkmLUBshJnd42TxJsJyvfHCVn4G3YnJEl7lQUIC6ijI6AwZ5J56waS bA9T2XtcGvv9b97zKemcgczyJXOIfoAINZ0v2hLxczoXyzV/+GpSH20fY5hPBU61OxJR oGUugzOXFrQRe+IUXRpcGCOS+/VEvb1yIjirXFGK5NuFqRZRKbeVGU/q7wADObCp5vji okYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=1SD4nF22; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 29-20020a63125d000000b004197598c879si13476729pgs.700.2022.07.25.10.03.50; Mon, 25 Jul 2022 10:04:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=1SD4nF22; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232589AbiGYQrw (ORCPT + 99 others); Mon, 25 Jul 2022 12:47:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232072AbiGYQru (ORCPT ); Mon, 25 Jul 2022 12:47:50 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABE54BE19 for ; Mon, 25 Jul 2022 09:47:47 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id j11so8813952qvt.10 for ; Mon, 25 Jul 2022 09:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ueOMTo6DsQCvnulLJ7Rsqpth0YKKV57efxM+awobwkc=; b=1SD4nF22NDrVthsvc/CcEaNX0GsOg8NrfWYQauQ6kZ74/Cf5YJX7Qk7C9QYuipn3dc /75txsFW7Y+hWMthAHT7xUpXGfNxA3+uwyKDdnPOvRjLAjoNosLPlXssiDxAdYS7n7Jg UwVDAE+eUF9u+ZhvysT3aXuegZZaQVBosX2fekmPN6pfxTmUviDaE/y1MZN7SG1p6PFN jrMEAAfWkhyrGkTrkhwlrN4NgjBSnR+iOqCXqUKe4nW4/ddOFDf7L7MeHWR36Gz2bm0w HWRIuOJKtD/Ge3FM/1ggPWvXsLLCav4plXeFanzurA9vEmbG5hSVzxuFIwafwUgVAol0 YdxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ueOMTo6DsQCvnulLJ7Rsqpth0YKKV57efxM+awobwkc=; b=1PNYjzN9wSAk6W5NfSeTW+YO7E3cmAX1eE2kDMbzibMxaHFJ2myqKs8pvwulaEwE5e s/5tGkrH+vXPZuAP6o6jBVrl3rIwHUkuvTfgXr2vsWRSk1y0M1uwBvH7L5/KSDLddPQc wE6HZ1+ad98MNjYyNkjrX4u+qSVC/fDzdELcMY0ZS5tjRpRzCdHUGK+AIy9VK7BOH1Sn Xzp4/YZC32ITQM7qP7Nkm89+1t0nvjJjntktKxCq+YWQvD0e2rWxeLkQZhelBMhwKG3j 5wIRefxAt+J12Re08RAgdSmk0uBMqoWXdsysT0hiFH2+AwVbGKMyXvZf6DTAUMQqzZBh pejw== X-Gm-Message-State: AJIora/Uigre6R3Y2yD6/+SfsMPunb03d4WtU8dgRWRWMBrlYzp6G9mU reo60c8Wx70LVlLVBx2dKuFWGQ== X-Received: by 2002:a05:6214:d81:b0:45a:e07e:6bcb with SMTP id e1-20020a0562140d8100b0045ae07e6bcbmr10926274qve.29.1658767666878; Mon, 25 Jul 2022 09:47:46 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:994f]) by smtp.gmail.com with ESMTPSA id q6-20020a05620a2a4600b006b633dc839esm6966288qkp.66.2022.07.25.09.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 09:47:46 -0700 (PDT) Date: Mon, 25 Jul 2022 12:47:45 -0400 From: Johannes Weiner To: Chengming Zhou Cc: surenb@google.com, mingo@redhat.com, peterz@infradead.org, tj@kernel.org, corbet@lwn.net, akpm@linux-foundation.org, rdunlap@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, cgroups@vger.kernel.org Subject: Re: [PATCH 6/9] sched/psi: save percpu memory when !psi_cgroups_enabled Message-ID: References: <20220721040439.2651-1-zhouchengming@bytedance.com> <20220721040439.2651-7-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220721040439.2651-7-zhouchengming@bytedance.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 12:04:36PM +0800, Chengming Zhou wrote: > We won't use cgroup psi_group when !psi_cgroups_enabled, so don't > bother to alloc percpu memory and init for it. > > Also don't need to migrate task PSI stats between cgroups in > cgroup_move_task(). > > Signed-off-by: Chengming Zhou Acked-by: Johannes Weiner