Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220725155955.46439-1-goriainov@ispras.ru>
In-Reply-To: <20220725155955.46439-1-goriainov@ispras.ru>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 25 Jul 2022 10:56:17 -0600
Message-ID: <CAL_JsqLGMAx=C8hm+MD5mOfQD31Nhz=DrtBg3230q6qBMzyRog@mail.gmail.com>
Subject: Re: [PATCH] scripts/dtc: Fix memory leak in check_msg()
To:     Stanislav Goriainov <goriainov@ispras.ru>
Cc:     Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ldv-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 25, 2022 at 10:00 AM Stanislav Goriainov
<goriainov@ispras.ru> wrote:
>
> When the function check_msg() is called, memory for str is allocated
> via xasprintf() and xasprintf_append() (as well as for file_str),
> but is not freed anywhere later (although file_str is).
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: c2e7075ca830 ("scripts/dtc: Update to upstream version v1.4.7-57-gf267e674d145")

scripts/dtc/ is sync'ed periodically with upstream dtc. We don't take
patches against it. You must submit this to upstream dtc.

> Signed-off-by: Stanislav Goriainov <goriainov@ispras.ru>
> ---
>  scripts/dtc/checks.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c
> index 781ba1129a8e..92ffc8de6a52 100644
> --- a/scripts/dtc/checks.c
> +++ b/scripts/dtc/checks.c
> @@ -114,6 +114,7 @@ static inline void  PRINTF(5, 6) check_msg(struct check *c, struct dt_info *dti,
>         }
>
>         fputs(str, stderr);
> +       free(str);
>  }
>
>  #define FAIL(c, dti, node, ...)                                                \
> -- 2.34.1
>