Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <017a3722-d61f-6762-d17f-57417f1e3165@linaro.org>
Date:   Mon, 25 Jul 2022 21:39:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal compatible
 string
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>,
        Harini Katakam <harini.katakam@xilinx.com>
Cc:     nicolas.ferre@microchip.com, davem@davemloft.net,
        claudiu.beznea@microchip.com, kuba@kernel.org, edumazet@google.com,
        pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        michal.simek@xilinx.com, harinikatakamlinux@gmail.com,
        harini.katakam@amd.com, devicetree@vger.kernel.org,
        radhey.shyam.pandey@xilinx.com
References: <20220722110330.13257-1-harini.katakam@xilinx.com>
 <20220722110330.13257-2-harini.katakam@xilinx.com>
 <20220725193356.GA2561062-robh@kernel.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220725193356.GA2561062-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/07/2022 21:33, Rob Herring wrote:
> On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
>> From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
>>
>> Add versal compatible string.
>>
>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
>> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
>> ---
>> v2:
>> Sort compatible string alphabetically.
>>
>>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> index 9c92156869b2..762deccd3640 100644
>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> @@ -20,6 +20,7 @@ properties:
>>  
>>        - items:
>>            - enum:
>> +              - cdns,versal-gem       # Xilinx Versal
>>                - cdns,zynq-gem         # Xilinx Zynq-7xxx SoC
>>                - cdns,zynqmp-gem       # Xilinx Zynq Ultrascale+ MPSoC
> 
> Uh, how did we start this pattern? The vendor here is Xilinx, not 
> Cadence. It should be xlnx,versal-gem instead.

I missed that piece entirely... Un-ack.

Best regards,
Krzysztof