Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220721073909.23318-1-srinivas.neeli@xilinx.com> <CAMRc=Mefhk4i8_1j2=JO63SwfHEb3TrRMj45+CC1i1DUr8VULw@mail.gmail.com>
In-Reply-To: <CAMRc=Mefhk4i8_1j2=JO63SwfHEb3TrRMj45+CC1i1DUr8VULw@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 25 Jul 2022 22:04:47 +0200
Message-ID: <CAHp75Vdr3yM_b_8bDgAhNLrHUuyoq2nkVcj84wdvTzvLLetkNg@mail.gmail.com>
Subject: Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Srinivas Neeli <srinivas.neeli@xilinx.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Michal Simek <michal.simek@xilinx.com>,
        neelisrinivas18@gmail.com,
        Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
        srinivas.neeli@amd.com, Srinivas Goud <sgoud@xilinx.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        git <git@xilinx.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
> <srinivas.neeli@xilinx.com> wrote:
> >
> > Current implementation is not able to configure more than 32 pins
> > due to incorrect data type. So type casting with unsigned long
> > to avoid it.

> > Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs")

It doesn't fix anything,  I already reject one such "fix" during
development of this patch. Thanks!

...

> > @@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)
> >         const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);
> >
> >         map[index] &= ~(0xFFFFFFFFul << offset);
> > -       map[index] |= v << offset;
> > +       map[index] |= (unsigned long)v << offset;
> >  }

> Applied, thanks!

False positive.

-- 
With Best Regards,
Andy Shevchenko