Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp191989imn; Mon, 25 Jul 2022 13:38:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vsv0BSBIqnePlF2RJHneOTlxI9Qypxo7umw4GZSuwFDZPOJZcnsy6hlLPJgOPjhe3hKKYC X-Received: by 2002:a05:6402:1d54:b0:43b:e20b:4ff1 with SMTP id dz20-20020a0564021d5400b0043be20b4ff1mr12298192edb.385.1658781508483; Mon, 25 Jul 2022 13:38:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658781508; cv=none; d=google.com; s=arc-20160816; b=FwA8u8m8bIUG5dGZjJvib6Eq4EdngaewGdU47NVl0DgL9cXVpaOj9mYcVdJoTVNuPj j78FwXfCmDDSZK1Ts3ZOYiyiRsH5AEaEy6Pjau7nLc0Ot06IEg1v8gVbJMV7nTh1Q1G2 E15IhcSQvyUt0lq1g86hALlB+nrMJsQi78DsGMxua1SopP+n5v+nktXi39GdqT256KgK bNGdMXE9avFADsxGmUTm8D5vCQ+YCTSDb37cgYjDDHJ8Tkhqu4e+Zm3WFf6iLqebfnMq hjhX1qUkhmII74QcuBYQIURkbMdKUvopq7TV32o1LIZNdM+P7B1+YsFdw4jO3yKGzF34 foHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=OGiLPxDzhs5DzTm0Q7KOkKqc68yALSJCaG0MVt2d3Bo=; b=j1NiP3DFzF3wsfIZ5NEQSxAHPChLTa1ClxRLuKVaB1JXaIFZO6xmZH8A3tjIBeRV/W M92cKk6ahghN3UngOruti71dT5UunX4sfntYfuvH7qXem57s3rS/ZjaXEX3fEJTQjN1U KbGT/D6bms4bWroSFlQtG0/HpkmmcSEyFkizCpGYlgQwmuJYY/d8Kx7232S+7CsIxmMb UI30UsTTcCwMG0tUfP/EIHSn3ELnQPuRDfrlUek0MSaRwuMFvDiQx6lTXh71INjTEfA1 kLzHuW+C6u2G+6aSMe2itNYYMrWlhkB3Gf6Lp3gCl2UGZdfNkDkHF92exiVK9eJ6uSwd eYOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qSnjCxXc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q18-20020a056402519200b0043be95ef714si5774626edd.437.2022.07.25.13.38.04; Mon, 25 Jul 2022 13:38:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qSnjCxXc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237115AbiGYUaT (ORCPT + 99 others); Mon, 25 Jul 2022 16:30:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237089AbiGYUaQ (ORCPT ); Mon, 25 Jul 2022 16:30:16 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57EEC26F8; Mon, 25 Jul 2022 13:30:12 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id m8so15419849edd.9; Mon, 25 Jul 2022 13:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OGiLPxDzhs5DzTm0Q7KOkKqc68yALSJCaG0MVt2d3Bo=; b=qSnjCxXcMIEKC2hKuEYGjtRVQxfLdLQZPWamsT/EKIOGAuWBwJmmvkzPzDx+BU+qJ8 WQSQc+Qwwn8Ew7odBh8x1SZ6L6fLruTRZ8GJY0PyE5bQSURCk4ljqPT7GFTrPysBTb+C X9IGKgV0ClJ6a9zyHHEAWDREJlMNkp0p8BAzvbeRyX7hlvw1hWlYrD8wnNWQugb9V8kQ /vKkzaGj4wWA/e0Eygq/PDuJqFpVERl5fTa+2vn8K0/qWu1vR6iBgS6syJp0Fe+U8+hS p3M1E4tedPzj54EsAisKtedD2BWi3nVKFIBDHNfM3KhsHR2bPq1nOH/F/5UcgYV1Bqv7 0PSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OGiLPxDzhs5DzTm0Q7KOkKqc68yALSJCaG0MVt2d3Bo=; b=EbzduVrYFqH3Mw47XiXViJrwoQOxf+zXEut1WrvPVQ8qwKktZUw20PzxEoPCxBzKFR nXcmB6szEXY2TVnuaMxbUWTYC1pNuFLzGDeFKgDR0odLelET0edXnBArxFvKuyrGrfAS LBlLX+qpxoels0CTKkxXNs4j+yEOgq22TJZVy9BWjPP2r2YnwV53JCS/lcVXjHaTnSeE KB9udFoaNKQ+FpWEPtJIGZGgkIxfDBvTEpeu/I8JPkd6n4Ci0OP0fQDNiMF4RLZXlArL BJtzxaGdjYC6ra/Q/Kg54MMAxFQ3FDIEWGWwLmJUORqhFf5pBHkhYqqjjfCfsaN+GzmZ 0mRw== X-Gm-Message-State: AJIora9J2pucLIfFFMtHyk2HumXKqoKWEMHao11iJgk8E7TtDLWShG1a 7JQwizTeep/ZOs6ZI3Fa9sOoP1KeVh6BLYLuEhY= X-Received: by 2002:a05:6402:d53:b0:43b:a0cf:d970 with SMTP id ec19-20020a0564020d5300b0043ba0cfd970mr14632305edb.277.1658781010950; Mon, 25 Jul 2022 13:30:10 -0700 (PDT) MIME-Version: 1.0 References: <20220721073909.23318-1-srinivas.neeli@xilinx.com> In-Reply-To: From: Andy Shevchenko Date: Mon, 25 Jul 2022 22:29:34 +0200 Message-ID: Subject: Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow To: Bartosz Golaszewski Cc: Srinivas Neeli , Linus Walleij , Michal Simek , neelisrinivas18@gmail.com, Shubhrajyoti Datta , srinivas.neeli@amd.com, Srinivas Goud , "open list:GPIO SUBSYSTEM" , Linux ARM , Linux Kernel Mailing List , git Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2022 at 10:21 PM Andy Shevchenko wrote: > On Mon, Jul 25, 2022 at 10:04 PM Andy Shevchenko > wrote: > > On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski wrote: > > > On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli > > > wrote: ... > Reading again... You mean that > > unsigned long x = y << 32; > > wouldn't work? Yeah, I even checked this in asm, and indeed it doesn't work. Don't know what was that about me... Thanks for the fix, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko