Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1658597501.git.ang.iglesiasg@gmail.com> <0a99be89263c5e747d541360feede21b0f77e0a5.1658597501.git.ang.iglesiasg@gmail.com>
In-Reply-To: <0a99be89263c5e747d541360feede21b0f77e0a5.1658597501.git.ang.iglesiasg@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 25 Jul 2022 23:19:27 +0200
Message-ID: <CAHp75Vc+VzfTMJBv-eyYTENKuMGw=m4mpDvCXmKmVwcnnnz5Ag@mail.gmail.com>
Subject: Re: [PATCH v4 5/5] iio: pressure: bmp280: Add more tunable config
 parameters for BMP380
To:     Angel Iglesias <ang.iglesiasg@gmail.com>
Cc:     linux-iio <linux-iio@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Paul Cercueil <paul@crapouillou.net>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jul 23, 2022 at 7:40 PM Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>
> Allows sampling frequency and IIR filter coefficients configuration
> using sysfs ABI.
>
> The IIR filter coefficient is configurable using the sysfs attribute
> "filter_low_pass_3db_frequency".
>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>

> Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com> # uninit var

Bugs in new features can't have Reported-by tag.

If you wish to give credit, use a cover letter / changelog.

...

> +               /*
> +                * Configuration errors are detected on the fly during a measurement

The configurations

> +                * cycle. If the sampling frequency is too low, it's faster to reset
> +                * measurement loop than wait until next measurement is due.

the measurement
the next

> +                * Resets sensor measurement loop toggling between sleep and normal
> +                * operating modes.
> +                */

-- 
With Best Regards,
Andy Shevchenko