Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220724164316.68393-1-matti.lehtimaki@gmail.com>
In-Reply-To: <20220724164316.68393-1-matti.lehtimaki@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 25 Jul 2022 23:20:55 +0200
Message-ID: <CAHp75VeJtorTzV-dmxgJz+UD4gTWY1v67U0iU5nZ1pR36W9tMg@mail.gmail.com>
Subject: Re: [PATCH 1/2] iio: st_sensors: Retry ID verification on failure
To:     =?UTF-8?Q?Matti_Lehtim=C3=A4ki?= <matti.lehtimaki@gmail.com>
Cc:     linux-iio <linux-iio@vger.kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alexandru Ardelean <aardelean@deviqon.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Jul 24, 2022 at 6:54 PM Matti Lehtim=C3=A4ki
<matti.lehtimaki@gmail.com> wrote:
>
> Some sensors do not always start fast enough to read a valid ID from
> registers at first attempt. Let's retry at most 3 times with short sleep
> in between to fix random timing issues.

...

> +               for (i =3D 0; i < VERIFY_ID_RETRY_COUNT; i++) {
> +                       err =3D regmap_read(sdata->regmap,
> +                                         sdata->sensor_settings->wai_add=
r, &wai);
> +
> +                       if (!err && sdata->sensor_settings->wai =3D=3D wa=
i)
> +                               return 0;
> +
> +                       msleep(20);

NIH regmap_read_poll_timeout()


> +               }

--=20
With Best Regards,
Andy Shevchenko