Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762986AbXFEGNb (ORCPT ); Tue, 5 Jun 2007 02:13:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757523AbXFEGNX (ORCPT ); Tue, 5 Jun 2007 02:13:23 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35339 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755943AbXFEGNW (ORCPT ); Tue, 5 Jun 2007 02:13:22 -0400 Date: Tue, 5 Jun 2007 07:13:15 +0100 From: Christoph Hellwig To: Vasily Averin Cc: Andrew Morton , Linux Kernel Mailing List , devel@openvz.org, linux-ext4@vger.kernel.org, Stephen Tweedie , adilger@clusterfs.com Subject: Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode Message-ID: <20070605061315.GA25760@infradead.org> Mail-Followup-To: Christoph Hellwig , Vasily Averin , Andrew Morton , Linux Kernel Mailing List , devel@openvz.org, linux-ext4@vger.kernel.org, Stephen Tweedie , adilger@clusterfs.com References: <4663A0CE.102@sw.ru> <20070604190340.dba85bb0.akpm@linux-foundation.org> <4664FE80.4080801@sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4664FE80.4080801@sw.ru> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 17 On Tue, Jun 05, 2007 at 10:11:12AM +0400, Vasily Averin wrote: > >> return d_splice_alias(inode, dentry); > >> } > > Seems reasonable. So this prevents the bad inodes from getting onto the > > orphan list in the first place? > > make_bad_inode() is called from ext3_read_inode() that is called from iget() only. Which is artefact of using the read_inode interface. Please switch from iget to iget_locked and you can handle this case without ever inserting the "bad" inode into the inode hash. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/