Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 16:32:24 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Darrick J. Wong" <djwong@kernel.org>,
        Li Jinlin <lijinlin3@huawei.com>
CC:     <viro@zeniv.linux.org.uk>, <dan.j.williams@intel.com>,
        <willy@infradead.org>, <jack@suse.cz>,
        <linux-fsdevel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <linfeilong@huawei.com>,
        <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH] fsdax: Fix infinite loop in dax_iomap_rw()
Message-ID: <62df2808e5c50_1f5536294f2@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220725032050.3873372-1-lijinlin3@huawei.com>
 <Yt8Hw2cXPz1ScQ1y@magnolia>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Yt8Hw2cXPz1ScQ1y@magnolia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j2nQKtd0Hgp5DGOEkLw/e4YwCr46NfVmoXmNtCllCzFWJ42NpVWwmPKM0dgb?=
 =?us-ascii?Q?QVHbGyqjc2m19kDqOUluIBFN09R9eto5LNJCHeZgl3tN55pO5eX2SinpeVdx?=
 =?us-ascii?Q?OoTdPNPj8/RCJ2T3C/U3ecPKQ0y0+vIRhRA2iJCOvtjJvUFHPc/hlrtaGc5Y?=
 =?us-ascii?Q?ZYvQm2vvfVTwa3FwfpfR4WGlVDXFa8U6lmQkFyPgD9+03jHeFgtm/x6+F+BO?=
 =?us-ascii?Q?0f63BOVyOHyIGG2QVlNodhYoT6JscUpbfUEEgslUFwNHeuq4SaGf15YZea0W?=
 =?us-ascii?Q?wlADYXain1BM3Seutg73kCroR0BoYqeSDa1gngD6qTNpq+nnKLKMCAjdIBvW?=
 =?us-ascii?Q?KlG2R01Oc4Vttx1WlKxPh7mdwzYfLqUBGq72Y2ICL9nts9L6/IXGF5rbBBRz?=
 =?us-ascii?Q?LvfCqoqFOXUOrfZd2QTM49BI5xHMwu9/GfJWOoq5Pacn1ipj+I93bAQaVHlp?=
 =?us-ascii?Q?zTLdd/U+XPUR5JZ+0+DRxa+ZU66wP5AHOxcj15k6YZOaqI4Z7csbfXFiGpQt?=
 =?us-ascii?Q?rAYmiLsWUETVkHoJKD9izfUvIk5FCW7mWY0WR6H2s2y7ZBk9vlSeIMjeS+PP?=
 =?us-ascii?Q?urR4pXKF9wezznGsGuBf69NvDxc4Ynyx8jrmRQwPpDD0drc9WeN89IVYchQN?=
 =?us-ascii?Q?IquV/z0T346DDhNJhqqpeUAV67ENROEwUHzjeCNjjNIB50KoUqqaSs+7CeK6?=
 =?us-ascii?Q?awZk0ikdoFQCE3v8dmWDtvM/+sc8J8nrDq//oFjHo+1XzGA6iHlsbTm1BSI8?=
 =?us-ascii?Q?cQEYiBfQ4TQTAytMq06Yn+maECj5+RIgv/ZEF81V3I+PenVsEihV+3I6T5uM?=
 =?us-ascii?Q?gueTKw8zsyhD6M9hk3fZ7ruqQNooqJEaKAOGlyTNAdH033NgxvhjbHy3/L/0?=
 =?us-ascii?Q?buVLo4gW3vForEs88gFL4k7/XVj+LZ5Wyv8ow2QbMnb8FjLDibS94QV+bwcQ?=
 =?us-ascii?Q?Uc669hUwa7kJ7aa+liX62az1aYkKC5poeO5hTQVMcv82Mco0R4IGxCXCXnRD?=
 =?us-ascii?Q?7+mnaYLsIAnjSU1Gj+2AxooJHu2+tr3FoTa3GWqfBLdLJXM9gD1OIT2XCJU/?=
 =?us-ascii?Q?HZKt1lp8W8cmwlNii9maafHWKaWfStuiuccyPCvRMpsdN5j6kvkZZJQIGrxy?=
 =?us-ascii?Q?fThtLUlAv272TrGO43TfFFs+WKS60XVw0SBsNn0GUKqxJZASJE1r72NrzNXj?=
 =?us-ascii?Q?+LV3gOy/kEz8mXjoQ72LwDjsMUM0ArMyzkCJBtOoJESHszzQ47PY0USPEZyk?=
 =?us-ascii?Q?adtKh4jYiYebMSHS8d/3bJKQ4BAaPmJqLELIZaDhQa54JFavxrpixFNJUgac?=
 =?us-ascii?Q?4tFozVh+hAiLF5vviOsTh8qtZMGI1cifg3q0Rm4dWPAA2EGoxHwSEHV3KSFm?=
 =?us-ascii?Q?4ilw0v4qOWmD3zuChyxorGEVNAemjfFlwYIJuo1CVbIAQtNp5indGE6YugJD?=
 =?us-ascii?Q?Eequ8KiUY6mModD7SZG6oyFJ79AqTyG5rIR+fq9XDX2huShPVNhNaKfHX9me?=
 =?us-ascii?Q?LM43qoddh38A7GfY6cKnKyL1UyWhEd73AXJapByBN+2URAZIKsiQ0+Yn+Pxe?=
 =?us-ascii?Q?1iQjmc1Zd/4EGTksB+oVrvk2uQ5C8jjZQDqxK5/E8oIhVeOZneJdUdIJUbjj?=
 =?us-ascii?Q?6w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a8b23289-82a4-4be1-ea57-08da6e95efdb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 23:32:28.1258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 77GC/SbHKUxsXVchG1MiI8uIknJSPgflXmKhysF4Dha1LYHAvOdf6O3xTDpuWMwH/wLpCS6/evgi8YbEmpR4etu484dbsNbolrg1rXAS6Mk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4317
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Darrick J. Wong wrote:
> On Mon, Jul 25, 2022 at 11:20:50AM +0800, Li Jinlin wrote:
> > I got an infinite loop and a WARNING report when executing a tail command
> > in virtiofs.
> > 
> >   WARNING: CPU: 10 PID: 964 at fs/iomap/iter.c:34 iomap_iter+0x3a2/0x3d0
> >   Modules linked in:
> >   CPU: 10 PID: 964 Comm: tail Not tainted 5.19.0-rc7
> >   Call Trace:
> >   <TASK>
> >   dax_iomap_rw+0xea/0x620
> >   ? __this_cpu_preempt_check+0x13/0x20
> >   fuse_dax_read_iter+0x47/0x80
> >   fuse_file_read_iter+0xae/0xd0
> >   new_sync_read+0xfe/0x180
> >   ? 0xffffffff81000000
> >   vfs_read+0x14d/0x1a0
> >   ksys_read+0x6d/0xf0
> >   __x64_sys_read+0x1a/0x20
> >   do_syscall_64+0x3b/0x90
> >   entry_SYSCALL_64_after_hwframe+0x63/0xcd
> > 
> > The tail command will call read() with a count of 0. In this case,
> > iomap_iter() will report this WARNING, and always return 1 which casuing
> > the infinite loop in dax_iomap_rw().
> > 
> > Fixing by checking count whether is 0 in dax_iomap_rw().
> > 
> > Fixes: ca289e0b95af ("fsdax: switch dax_iomap_rw to use iomap_iter")
> > Signed-off-by: Li Jinlin <lijinlin3@huawei.com>
> 
> Huh, I didn't know FUSE supports DAX and iomap now...

Yeah, it came in via DAX support for virtio-fs.

> > ---
> >  fs/dax.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/fs/dax.c b/fs/dax.c
> > index 4155a6107fa1..7ab248ed21aa 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -1241,6 +1241,9 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter,
> >  	loff_t done = 0;
> >  	int ret;
> >  
> > +	if (!iomi.len)
> > +		return 0;
> 
> Hmm, most of the callers of dax_iomap_rw skip the whole call if
> iov_iter_count(to)==0, so I wonder if fuse_dax_read_iter should do the
> same?
> 
> That said, iomap_dio_rw bails early if you pass it iomi.len, so I don't
> have any real objections to this.

That was the same conclusion I came to...

> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thanks, will get this merged up for v5.19-final.