Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a103b0a3-2137-c7c9-9999-88b28f03c312@huawei.com>
Date:   Tue, 26 Jul 2022 11:22:59 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH -next] ACPI/IORT: Fix build error
 implicit-function-declaration
To:     Hanjun Guo <guohanjun@huawei.com>,
        Shameerali Kolothum Thodi 
        <shameerali.kolothum.thodi@huawei.com>,
        "lpieralisi@kernel.org" <lpieralisi@kernel.org>,
        "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "jroedel@suse.de" <jroedel@suse.de>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>
CC:     "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lorenzo.pieralisi@linaro.org" <lorenzo.pieralisi@linaro.org>
References: <20220724115423.212932-1-renzhijie2@huawei.com>
 <d59bc043788e4dc796a445588d667ab7@huawei.com>
 <078d74b2-151e-4b4a-55fc-9cd8f6fb910c@huawei.com>
From:   Ren Zhijie <renzhijie2@huawei.com>
In-Reply-To: <078d74b2-151e-4b4a-55fc-9cd8f6fb910c@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/7/26 10:53, Hanjun Guo 写道:
> On 2022/7/25 21:50, Shameerali Kolothum Thodi wrote:
> [...]
>>>
>>> If CONFIG_ACPI_IORT=y and CONFIG_IOMMU_API is not set,
>>> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-, will be failed, like
>>> this:
>>>
>>> drivers/acpi/arm64/iort.c: In function ‘iort_get_rmr_sids’:
>>> drivers/acpi/arm64/iort.c:1406:2: error: implicit declaration of 
>>> function
>>> ‘iort_iommu_rmr_get_resv_regions’; did you mean
>>> ‘iort_iommu_get_resv_regions’? [-Werror=implicit-function-declaration]
>>>    iort_iommu_rmr_get_resv_regions(iommu_fwnode, NULL, head);
>>>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>    iort_iommu_get_resv_regions
>>> cc1: some warnings being treated as errors
>>> make[3]: *** [drivers/acpi/arm64/iort.o] Error 1
>>
>> Thanks for spotting this.
>>
>>> The function iort_iommu_rmr_get_resv_regions() is declared at #ifdef
>>> CONFIG_IOMMU_API area, and the callers of  iort_get_rmr_sids() and
>>> iort_put_rmr_sids() would select IOMMU_API.
>>> To fix this error, move the definitions to #ifdef CONFIG_IOMMU_API 
>>> area.
>>
>> That makes sense. And the only callers of these are SMMU drivers I 
>> think we
>> don't need stub functions under !CONFIG_IOMMU_API(Lorenzo, could you
>> please double check this).
>
> I think so, because SMMU drivers will select IOMMU_API,
> in drivers/iommu/Kconfig, it says:
>
> # IOMMU_API always gets selected by whoever wants it.
> config IOMMU_API
> bool
>
>>
>> Nit: Please wrap the commit description to a max of 75 chars per line.
>
> Zhijie, would you mind send a updated version?
>
sure, will send patch v2.

Thanks,

Ren Zhijie

> Thanks
> Hanjun
> .