Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp475577imn; Tue, 26 Jul 2022 00:21:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vLnaPAK6wM7R/DXOnWIpqHDrE/luS0XPbeACBlk9I3c9TegG5iwRhUtu1t23ZAqLHFXt7+ X-Received: by 2002:aa7:82ca:0:b0:51b:cf43:d00a with SMTP id f10-20020aa782ca000000b0051bcf43d00amr16268287pfn.58.1658820087110; Tue, 26 Jul 2022 00:21:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658820087; cv=none; d=google.com; s=arc-20160816; b=cPPio+qB/CQCQNym8GobPMHVHcw/iQBLwwlisd1MZNY5xut2wIRGgIRO7glWk+OGEE c8+M9NzdojTLP9ErbIZsn/ho4zFuYoERGLtdOsjc2NCynrw44sKuISJrGea6BPvjXxfZ rFcblzm97BURFB0rwExRmKy1z9R2SMzciEbFpRX9/R6Vk5LxZrhsIhrFQzfPdFII2rLU Hnc6pqvRqwnLeMeouWZsKTs5JANQhWoZs2A62cfOlF6St7Xj3Xmr1nS1BXNs6X3QRSGl 9oZTgsxgblv1z9Sp0cSAVKWB07D/czueZfoLx1RcgR6csf3yF1B6flPiWMxH5OVmLefy Ss0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=3+FnwFS0GYSYbUam7H7Az8qx0wLXzAKwOlGiZrqT4TM=; b=e5eTCVeQg1FjR1Iceds6MgtF/a+DM1+FZc3z6DB06zg1BAn4ijNvDlzpB7kvXcm09a ecOyGbmMJNDfKlYMBWS1jXagCcaqHMTu/561Ld8XK918RmibjLNXJnwDijpNZFFxwpGN oxF5cFyW8NARqn08vijPNFAguOTKMsmHIdXeciBXe0gJman8Kmo99CEik1j/+HrowEX/ Mae060fa0vc35c+E73R4h+oEJJDiBhTfzuF3+qiYOyJotWzKdpa7dCCnGKNjAlF4IVnK gPah0xs0s8MsAA2yimNEdrcy7Ju6CpQNaYuYyfvqrY3QkkD4lMSTF7Cs0AdPNt7ew4DN nzGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x28-20020a637c1c000000b0040d9ebed1c6si16150082pgc.806.2022.07.26.00.21.11; Tue, 26 Jul 2022 00:21:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231689AbiGZHQC (ORCPT + 99 others); Tue, 26 Jul 2022 03:16:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230339AbiGZHQB (ORCPT ); Tue, 26 Jul 2022 03:16:01 -0400 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F97D6585 for ; Tue, 26 Jul 2022 00:16:01 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 7133E669; Tue, 26 Jul 2022 09:15:59 +0200 (CEST) Date: Tue, 26 Jul 2022 09:15:58 +0200 From: Joerg Roedel To: Michael Kelley Cc: sthemmin@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, will@kernel.org, robin.murphy@arm.com, samuel@sholland.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH 1/1] iommu/hyper-v: Use helper instead of directly accessing affinity Message-ID: References: <1658796820-2261-1-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1658796820-2261-1-git-send-email-mikelley@microsoft.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Mon, Jul 25, 2022 at 05:53:40PM -0700, Michael Kelley wrote: > Recent changes to solve inconsistencies in handling IRQ masks #ifdef > out the affinity field in irq_common_data for non-SMP configurations. > The current code in hyperv_irq_remapping_alloc() gets a compiler error > in that case. > > Fix this by using the new irq_data_update_affinity() helper, which > handles the non-SMP case correctly. > > Signed-off-by: Michael Kelley Please add a fixes tag. Where is the change which breaks this currently, in some subsystem tree or already upstream? In case it is still in a maintainers tree, this patch should be applied there. Here is my Acked-by: Joerg Roedel for that.