Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 08:26:43 +0100
Message-ID: <87y1wgbah8.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     <Conor.Dooley@microchip.com>
Cc:     <helgaas@kernel.org>, <pali@kernel.org>, <johan+linaro@kernel.org>,
        <kishon@ti.com>, <songxiaowei@hisilicon.com>,
        <wangbinghui@hisilicon.com>, <thierry.reding@gmail.com>,
        <ryder.lee@mediatek.com>, <jianjun.wang@mediatek.com>,
        <linux-pci@vger.kernel.org>, <kw@linux.com>,
        <ley.foon.tan@intel.com>, <linux-kernel@vger.kernel.org>,
        <Daire.McNamara@microchip.com>
Subject: Re: Why set .suppress_bind_attrs even though .remove() implemented?
In-Reply-To: <e3fb313a-f634-3429-05ea-ebaa98809c71@microchip.com>
References: <20220721222122.GA1754784@bhelgaas>
        <20220722143905.GA1818909@bhelgaas>
        <87k085xekg.wl-maz@kernel.org>
        <e3fb313a-f634-3429-05ea-ebaa98809c71@microchip.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 25 Jul 2022 18:49:05 +0100,
<Conor.Dooley@microchip.com> wrote:
> 
> Sorry to butt back in here - but I am taking this to mean that rather
> than add a remove callback for the microchip pci controller driver when
> making it buildable as a module it would instead be better to forgo that
> entirely and prevent unloading the module (since it does INTX & MSI).
> 
> Would that be an accurate assessment?

Yes.

	M.

-- 
Without deviation from the norm, progress is not possible.