Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7770401d-fe3d-bda4-a2e2-55cd004a2d07@suse.com>
Date:   Tue, 26 Jul 2022 09:48:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v5] watchdog: add driver for StreamLabs USB watchdog
 device
Content-Language: en-US
To:     Alexey Klimov <klimov.linux@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
        Guenter Roeck <linux@roeck-us.net>,
        Oliver Neukum <oneukum@suse.com>,
        USB list <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        atishp@rivosinc.com, atishp@atishpatra.org,
        Yury Norov <yury.norov@gmail.com>,
        Alexey Klimov <aklimov@redhat.com>,
        Aaron Tomlin <atomlin@redhat.com>
References: <20220725030605.1808710-1-klimov.linux@gmail.com>
 <Yt5Zn9cXDe9/F9RJ@kroah.com>
 <CALW4P+Kd_XdvzGfA=Cmtu0c=kEHfhp2pph2Wh0Sa8Fm8GxDRTA@mail.gmail.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <CALW4P+Kd_XdvzGfA=Cmtu0c=kEHfhp2pph2Wh0Sa8Fm8GxDRTA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1RnWndCQTl6KzNUWXJMdmh5bzBHM3dWS3ZHNWF2NGRRMVhkVFJRcjF3V1VI?=
 =?utf-8?B?bi9oQ2lkV2J2S1hlSHFGYWhTNitUMHdvakdHOHJTODlJMEJIMTE2Q1h6dlh5?=
 =?utf-8?B?TUE0RHBEaU1HSUxET2dyUHR5aCtoQ2ZLbTZuR00wajNWenUvdloxWklRZUt4?=
 =?utf-8?B?cFRjQUdPaURsaUFNU2cyTHdndlFNamFyOWRXTzhTclpmMFpiVkxCZ1NidTNG?=
 =?utf-8?B?M3h3a0ZkdS96RlRsNlE3MlhZR0grbEtVODNiUE43dEI1TlJRTHFueXlSdnh4?=
 =?utf-8?B?Z3dBdm9Mb0o1OVFVTlQwWkRWLy8vamhYVlVlbnY1TnE3ZGlWVUdnU2FlUVdv?=
 =?utf-8?B?VGh4blBRLzVQajdoUzZNRkNLL1Yxcm1CZnIxSU93eGFCekVTRy8wVmdJa1dE?=
 =?utf-8?B?WXdlYXhld1RCYlltVCtFa3kzb051L0pzNkh4MXdGc1RjaWFwVzRPKzVES01s?=
 =?utf-8?B?TWp0UWlndzFmcUVkNWVXL21TdUMwKzkrdU9tMFV5RjFRa29Rb1Y5V3pWaHlE?=
 =?utf-8?B?Y1IxcEpyZEJvUCtUVVYxWktsNWh0eEdhR3cyVGhGU093Q25wQ3p2aEs5ZTRV?=
 =?utf-8?B?cE5mOTZEZUpvZU1yamVCWmo3TVpUcFBnbGtOOXVFMXVJbVBxN2hzZGtKNnBs?=
 =?utf-8?B?eVNKUVVoMk14Y3BYakF0SWx2UHAzd0JwR3pMZzRJcDlvU0VmRVRKU3dDdW8w?=
 =?utf-8?B?NU1QTGc1L2ZITVUvTkYrMSs3YklnL3hWSS9Pdlprd2dGZEMzaEV2RnFjUGF0?=
 =?utf-8?B?NklqOVRMamRuSUR5ajlmanBFcTkrWWErWnB6UU5hd1RoMUpPRHpsVDN4UUJQ?=
 =?utf-8?B?Z2ZXdEo3UlFxUHhXTHhEZEN5TWtPSy84Q09JVVQyVWp1OUFDYTR5ZUF4TC9U?=
 =?utf-8?B?d29GRU05NEc5cGxiT0E5dEZVcFN5aFZTSmd0SUw3cWFUcXJrNUpWa2wwSk84?=
 =?utf-8?B?R0d3TlFiS3FUTFZZRElMR0VPNS84aWpwSjZpQnpiU1dKZm9rNGt0MmRtV2o0?=
 =?utf-8?B?cXhQZmRhMjhnbG1CTjBtTUNEb3dBbG9Ba3M1N2dOU2hQQlJZR0doS0RvV0xH?=
 =?utf-8?B?ZXBnS0RiK2xnMWJ2Y2l2bEh2ZUVoRlQwbFA2UHd6VitSMjlwb2grYWJSVWZ3?=
 =?utf-8?B?VFNtOXFQWkJDWEFTZlEyWXpTd3NZZStUMmI5dE0yYUlMakJVdURNTGd5RnRG?=
 =?utf-8?B?aWUwb2VHWUFOQTM2SVN4Ym5XNXVPcy9IbjVtRU1LTzN1dnNHK1NtOG5QTzd1?=
 =?utf-8?B?a05qS1ViRmxJTCt0OTZ5L2hQRFJUZW5wdFk2dldXd0ZabzBIU21MdEV6aDRN?=
 =?utf-8?B?MU9DTTNkTmN6MFlMSmJmMG5JMU9SK3Q4Z2RVbDJ3WmJ5UXRseitPWE5ZYXVZ?=
 =?utf-8?B?cCtSUmpiRW1tUzVlYkdtRHhPMVlKclNFUzQ1TDgwTHpUdzBzS2xRSy9zSHNC?=
 =?utf-8?B?R3M1dUlkZVZpYnNNMEtzNk0xOGpkYkFTQ3ZoVzZ4SkJHZWNhdmExMjJ3ZVVS?=
 =?utf-8?B?ZlpVYnI2RXE0enMvYzZKbHhoVHpTT0hiUFJnSTdtZERHSnA1TEhZWitOMHpo?=
 =?utf-8?B?azNKZUdIODhUSEdDYmZ2SGN2TldDb2ZpQUVBVXFZWTZtcFpzZnh1RWp0dFU5?=
 =?utf-8?B?SFJpUEs1UGdRUHVCUEtPNkpOK2JtM0REN1dNMlQvek1DQ09WdEhMbC9lUjNB?=
 =?utf-8?B?dVZrZEw1M1FjcWlaQ1FhQWVMNkRnbHZZWUJ3QUhyeHhnendRamZVa1hPK2xP?=
 =?utf-8?B?aWRMODBaNG5GNzhtODlsWEJyajdxVlpyOFZNSVNnSlJoTFJoREF2YkczWVpF?=
 =?utf-8?B?K1FiYkZaR1VMVmtQTThRcTV5UGgvQ2dkREpTZmZMTkw0SG8vUkY5bzdxMG5r?=
 =?utf-8?B?dGlQT2M3cmZMOUxKT3N1NXdMaTF6Zzl3Zzg3UklLZUg2bStvQ3pEL0pBQVVM?=
 =?utf-8?B?bkMzTGErOE9ablFnMk9EVUEvYVUyaUxpenU1eU9tVXVaZHFGS3ZDRk14K3Z0?=
 =?utf-8?B?QzZzOFhzV2lPMVpVZ05sTGdiYmN2TFMwWWtuVUZlYlVZbmZ1QXpIUFRURG9r?=
 =?utf-8?B?dGhRRmxTUGVIU0tDWWxCVkp1MVMyYko0OENGeEk0K3VmazlpY3hTdFJYdk9Z?=
 =?utf-8?B?Y1lMMkZzY3hiMnNzbGtMNTNXenZReGNocE5taGU0Q3hPcThwUDlQT2xsOGZk?=
 =?utf-8?Q?a47v1xK3Kv5CQQrKYMbKpp2OKwjJin4+k+4P5lCCBgAQ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d368b459-029b-419e-e36d-08da6edb3804
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 07:48:24.6208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kYShPd6b+mIvNjxsXoVRX39Un3RDGyDXp9BHl3HXulcWibbeQhEobhBfdCCatWkZSnvp1SgNFltxqPvZ/e3+Lg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8636
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 26.07.22 02:21, Alexey Klimov wrote:
> On Mon, Jul 25, 2022 at 9:51 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>>
>> On Mon, Jul 25, 2022 at 04:06:05AM +0100, Alexey Klimov wrote:
> 
> [..]
> 
>> Anyway, driver looks good to me, nice work!
>>
>> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Thanks, Greg. If you don't mind I'll use your tag in next version
> after making changes suggested by Guenter since there will be no
> significant functional changes. If code will change a lot, then the
> process (Documentation/process/submitting-patches.rst) will require me
> to drop the tag.

Hi,

while thinking about this a question arose. How does this
device react to a USB reset? A watchdog that can be disabled
by a simple reset does not like very reliable to me.
Do you need to implement pre/post_reset() ?

	Regards
		Oliver