Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <70afefa0-2f18-c8c0-33cd-f6abd4010535@gmx.de>
Date:   Tue, 26 Jul 2022 10:27:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] parisc: check the return value of ioremap() in
 lba_driver_probe()
Content-Language: en-US
To:     williamsukatube@163.com, James.Bottomley@HansenPartnership.com,
        linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     William Dean <williamsukatube@gmail.com>,
        Hacash Robot <hacashRobot@santino.com>
References: <20220722025709.2924616-1-williamsukatube@163.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220722025709.2924616-1-williamsukatube@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 7/22/22 04:57, williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@gmail.com>
>
> The function ioremap() in lba_driver_probe() can fail, so
> its return value should be checked.
>
> Fixes: 4bdc0d676a643 ("remove ioremap_nocache and devm_ioremap_nocache")
> Reported-by: Hacash Robot <hacashRobot@santino.com>
> Signed-off-by: William Dean <williamsukatube@gmail.com>

applied.

Thanks!
Helge

> ---
>  drivers/parisc/lba_pci.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
> index 732b516c7bf8..afc6e66ddc31 100644
> --- a/drivers/parisc/lba_pci.c
> +++ b/drivers/parisc/lba_pci.c
> @@ -1476,9 +1476,13 @@ lba_driver_probe(struct parisc_device *dev)
>  	u32 func_class;
>  	void *tmp_obj;
>  	char *version;
> -	void __iomem *addr =3D ioremap(dev->hpa.start, 4096);
> +	void __iomem *addr;
>  	int max;
>
> +	addr =3D ioremap(dev->hpa.start, 4096);
> +	if (addr =3D=3D NULL)
> +		return -ENOMEM;
> +
>  	/* Read HW Rev First */
>  	func_class =3D READ_REG32(addr + LBA_FCLASS);
>