Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 12:25:42 +0200
From:   Jan Kara <jack@suse.cz>
To:     Xiu Jianfeng <xiujianfeng@huawei.com>
Cc:     akpm@linux-foundation.org, jack@suse.cz, neilb@suse.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] bdi: remove enum wb_congested_state
Message-ID: <20220726102542.fnf37ypbbhnudonj@quack3>
References: <20220719083349.87547-1-xiujianfeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220719083349.87547-1-xiujianfeng@huawei.com>
Precedence: bulk

On Tue 19-07-22 16:33:49, Xiu Jianfeng wrote:
> enum wb_congested_state and the member 'congested' in bdi_writeback is
> useless since commit a88f2096d5a2 ("remove congestion tracking framework"),
> so remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/backing-dev-defs.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
> index e863c88df95f..ae12696ec492 100644
> --- a/include/linux/backing-dev-defs.h
> +++ b/include/linux/backing-dev-defs.h
> @@ -28,11 +28,6 @@ enum wb_state {
>  	WB_start_all,		/* nr_pages == 0 (all) work pending */
>  };
>  
> -enum wb_congested_state {
> -	WB_async_congested,	/* The async (write) queue is getting full */
> -	WB_sync_congested,	/* The sync queue is getting full */
> -};
> -
>  enum wb_stat_item {
>  	WB_RECLAIMABLE,
>  	WB_WRITEBACK,
> @@ -122,8 +117,6 @@ struct bdi_writeback {
>  	atomic_t writeback_inodes;	/* number of inodes under writeback */
>  	struct percpu_counter stat[NR_WB_STAT_ITEMS];
>  
> -	unsigned long congested;	/* WB_[a]sync_congested flags */
> -
>  	unsigned long bw_time_stamp;	/* last time write bw is updated */
>  	unsigned long dirtied_stamp;
>  	unsigned long written_stamp;	/* pages written at bw_time_stamp */
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR