Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAFCwf13JA+5vuAKqvBSs3MkcF-gbE_8vd9nSvStQga55vW80VA@mail.gmail.com>
 <20220725065308.2457024-1-jiho.chu@samsung.com> <Yt5cFBgiTLwGXv17@kroah.com>
 <CGME20220725065308epcas1p2f6de3d74792854bb312cca4b310badac@epcms1p5>
 <20220726020952epcms1p59c06fabb55776e195dcbeac549c98ef7@epcms1p5>
 <8b69b813-d030-2666-37f1-a731b1d52f4e@linaro.org> <CAK8P3a3xhAcokq1p0_PzK2JzR9BGNcaohA_nan9nS9NioW4_rQ@mail.gmail.com>
In-Reply-To: <CAK8P3a3xhAcokq1p0_PzK2JzR9BGNcaohA_nan9nS9NioW4_rQ@mail.gmail.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Tue, 26 Jul 2022 14:24:03 +0300
Message-ID: <CAFCwf13uLM3kr20dBZV3u3xLwwMXdt=7p7y9HhR+ocknsz=cLA@mail.gmail.com>
Subject: Re: [PATCH 0/9] Samsung Trinity NPU device driver
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Jiho Chu <jiho.chu@samsung.com>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        Yelin Jeong <yelini.jeong@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 26, 2022 at 10:51 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, Jul 26, 2022 at 8:59 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 26/07/2022 04:09, MyungJoo Ham wrote:
> > >> Hi,
> > >> Why isn't this submitted to soc/ subsystem ?
> > >> Don't you think that would be more appropriate, given that this IP is
> > >> integrated into application processors ?
> > >>
> > >> Thanks,
> > >> Oded
> > >
> > > This series (Trinity-V2.3, V2.4, A1, ..) is being integrated to multiple SoCs,
> > > not limited to Samsung-designed chips (e.g., Exynos).
> > > It's a bit weird to have them in /drivers/soc/samsung.
> > >
> > > CC: Krzysztof and Alim (Samsung-SoC maintainers)
> >
> > If it is not related to Samsung SoCs (or other designs by Samsung
> > Foundry), then it should not go to drivers/soc. Based on cover letter,
> > it looks this is the case.
>
> Agreed, and I also don't want to add any drivers with a user interface
> to drivers/soc/. The things we have in there mainly fall into two categories:
>
>  - soc_device drivers for identifying the SoC itself from userspace or
>    another driver
>
>  - drivers that provide exported symbols to other kernel drivers for things
>    that do not have a proper subsystem abstraction (yet).
>
> This driver clearly does not fall into those categories. As long as there
> is no subsystem for NPUs, the only sensible options are drivers/gpu
> and drivers/misc/.
>
>      Arnd

Thanks for the explanation, I wasn't sure what the criteria for
getting into drivers/soc is,
but now it is clear.

Oded