Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 2/5] ARM: stacktrace: Avoid duplicate saving of exception
 PC value
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
CC:     <ardb@kernel.org>, <will@kernel.org>, <mark.rutland@arm.com>,
        <broonie@kernel.org>, <peterz@infradead.org>, <mingo@redhat.com>,
        <acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
        <jolsa@kernel.org>, <namhyung@kernel.org>, <arnd@arndb.de>,
        <linus.walleij@linaro.org>, <rostedt@goodmis.org>,
        <nick.hawkins@hpe.com>, <john@phrozen.org>, <mhiramat@kernel.org>,
        <ast@kernel.org>, <linyujun809@huawei.com>,
        <ndesaulniers@google.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-perf-users@vger.kernel.org>
References: <20220712021527.109921-1-lihuafei1@huawei.com>
 <20220712021527.109921-3-lihuafei1@huawei.com>
 <Yt/AawOdA8w24toW@shell.armlinux.org.uk>
From:   Li Huafei <lihuafei1@huawei.com>
Message-ID: <c16ad370-4157-7315-eaca-efd884359c05@huawei.com>
Date:   Tue, 26 Jul 2022 20:21:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <Yt/AawOdA8w24toW@shell.armlinux.org.uk>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/7/26 18:22, Russell King (Oracle) wrote:
> On Tue, Jul 12, 2022 at 10:15:24AM +0800, Li Huafei wrote:
>> @@ -34,6 +37,9 @@ void arm_get_current_stackframe(struct pt_regs *regs, struct stackframe *frame)
>>  		frame->kr_cur = NULL;
>>  		frame->tsk = current;
>>  #endif
>> +#ifdef CONFIG_UNWINDER_FRAME_POINTER
>> +		frame->ex_frame = in_entry_text(frame->pc) ? true : false;
> 
> in_entry_text() returns a bool, so there's no need for the ternary
> operator. The same comment applies throughout this patch.
> 
OK, I will fix it in v3.

Thanks,
Huafei