Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <621714a3-f3fd-e9de-c072-0fef3ad76288@redhat.com>
Date:   Tue, 26 Jul 2022 15:05:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] mm: use is_zone_movable_page() helper
Content-Language: en-US
To:     Kefeng Wang <wangkefeng.wang@huawei.com>,
        Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Cc:     Jason Wang <jasowang@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
References: <20220726131135.146912-1-wangkefeng.wang@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20220726131135.146912-1-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26.07.22 15:11, Kefeng Wang wrote:
> Use is_zone_movable_page() helper to simplify code.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/virtio/virtio_mem.c | 6 ++----
>  mm/memory_hotplug.c         | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index e07486f01999..0c2892ec6817 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm,
>  					 unsigned long mb_id,
>  					 unsigned long start_pfn)
>  {
> -	const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) ==
> -				ZONE_MOVABLE;
> +	const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn));
>  	int new_state;
>  
>  	switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) {
> @@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages)
>   */
>  static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages)
>  {
> -	const bool is_movable = page_zonenum(pfn_to_page(pfn)) ==
> -				ZONE_MOVABLE;
> +	const bool is_movable = is_zone_movable_page(pfn_to_page(pfn));
>  	int rc, retry_count;
>  
>  	/*
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 1213d0c67a53..0f5914964a32 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid,
>  			if (!page)
>  				continue;
>  			/* If anything is !MOVABLE online the rest !MOVABLE. */
> -			if (page_zonenum(page) != ZONE_MOVABLE)
> +			if (!is_zone_movable_page(page))
>  				goto kernel_zone;
>  			online_pages += PAGES_PER_SECTION;
>  		}


Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb