Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 16:35:59 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Phillip Potter <phil@philpotter.co.uk>
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        paskripkin@gmail.com, straube.linux@gmail.com, martin@kaiser.cx,
        abdun.nihaal@gmail.com, philipp.g.hortmann@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: convert rtw_pwr_wakeup to correct
 error code semantics
Message-ID: <20220726133559.GP2338@kadam>
References: <20220725220745.12739-1-phil@philpotter.co.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220725220745.12739-1-phil@philpotter.co.uk>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iHrbJrEjthpal2HeTcDHDeHaPaRFsQg3Jijj0KNkDPZXhWiUYerwafVQjvxB?=
 =?us-ascii?Q?lKYn3bIjWqKBzTrfq7DR0J+tNQj5eFCVQox+M5PcjN4et69ohzgMRABXL0bp?=
 =?us-ascii?Q?IXbyDBD4zgLJfUA6WUJfieh89bvTI2rnjw2UkZZkUu45WrdVxvNqIdU9mVce?=
 =?us-ascii?Q?xiyQoMDd4meSUEG2MeCQUCH9lOeuRBIpLlpC/au2GafMTyBILWdATKrYIKhd?=
 =?us-ascii?Q?Fc7epvY4d5uMisW3aOjgddq/APy4TKnjmbkLqhF6rv1ZBdjqcFjAu92z4kdC?=
 =?us-ascii?Q?Rcg4Sg5H19TDG6T4QRlmb2SCO9l4A2PXl+CFuKG1txUdFZIPONpMeQgDp/10?=
 =?us-ascii?Q?6v+OQGIpGi26voydxMdr383Lb9OzynPTE2OODD2QyOsixbdhhNedaQ1uPzh1?=
 =?us-ascii?Q?NyxmssCswepNv7DBHIOr/nNGzljZvl68dAvMN1rjHd3b5H2Pa3zGhJRYKT2Q?=
 =?us-ascii?Q?m1SomiRntbouSXGLMPzYpWrtDT1e+klCaZFz7uIaUx9j8sQ434ZWehG3kKcv?=
 =?us-ascii?Q?DWcwUgzvMEXFoF3CFcdLIWPac4qavRr5dBgV6PY4DzzoJEfC3Hix0CYdG84h?=
 =?us-ascii?Q?AV3j98x9IvPUZ3LJQAHb4ooc3HwQmQ8H3rvNKT2JItH7HP6cdZgjDqYlzsTe?=
 =?us-ascii?Q?xGQR4U6R/1pchmrpVDFzAXf+zIf8yktAYbaBMi6i3EJSW1ei/7wyPC73lAWS?=
 =?us-ascii?Q?axFNLj9+I+aPTiP50DLUEUgZySeiYe7y4DtNOfQufwH2Eai+fqXYIzgadzSG?=
 =?us-ascii?Q?V3NIaw3GNQGhIWb8KZp3u2GZ6BCGjDnojK+cdfEVSq18Y7+0UVWt60essGZv?=
 =?us-ascii?Q?TgcfD6ziAoHa3VTt618JgkQuk8OKD3S4a0MCVO9nq+H/HunvBNe4HWody5G5?=
 =?us-ascii?Q?3bwl8vEVJZHar9tuWnd6GkqQj96O/YnlAyR8wfucKdhuSXatOmpVVn/lycc8?=
 =?us-ascii?Q?IWLM13RMy3ngc//SE5SpreBGKOcX0T1toK8liMc40ymeykuEplkA+e5Ye2/f?=
 =?us-ascii?Q?gvf+qKTXvAQAjfzjYoDQop2cIlfbeFxvsPudabDkCzBFVzzWRG3MWYMRmym5?=
 =?us-ascii?Q?pOcLpIhZKewqw22ymAvCSvD0EjkcuQ2pq0T2bJBu8TJguVnJeiNT/4upsKC6?=
 =?us-ascii?Q?vTpab1lCg6MEyFRxgBSgxeTE42l+7T2orSgKjQe23jbpjjM0EUhM2zP/lKMn?=
 =?us-ascii?Q?Rq87CDU+rXX9H7lWcXvZPgNXYcyyGg86Ct7WhSHtOvL69xR2UvTXDCiKmvKj?=
 =?us-ascii?Q?IEtn2A2Luiy46byfeQ8dSHMhqp0zVJsn6+59sC64OIvbXOUsxnUb89H1Ft82?=
 =?us-ascii?Q?uwdZh5YB0QWvfo8F+n5ma9m9irH7ofuejEb/9UTlStMf4uEvUQ5oJWXMau4M?=
 =?us-ascii?Q?SJrioLgMmKrLgcd7+prDW/ORiyPnp6Vcy6Pv2h4xT61WkqFF6T7vsi5tSxEb?=
 =?us-ascii?Q?rhn/CK4WnTE+6dfrkLEYBs0hwD/JMm9BkgQEtAY82YGmPJN6Zyosr+YhqgkA?=
 =?us-ascii?Q?SQJoFm+bqDqOBCRmeMkl92nR7yTvgiSpI2whCEp1Vxt1Q8cNVRHWpE3uyn58?=
 =?us-ascii?Q?bPg5d/tx25AB8M//oYrIYHf+/iXq5SBzowrBjqOm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d56ccd58-0aa3-4345-119a-08da6f0bd34a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 13:36:20.8235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hAo/QW9NasRyPQtN+9eViBNU6eifK0YriHH6KMljaQ4Q2JNdD85DU6CqP54R2/xW/BEsn3owaA8vlFqu3vPAJ+6uFS+841xOXebIV/C77jM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1742
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-26_04,2022-07-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 mlxscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207260051
X-Proofpoint-ORIG-GUID: Hci7YBRxdJK_jKJtPs60XSnJBrTG5V21
X-Proofpoint-GUID: Hci7YBRxdJK_jKJtPs60XSnJBrTG5V21
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 25, 2022 at 11:07:45PM +0100, Phillip Potter wrote:
> Convert the rtw_pwr_wakeup function to use 0 on success and an appropriate
> error code on error. For the first failure block where ips_leave is
> invoked, use -ENOMEM as this is the main cause of failure here anyway.
> For the second failure block, use -EBUSY, as it seems the most
> appropriate.
> 
> Finally, within the functions rtw_wx_set_mode, rtw_wx_set_wap,
> rtw_wx_set_scan and rtw_wx_set_essid, pass the error code on from
> rtw_pwr_wakeup as appropriate now that it is converted.
> 
> This gets the driver closer to removal of the non-standard _SUCCESS and
> _FAIL definitions, which are inverted compared to the standard in-kernel
> error code mechanism.
> 
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> 
> Changes from V1: Act on feedback from Dan Carpenter:
> * Try to use more appropriate error codes than -EPERM.
> * Revert the places where existing -1 was converted as they are out of
>   scope.
> * Preserve error codes in places where calling function already uses
>   proper negative semantics, so that they can be passed through to the
>   caller.
> 

This is a much better patch, right?  Everything hangs together better.

There are seven callers which need to be updated and all of them are
updated.

Reviewed-by: Dan Carpenter