Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 16:22:50 +0200
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     lewis.hanly@microchip.com, conor.dooley@microchip.com,
        trix@redhat.com, daire.mcnamara@microchip.com, a.zummo@towertech.it
Cc:     linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: remove 'pending' variable from
 mpfs_rtc_wakeup_irq_handler()
Message-ID: <165884535076.3156642.16325816554140473959.b4-ty@bootlin.com>
References: <20220627205943.2075043-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220627205943.2075043-1-trix@redhat.com>
Precedence: bulk

On Mon, 27 Jun 2022 16:59:43 -0400, Tom Rix wrote:
> cppcheck reports
> [drivers/rtc/rtc-mpfs.c:219]: (style) Variable 'pending' is assigned a value that is never used.
> 
> The fetched CONTROL_REG stored in pending is unused and partially
> duplicates the functionality of the later call to mpfs_rtc_clear().  This looks
> like leftover development code, so remove pending.
> 
> [...]

Applied, thanks!

[1/1] rtc: remove 'pending' variable from mpfs_rtc_wakeup_irq_handler()
      commit: 3fa0cb37bda9d45d3c6f07e67051e7118d3ffe63

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com