Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 18:46:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Phillip Potter <phil@philpotter.co.uk>
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        paskripkin@gmail.com, straube.linux@gmail.com, martin@kaiser.cx,
        abdun.nihaal@gmail.com, philipp.g.hortmann@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: convert rtw_pwr_wakeup to correct
 error code semantics
Message-ID: <20220726154602.GQ2316@kadam>
References: <20220725220745.12739-1-phil@philpotter.co.uk>
 <20220726133559.GP2338@kadam>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220726133559.GP2338@kadam>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1ze9hqZE5YZnKqwg1f5lAt4L/ZoRNn23Unv2iIozZD8plUN0CeVb56ZOsrc+?=
 =?us-ascii?Q?beg+CuqL0qjrjfubU38YtC8qxx0WxWBTx4ko/ohJ0rOZ6uPMeeYRdiJqHdL5?=
 =?us-ascii?Q?5L62K58VyTrg4ue6kqK9ZAbxIxAj0eZaBkxTcUGuBNo8k10pdb/HWWSnULX3?=
 =?us-ascii?Q?PWL7FcpCnYnpUPCU6VS33xB7Yd3RZtd7Qp4KA1nJlSyAZj+g1uXQjsupxCeJ?=
 =?us-ascii?Q?Hnx+LUJBbKUoossHmVhehQaWj+W7wmIEII6sCY//S2B1Xaeat+F9CiSbitMe?=
 =?us-ascii?Q?9/YjF8KV0iVkuHhJjviyIKItLDmk2/7Yi54xFkX2Uahr9Uqm8Kjx6RbWfyq1?=
 =?us-ascii?Q?SHvGGZ7MdUe418c5g2mRu8O0h035rtd7v21Zt8CAq/q7aceMaBb/IWPDXoI+?=
 =?us-ascii?Q?8K1Wz3b7jLwEQkt87+dEx4+sQ+DYBlVn/VGmkIZ2P0UBcZeyiBXtNzNBM/Xg?=
 =?us-ascii?Q?HTlvkm6wviX1UUPelGAagTdSQhuhq0J//qBhoh0AlOBMuj8Se6z2NiQezsK7?=
 =?us-ascii?Q?SlhYjokstSdZj/g5QIKLo6LpqWzp+KetYkZU5C9YJ0jOOLfP3S/22wWhvn3l?=
 =?us-ascii?Q?EZQskk4+pWwFQ+lgCx2zImz9IlW2Beimrkyx2DtI17nKPY0G8nZBma3jYjjv?=
 =?us-ascii?Q?LnubyZVwFlU4ylyzX6g/OiegNOyFg1LduX5334YMwMpkzWWBOm8Fkc7kso6J?=
 =?us-ascii?Q?5qVKSOrBi+gK+qHK4oYnsOPK+P4fkE2ke60a7TPVp3LZY8dNljRkcZxEWhpc?=
 =?us-ascii?Q?Rai59//+Xq03/pAQSbKzqNorZj+pX+yEhs77k6S8AOywv/2Jycwfkkvwowkr?=
 =?us-ascii?Q?pTd+YjqfPfkb4obgP/ITNxiQx30zmE5TB+RSzO53WO9TMaBMU3NvoyIHmcJc?=
 =?us-ascii?Q?Zgf6/ujkSelP+kUewGFA6A6K5HXek8kwnOwG5QkBcxwTWE5PoMavQNIBMVJY?=
 =?us-ascii?Q?9meoELfTCMR4PetueLtmn0PpnER2hR3UZ4tfmxbu0t5nfM9HM6rbIBz+uHny?=
 =?us-ascii?Q?2mlH0D+k81SjLJqOjzdR+ktHbRbVkm15iMQcJ/Mte+NrVuGF4hrAHqjPj7On?=
 =?us-ascii?Q?LCvikQY3MhGcHQ7EG3zndZHo0nKxTaXIYrKUHG2/BcLwiJI10m4mf4+CVVAZ?=
 =?us-ascii?Q?eoDtmCiHiQc3THqEGQadg4qCPSr76bnHQ48K72rqrGqr0SL4ffRu/4iNgC6N?=
 =?us-ascii?Q?jFZjfiJ7Wb6ghE99Ufy9dZ2y6Mz/FVPz6Rn4Dq/FSEbhVBnlHLU0UdL+YZCV?=
 =?us-ascii?Q?P7vfb/GYBOSB7bIcyjXzsFkZnfho4MaHaPSdw+CiJ9LInUp9mgd6w4BI1N00?=
 =?us-ascii?Q?F65v8wGjXWTXyt+xPr7PLU4quzJB58zmq1ZsUUwLDx3FhzaOMMuRzMaWR/sn?=
 =?us-ascii?Q?cwHFYWBVkEQPnioJC6CsAqR/ViSgMfD1LHqXk6Yzkv4ywv2bJAsTDsvIt+8V?=
 =?us-ascii?Q?PvNjHYltEkUoelfo+kWXmmE4lLCgLVrbBUZMyOGN2qC2gcZ80WYr4pfbwbfM?=
 =?us-ascii?Q?+6f8d69kLzq7HlwOUtnVx+UNnd2CrNpQggKOnbp1KSr1Db3JMdtEyby4AbXe?=
 =?us-ascii?Q?kmuFj+0xaJ92YTPtvJIRAyjXYpeqnvNh2cYp2xrPHyfPlTXiZd3H6PLdLIQb?=
 =?us-ascii?Q?BQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a94722e6-3575-47dd-af75-08da6f1df775
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:46:12.5578
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LKfeEtrzX2i+q/VJQvqfkiBZ8qk1GSttX3eYdFuR0eymBnZQ9f8hEuoQaFoGPl5sorBpqVmFfEgO8ySxEU3DGJ0yT2x8zGxrIeCfwtUWt9s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2339
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-26_04,2022-07-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207260060
X-Proofpoint-GUID: id15q6S0KEIK08S386vTsuoszOOlzntL
X-Proofpoint-ORIG-GUID: id15q6S0KEIK08S386vTsuoszOOlzntL
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 26, 2022 at 04:35:59PM +0300, Dan Carpenter wrote:
> On Mon, Jul 25, 2022 at 11:07:45PM +0100, Phillip Potter wrote:
> > Convert the rtw_pwr_wakeup function to use 0 on success and an appropriate
> > error code on error. For the first failure block where ips_leave is
> > invoked, use -ENOMEM as this is the main cause of failure here anyway.
> > For the second failure block, use -EBUSY, as it seems the most
> > appropriate.
> > 
> > Finally, within the functions rtw_wx_set_mode, rtw_wx_set_wap,
> > rtw_wx_set_scan and rtw_wx_set_essid, pass the error code on from
> > rtw_pwr_wakeup as appropriate now that it is converted.
> > 
> > This gets the driver closer to removal of the non-standard _SUCCESS and
> > _FAIL definitions, which are inverted compared to the standard in-kernel
> > error code mechanism.
> > 
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> > 
> > Changes from V1: Act on feedback from Dan Carpenter:
> > * Try to use more appropriate error codes than -EPERM.
> > * Revert the places where existing -1 was converted as they are out of
> >   scope.
> > * Preserve error codes in places where calling function already uses
> >   proper negative semantics, so that they can be passed through to the
> >   caller.
> > 
> 
> This is a much better patch, right?  Everything hangs together better.
> 
> There are seven callers which need to be updated and all of them are
> updated.
> 
> Reviewed-by: Dan Carpenter

Oops.  I messed up my R-b tag.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter